Re: PIP 23 : Message Tracing By Interceptors

2018-08-24 Thread Sijie Guo
On Fri, Aug 24, 2018 at 6:04 PM Matteo Merli wrote: > > Original, i just want to implement tracing by interceptors. We don’t must > > to binding “tracing” and “interceptors” together. > > I thougt that to implement message tracing in pulsar, we should implement > > interceptors before. And interc

Re: PIP 23 : Message Tracing By Interceptors

2018-08-24 Thread Matteo Merli
> Original, i just want to implement tracing by interceptors. We don’t must > to binding “tracing” and “interceptors” together. > I thougt that to implement message tracing in pulsar, we should implement > interceptors before. And interceptors might be useful in multiple scenarios. Yes, that's exa

Build failed in Jenkins: pulsar-master #745

2018-08-24 Thread Apache Jenkins Server
See Changes: [github] Added missing committers from "team" page (#2443) -- [...truncated 1005.35 KB...] [INFO] Pulsar IO :: Aerospike . SUCCESS [

Jenkins build is unstable: pulsar-master #744

2018-08-24 Thread Apache Jenkins Server
See

Build failed in Jenkins: pulsar-master #743

2018-08-24 Thread Apache Jenkins Server
See Changes: [sanjeevrk] allow predicates concerning publish time to push down to pulsar (#2414) -- [...truncated 1.08 MB...] [INFO] [INFO] --- maven-dependency-plugin:2.10

Re: PIP 23 : Message Tracing By Interceptors

2018-08-24 Thread 李鹏辉
Original, i just want to implement tracing by interceptors. We don’t must to binding “tracing” and “interceptors” together. I thougt that to implement message tracing in pulsar, we should implement interceptors before. And interceptors might be useful in multiple scenarios.

Re: PIP 23 : Message Tracing By Interceptors

2018-08-24 Thread Sijie Guo
On Thu, Aug 23, 2018 at 11:25 PM Matteo Merli wrote: > Hi Penghui, > > the proposal looks good to me. I like the approach of using interceptors > since they might be useful in multiple scenarios, for applications to add > custom logging or processing. > > For tracing, in particular, I think we sh