[Result] [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-08-01 Thread Sijie Guo
The vote is now closed with 3 +1s and no -1s. Binding +1s * Dave Fisher * Justin Mclean * Jim Jagielski Thank you, Sijie On Wed, Jul 25, 2018 at 11:17 AM Sijie Guo wrote: > This is the 5th release candidate for Apache Pulsar, version > 2.1.0-incubating. > > Link to the vote on dev@pulsar

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-30 Thread Sijie Guo
Can any people from IPMC help review and vote this release? Sijie On Wed, Jul 25, 2018 at 11:17 AM Sijie Guo wrote: > This is the 5th release candidate for Apache Pulsar, version > 2.1.0-incubating. > > Link to the vote on dev@pulsar list: > https://lists.apache.org/thread.html/9f1ec1266c02dde8

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-25 Thread Dave Fisher
Hi - Repeating my +1 IPMC binding from the dev list VOTE Regards, Dave > On Jul 25, 2018, at 11:17 AM, Sijie Guo wrote: > > This is the 5th release candidate for Apache Pulsar, version > 2.1.0-incubating. > > Link to the vote on dev@pulsar list: > https://lists.apache.org/thread.html/9f1ec126

[VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-25 Thread Sijie Guo
This is the 5th release candidate for Apache Pulsar, version 2.1.0-incubating. Link to the vote on dev@pulsar list: https://lists.apache.org/thread.html/9f1ec1266c02dde859d19e11a61416b3747eb4920d8bd8868dbb2988@%3Cdev.pulsar.apache.org%3E Pulsar is a highly scalable, low latency messaging platform

[RESULT] [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-25 Thread Sijie Guo
The vote for releasing Apache Pulsar 2.1.0-incubating is now closed. With a total of +3 binding votes and no -1 votes, the vote passes. +1s (binding): * Matteo Merli * Jerry Peng * Dave Fisher Thank you to all the reviewers for taking the time to validate this release. - Sijie On Thu, Jul 1

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-24 Thread Jerry Peng
Yup dave, we can definitely add that On Mon, Jul 23, 2018 at 7:20 PM Dave Fisher wrote: > Hi Jerry, > > > On Jul 23, 2018, at 3:05 PM, Jerry Peng > wrote: > > > > +1 for the 5th release candidate for Apache Pulsar, version > 2.1.0-incubating > > > > Source and binary files: > > > https://dist.a

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Dave Fisher
Hi Jerry, > On Jul 23, 2018, at 3:05 PM, Jerry Peng wrote: > > +1 for the 5th release candidate for Apache Pulsar, version 2.1.0-incubating > > Source and binary files: > https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/ > > I followed the release can

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Dave Fisher
Hi - > On Jul 23, 2018, at 4:55 PM, Matteo Merli wrote: > > On Mon, Jul 23, 2018 at 11:12 AM Dave Fisher wrote: > >> (3) Pulsar IO Connectors NAR files. >> Signature and checksums pass. >> LICENSE and DISCLAIMER exist in the top level of the package. >> LICENSE and NOTICE plus DEPENDENCIES exi

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Matteo Merli
On Mon, Jul 23, 2018 at 11:12 AM Dave Fisher wrote: > (3) Pulsar IO Connectors NAR files. > Signature and checksums pass. > LICENSE and DISCLAIMER exist in the top level of the package. > LICENSE and NOTICE plus DEPENDENCIES exist in the NAR files. > > ==> DISCLAIMER should be included in the NAR

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Matteo Merli
+1 Environment: MacOS 10.13 Checked: * Signatures, crc * Bin distribution: - NOTICE, README, LICENSE - Start standalone service and producer/consumer test * Src distribution: - NOTICE, README, LICENSE - Compile and unit tests - RAT check - Start standalone servic

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Jerry Peng
+1 for the 5th release candidate for Apache Pulsar, version 2.1.0-incubating Source and binary files: https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/ I followed the release candidate validation guide: https://github.com/apache/incubator-pulsar/wiki/Re

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Dave Fisher
Hi - +1 (IPMC Binding) Comment #1 - There are many more files to review in this release. :-) (1) Source release. Signature and checksums pass. Builds from source with the option that Sijie provided. Standalone starts NOTICE, LICENSE and DISCLAIMER look good. (2) Binary release Signature and che

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Ivan Kelly
The git error can be fixed by adding false It already has failOnUnableToExtractRepoInfo as false, which I assumed would cover this case. -Ivan On Mon, Jul 23, 2018 at 6:05 AM, Sijie Guo wrote: > any more review comments? > > - Sijie > > On Fri, Jul 20, 2018 at 1:13 PM Sijie Guo wrote: > >> Oka

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-22 Thread Sijie Guo
any more review comments? - Sijie On Fri, Jul 20, 2018 at 1:13 PM Sijie Guo wrote: > Okay will remove it. > > But just to clarify, the KEYS file I put in the voting email is the one > used for releases, the one contains my KEY. Please use the one in voting > email to verify. > > - Sijie > > On

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-20 Thread Sijie Guo
Okay will remove it. But just to clarify, the KEYS file I put in the voting email is the one used for releases, the one contains my KEY. Please use the one in voting email to verify. - Sijie On Fri, Jul 20, 2018 at 1:07 PM Dave Fisher wrote: > Hi Sijie, > > I was looking at the KEYS here: > ht

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-20 Thread Sijie Guo
Hi Dave, This is because gitcommit plugin in the maven profile. It assumes the working directory is a git repo. It can be skipped with " -Dmaven. *gitcommitid*.*skip*=true " If you run "mvn clean install -DskipTests -Dmaven.gitcommitid.skip=true", it should be working. I am not sure if that is an

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-20 Thread Dave Fisher
Hi Sijie, I was looking at the KEYS here: https://dist.apache.org/repos/dist/dev/incubator/pulsar/KEYS Probably that should be removed or updated from the release version. Regards, Dave > On Jul 20, 2018, at 12:58 PM, Sijie Guo wrote: > > HI Dave, > > My key is already there : > https://dis

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-20 Thread Sijie Guo
HI Dave, My key is already there : https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS Search "Sijie Guo" - Sijie On Fri, Jul 20, 2018 at 11:47 AM Dave Fisher wrote: > Hi Sijie, > > Please add your key to the KEYS file. > > Regards, > Dave > > > On Jul 19, 2018, at 4:43 PM, Sij

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-20 Thread Dave Fisher
Hi - I’m currently -1 as I get errors building from source in: [INFO] Apache Pulsar :: Protobuf shaded ... FAILURE [ 0.049 s] [ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:2.2.4:revision (git-info) on project protobuf-shaded: .git directory is not foun

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-20 Thread Dave Fisher
Hi Sijie, Please add your key to the KEYS file. Regards, Dave > On Jul 19, 2018, at 4:43 PM, Sijie Guo wrote: > > This is the 5th release candidate for Apache Pulsar, version > 2.1.0-incubating. > > It introduces following main features: > > - Pulsar I/O: a serverless connector framework bui

[DISCUSS][VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-20 Thread Dave Fisher
Hi - I noted an addition of libstdc++ linkage and the "GCC RUNTIME LIBRARY EXCEPTION”. This is likely to be OK, but has not been documented on the Legal Resolved webpage. See https://issues.apache.org/jira/projects/LEGAL/issues/LEGAL-390 for the NetBeans podling’s request. I don’t see an iss

[VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-19 Thread Sijie Guo
This is the 5th release candidate for Apache Pulsar, version 2.1.0-incubating. It introduces following main features: - Pulsar I/O: a serverless connector framework built on top of Pulsar Functions. - TieredStorage: offloads bookkeeper ledgers to a cold storage (like S3). - Stateful Function: Pul