[GitHub] merlimat commented on issue #539: C++ unit tests in less than a minute

2017-06-29 Thread git
: Failure Value of: numOfMessages Actual: 10 Expected: t Which is: 63060 [ FAILED ] BatchMessageTest.testSmallReceiverQueueSize (23243 ms) ``` This is an automated message from the Apache Git Service. To respond

[GitHub] nkurihar opened a new pull request #540: Bump up athenz version

2017-06-29 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] jai1 commented on a change in pull request #536: Added CMake build file and instructions for Pulsar Wireshark dissector

2017-06-29 Thread git
ROTO_LIBRARIES NAMES libprotobuf.a) Review comment: find_package(ProtoBuf QUIET) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment.

[GitHub] jai1 commented on a change in pull request #536: Added CMake build file and instructions for Pulsar Wireshark dissector

2017-06-29 Thread git
tomated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] jai1 commented on a change in pull request #536: Added CMake build file and instructions for Pulsar Wireshark dissector

2017-06-29 Thread git
development headers, necessary in order to build the plugin. + +```shell +$ brew install wireshark --with-headers +``` Review comment: brew link --overwrite wireshark (if required) This is an automated message from the Apache Git

[GitHub] jai1 commented on a change in pull request #536: Added CMake build file and instructions for Pulsar Wireshark dissector

2017-06-29 Thread git
${GLIB_INCLUDE_DIRS} Review comment: Change ${GLIB_INCLUDE_DIRS} to ${GLIB_INCLUDE_PATH} AND add ${PROTOBUF_INCLUDE_DIR} This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] rdhabalia commented on issue #536: Added CMake build file and instructions for Pulsar Wireshark dissector

2017-06-29 Thread git
build.?? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure a

[GitHub] merlimat commented on issue #536: Added CMake build file and instructions for Pulsar Wireshark dissector

2017-06-29 Thread git
just the c++ client library. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] merlimat commented on a change in pull request #536: Added CMake build file and instructions for Pulsar Wireshark dissector

2017-06-29 Thread git
ROTO_LIBRARIES NAMES libprotobuf.a) Review comment: I want to get the static version of it so that the wireshark plugin is self-contained This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] merlimat commented on a change in pull request #536: Added CMake build file and instructions for Pulsar Wireshark dissector

2017-06-29 Thread git
lib-2.0)`, one line below This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] merlimat closed pull request #539: C++ unit tests in less than a minute

2017-06-29 Thread git
merlimat closed pull request #539: C++ unit tests in less than a minute URL: https://github.com/apache/incubator-pulsar/pull/539 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] merlimat commented on a change in pull request #536: Added CMake build file and instructions for Pulsar Wireshark dissector

2017-06-29 Thread git
Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rdhabalia opened a new pull request #541: Message size validation on post compression

2017-06-29 Thread git
less than it then producer will publish the message successfully. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For

[GitHub] msb-at-yahoo commented on a change in pull request #541: Message size validation on post compression

2017-06-29 Thread git
Size = payload.readableBytes(); +if (compressedSize > Commands::MaxMessageSize) { +if (conf_.getBlockIfQueueFull()) { Review comment: why this check? This is an automated message from the Apache Git Service. To respond

[GitHub] msb-at-yahoo commented on a change in pull request #541: Message size validation on post compression

2017-06-29 Thread git
t's bizarre a too large message would have anything to do with the send queue size. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the s

[GitHub] tkb77 opened a new pull request #542: Fixed license link

2017-06-29 Thread git
page in README.md This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] jai1 commented on a change in pull request #541: Message size validation on post compression

2017-06-29 Thread git
client This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apa

[GitHub] jai1 commented on a change in pull request #541: Message size validation on post compression

2017-06-29 Thread git
om/jai1/9c013fa1ab174d754108e58ce4cb0e7d This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastruc

[GitHub] jai1 commented on a change in pull request #541: Message size validation on post compression

2017-06-29 Thread git
om/jai1/9c013fa1ab174d754108e58ce4cb0e7d This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastruc

[GitHub] merlimat closed pull request #540: Bump up athenz version

2017-06-29 Thread git
merlimat closed pull request #540: Bump up athenz version URL: https://github.com/apache/incubator-pulsar/pull/540 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] merlimat closed pull request #542: Fixed license link

2017-06-29 Thread git
merlimat closed pull request #542: Fixed license link URL: https://github.com/apache/incubator-pulsar/pull/542 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] rdhabalia commented on a change in pull request #541: Message size validation on post compression

2017-06-30 Thread git
utomated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rdhabalia commented on a change in pull request #541: Message size validation on post compression

2017-06-30 Thread git
bug log. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards,

[GitHub] merlimat closed pull request #530: Support wildcard in permitted role name

2017-06-30 Thread git
merlimat closed pull request #530: Support wildcard in permitted role name URL: https://github.com/apache/incubator-pulsar/pull/530 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] merlimat closed pull request #535: Enable TLS Client Authentication on WebSocketProxy and DiscoveryService

2017-06-30 Thread git
merlimat closed pull request #535: Enable TLS Client Authentication on WebSocketProxy and DiscoveryService URL: https://github.com/apache/incubator-pulsar/pull/535 This is an automated message from the Apache Git Service

[GitHub] yush1ga opened a new pull request #543: Added documents for wildcard matching in authorization

2017-06-30 Thread git
Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rdhabalia commented on issue #537: Speed up CPP Unit Tests

2017-06-30 Thread git
we make sure that topic name in all tests are different else tests may fail intermittently as they share same broker instance? This is an automated message from the Apache Git Service. To respond to the message, please log on Git

[GitHub] saandrews commented on a change in pull request #543: Added documents for wildcard matching in authorization

2017-06-30 Thread git
sentence? Wildcard authorization can be performed when `authorizationAllowWildcardsMatching` is set to `true` in `broker.conf`. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] yush1ga commented on a change in pull request #543: Added documents for wildcard matching in authorization

2017-06-30 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

[GitHub] saandrews commented on issue #536: Added CMake build file and instructions for Pulsar Wireshark dissector

2017-06-30 Thread git
ve it built, so we can keep it up todate as well? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] saandrews commented on a change in pull request #543: Added documents for wildcard matching in authorization

2017-06-30 Thread git
and consume. + + +**Note**: A wildcard mathing works at **the beginning or end of the role name only**. Review comment: Did you mean matching ? This is an automated message from the Apache Git Service. To respond to the message

[GitHub] rdhabalia opened a new issue #544: Intermittent test failure: BrokerClientIntegrationTest.testCloseBrokerService

2017-06-30 Thread git
kedBooter.java:242) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rdhabalia closed issue #515: Intermittent failure of BrokerClientIntegrationTest .testDisconnectClientWithoutClosingConnection

2017-06-30 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rdhabalia opened a new pull request #545: Fix: intermittent test failure for BrokerClientIntegrationTest.testCloseBrokerService

2017-06-30 Thread git
`BrokerClientIntegrationTest.testCloseBrokerService` by adding strategical retry. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For

[GitHub] yush1ga commented on a change in pull request #543: Added documents for wildcard matching in authorization

2017-06-30 Thread git
consume. + + +**Note**: A wildcard mathing works at **the beginning or end of the role name only**. Review comment: Yes, I fixed it. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] rdhabalia closed pull request #545: Fix: intermittent test failure for BrokerClientIntegrationTest.testCloseBrokerService

2017-06-30 Thread git
Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rdhabalia closed issue #544: Intermittent test failure: BrokerClientIntegrationTest.testCloseBrokerService

2017-06-30 Thread git
rdhabalia closed issue #544: Intermittent test failure: BrokerClientIntegrationTest.testCloseBrokerService URL: https://github.com/apache/incubator-pulsar/issues/544 This is an automated message from the Apache Git Service

[GitHub] yush1ga commented on issue #543: Added documents for wildcard matching in authorization

2017-06-30 Thread git
-pulsar/blob/1994f4f0b3e3ede13223838ade4b7c989f3e13d3/conf/websocket.conf#L62 I will fix it in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above

[GitHub] yush1ga commented on issue #543: Added documents for wildcard matching in authorization

2017-06-30 Thread git
? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache

[GitHub] rdhabalia commented on a change in pull request #543: Added documents for wildcard matching in authorization

2017-06-30 Thread git
wildcard matching in authorization (wildcard matching only applicable if wildcard-char : * presents at first or last position eg: *.pulsar.service, pulsar.service.*)` ??? This is an automated message from the Apache Git Service. To

[GitHub] yush1ga commented on a change in pull request #543: Added documents for wildcard matching in authorization

2017-06-30 Thread git
ption. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apach

[GitHub] merlimat opened a new pull request #546: Disabled deployment of SNAPSHOT jars to Sonatype repository

2017-06-30 Thread git
message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] yush1ga opened a new pull request #547: Add wildcard matching setting for DiscoveryService

2017-06-30 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With

[GitHub] merlimat commented on issue #394: Remove Managed Ledger metadata text format

2017-07-05 Thread git
? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] merlimat commented on issue #546: Disabled deployment of SNAPSHOT jars to Sonatype repository

2017-07-05 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] merlimat closed pull request #546: Disabled deployment of SNAPSHOT jars to Sonatype repository

2017-07-05 Thread git
merlimat closed pull request #546: Disabled deployment of SNAPSHOT jars to Sonatype repository URL: https://github.com/apache/incubator-pulsar/pull/546 This is an automated message from the Apache Git Service. To respond

[GitHub] merlimat commented on issue #471: Generate C++ protobuf code during cmake build

2017-07-05 Thread git
from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] merlimat closed pull request #471: Generate C++ protobuf code during cmake build

2017-07-05 Thread git
merlimat closed pull request #471: Generate C++ protobuf code during cmake build URL: https://github.com/apache/incubator-pulsar/pull/471 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] rdhabalia commented on a change in pull request #514: Static link dependency libraries for C++ client lib and Python wrapper

2017-07-05 Thread git
: `liblog4cxx.a` is this correct? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] rdhabalia commented on a change in pull request #514: Static link dependency libraries for C++ client lib and Python wrapper

2017-07-05 Thread git
: `liblog4cxx.a` is this correct? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] merlimat opened a new pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-05 Thread git
a stateless service that talk Pulsar binary protocol. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] rdhabalia closed pull request #541: Message size validation on post compression

2017-07-05 Thread git
rdhabalia closed pull request #541: Message size validation on post compression URL: https://github.com/apache/incubator-pulsar/pull/541 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] saandrews commented on issue #514: Static link dependency libraries for C++ client lib and Python wrapper

2017-07-05 Thread git
might be useful. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] merlimat commented on issue #514: Static link dependency libraries for C++ client lib and Python wrapper

2017-07-05 Thread git
ely it's not easy to have both builds since it needs to search for different dependencies. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to g

[GitHub] saandrews commented on issue #514: Static link dependency libraries for C++ client lib and Python wrapper

2017-07-06 Thread git
e Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] merlimat commented on issue #514: Static link dependency libraries for C++ client lib and Python wrapper

2017-07-06 Thread git
-- Matteo Merli This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache

[GitHub] merlimat commented on issue #514: Static link dependency libraries for C++ client lib and Python wrapper

2017-07-06 Thread git
---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] saandrews commented on issue #514: Static link dependency libraries for C++ client lib and Python wrapper

2017-07-06 Thread git
the dependencies. This is what I was referring to. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about t

[GitHub] merlimat closed pull request #547: Add wildcard matching setting for DiscoveryService

2017-07-06 Thread git
merlimat closed pull request #547: Add wildcard matching setting for DiscoveryService URL: https://github.com/apache/incubator-pulsar/pull/547 This is an automated message from the Apache Git Service. To respond to the

[GitHub] cckellogg opened a new pull request #549: Allow cumulative acknowledgements for Failover subscriptions.

2017-07-06 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] rdhabalia opened a new pull request #550: ZookeeperCache children-cache invalidation on watch-event and LoadMa?

2017-07-06 Thread git
est bundle ownership data and broker restart will not cause downtime for bundle assignment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to th

[GitHub] rdhabalia commented on issue #523: Max Payload size is validated before compression

2017-07-06 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rdhabalia closed issue #523: Max Payload size is validated before compression

2017-07-06 Thread git
rdhabalia closed issue #523: Max Payload size is validated before compression URL: https://github.com/apache/incubator-pulsar/issues/523 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] rdhabalia closed issue #291: broker api to increase number of partitions of broker

2017-07-06 Thread git
rdhabalia closed issue #291: broker api to increase number of partitions of broker URL: https://github.com/apache/incubator-pulsar/issues/291 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jai1 opened a new issue #551: Problems in lookup flow in C++ Client

2017-07-06 Thread git
Not sure why this is happening or it's side effects. ** Note: ** Will attach the relevant log files with the Pull Request for the fixes. This is an automated message from the Apache Git Service. To respond to t

[GitHub] merlimat commented on issue #551: Problems in lookup flow in C++ Client

2017-07-06 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] lucperkins opened a new pull request #552: Travis CI setup for generating the website (work in progress)

2017-07-07 Thread git
lucperkins opened a new pull request #552: Travis CI setup for generating the website (work in progress) URL: https://github.com/apache/incubator-pulsar/pull/552 This is an automated message from the Apache Git Service. To

[GitHub] lucperkins closed pull request #552: Travis CI setup for generating the website (work in progress)

2017-07-07 Thread git
lucperkins closed pull request #552: Travis CI setup for generating the website (work in progress) URL: https://github.com/apache/incubator-pulsar/pull/552 This is an automated message from the Apache Git Service. To

[GitHub] lucperkins commented on issue #552: Travis CI setup for generating the website (work in progress)

2017-07-07 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rdhabalia commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-07 Thread git
ormat? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure a

[GitHub] rdhabalia commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-07 Thread git
d message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rdhabalia commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-07 Thread git
} else { +inboundChannel.close(); Review comment: should we log warn message here? -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries

[GitHub] rdhabalia commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-07 Thread git
up); +} + +private void close() { +ctx.close(); Review comment: should we have additional state= 'ConnectionClosed` ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go t

[GitHub] rdhabalia commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-07 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org

[GitHub] rdhabalia commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-07 Thread git
eady, e.getMessage(), clientRequestId)); Review comment: `ServerError.MetadataError`? ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to th

[GitHub] rdhabalia commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-07 Thread git
on `outboundChannel` on line-107, so channel-handler will continue reading even if we don't call here. right? -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] rdhabalia commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-07 Thread git
) { +public CompletableFuture> getBroker(DestinationName destination) { Review comment: do you think using InetSocketAddress[] would be better to avoid creation of Pair object here. This is an automated message from the Apache

[GitHub] jai1 opened a new pull request #553: Fix for Problems in lookup flow in C++ Client (#551) - Issue 1

2017-07-07 Thread git
okers gets killed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please co

[GitHub] lucperkins closed pull request #554: Travis CI setup for website (work in progress)

2017-07-07 Thread git
lucperkins closed pull request #554: Travis CI setup for website (work in progress) URL: https://github.com/apache/incubator-pulsar/pull/554 This is an automated message from the Apache Git Service. To respond to the

[GitHub] lucperkins opened a new pull request #554: Travis CI setup for website (work in progress)

2017-07-07 Thread git
lucperkins opened a new pull request #554: Travis CI setup for website (work in progress) URL: https://github.com/apache/incubator-pulsar/pull/554 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jai1 opened a new pull request #555: Fix for Problems in lookup flow in C++ Client (#551) - Issue 2

2017-07-07 Thread git
race conditions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] saandrews closed pull request #553: Fix reconnection error in C++ client

2017-07-07 Thread git
saandrews closed pull request #553: Fix reconnection error in C++ client URL: https://github.com/apache/incubator-pulsar/pull/553 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] merlimat closed pull request #549: Allow cumulative acknowledgements for Failover subscriptions.

2017-07-07 Thread git
merlimat closed pull request #549: Allow cumulative acknowledgements for Failover subscriptions. URL: https://github.com/apache/incubator-pulsar/pull/549 This is an automated message from the Apache Git Service. To respond

[GitHub] jai1 opened a new pull request #556: CPP Client - Reducing number of duplicate lookups

2017-07-07 Thread git
ucers/consumers map if CLOSE_PRODUCER / CLOSE_CONSUMER command is received. ### Result No functional change, lesser lookups. This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] rdhabalia closed pull request #550: ZookeeperCache children-cache invalidation on watch-event and LoadMa?

2017-07-07 Thread git
rdhabalia closed pull request #550: ZookeeperCache children-cache invalidation on watch-event and LoadMa? URL: https://github.com/apache/incubator-pulsar/pull/550 This is an automated message from the Apache Git Service

[GitHub] rdhabalia commented on issue #556: CPP Client - Reducing number of duplicate lookups

2017-07-07 Thread git
=true This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

[GitHub] merlimat commented on a change in pull request #555: CPP Client - Accessing connection_ pointer under a lock

2017-07-07 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] merlimat commented on a change in pull request #555: CPP Client - Accessing connection_ pointer under a lock

2017-07-07 Thread git
inter itself doesn't need it, and every time we access the weak pointer, we convert into a shared_ptr anyway to ensure it's still valid This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] merlimat commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-07 Thread git
broker for the authorization, trusting that the proxy has already validated the authentication. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to

[GitHub] merlimat commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-07 Thread git
to false. The reason is to adapt to the speed of the slowest connection. So, we read 1 buffer from `c1`, write into `c2`. When the write is completed (meaning we were able to write on the socket because the TCP send window was open), then we read the next buffer. ------

[GitHub] rdhabalia commented on issue #451: Introduce non-persistent topic

2017-07-09 Thread git
#538 and #452 . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] jai1 commented on a change in pull request #555: CPP Client - Accessing connection_ pointer under a lock

2017-07-10 Thread git
x" and disconnectConsumer "connection_.reset()" can happen at the same time on different threads, hence the lock This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] jai1 commented on a change in pull request #555: CPP Client - Accessing connection_ pointer under a lock

2017-07-10 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] merlimat commented on a change in pull request #555: CPP Client - Accessing connection_ pointer under a lock

2017-07-10 Thread git
needed, but it doesn't do any harm either This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries abou

[GitHub] lucperkins opened a new pull request #557: New website and documentation

2017-07-10 Thread git
. Although much work remains, I feel strongly that this is a solid first incarnation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the

[GitHub] merlimat commented on issue #557: New website and documentation

2017-07-10 Thread git
from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] merlimat commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-10 Thread git
be there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructu

[GitHub] merlimat commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-10 Thread git
is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] merlimat commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-10 Thread git
Review comment: Fixed -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] merlimat commented on a change in pull request #548: PIP-1 - Introduce Pulsar proxy component

2017-07-10 Thread git
otReady, e.getMessage(), clientRequestId)); Review comment: Makes more sense. Fixed ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment.

  1   2   3   4   5   6   7   8   9   >