ands...
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at
nt64_t requestId) {
+BaseCommand cmd;
Review comment:
sure, updated PR with suggested approach.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
clear the scope in which the `cmd` and `mutex` are used.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries ab
stId);
Review comment:
yes, make sense. updated it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries a
stId);
Review comment:
yes, make sense. updated it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries a
tinue iterate on
the content.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
tinue iterate on
the content.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
comment:
license doesn't present in beginning, will it fail in license check ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the spe
+
+The Pulsar documentation is available in the following languages:
+
+
[Japanese]({{ site.baseurl }}ja)
Review comment:
are we missing correct img path here?
This is an automated message from the Apache Git Service.
To
+---
Review comment:
is this table expected in all `.md` file, may it's required in site
generation?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above
+---
Review comment:
Yes, that's standard practice for all Markdown converters (in this case
Jekyll) to have a YAML preamble with metadata
This is an automated message from the Apache Git Service.
To respond to the message, pleas
comment:
Yes, verified that still passes the check
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this
automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
compile from sources.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
5 sec.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at
merlimat commented on issue #557: New website and documentation
URL: https://github.com/apache/incubator-pulsar/pull/557#issuecomment-315137611
@rdhabalia Updated
This is an automated message from the Apache Git Service.
To
jai1 closed pull request #561: Fix: CPP release baseCommand after serializing it
URL: https://github.com/apache/incubator-pulsar/pull/561
This is an automated message from the Apache Git Service.
To respond to the message
-pulsar/builds/252621888
Do you have any idea what could it be?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For
)
build passed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
local build even before that
commit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
merlimat commented on issue #507: Add zk-stats instrumentation to get zk-client
stats
URL: https://github.com/apache/incubator-pulsar/pull/507#issuecomment-315158904
@rdhabalia I did a `git bisect` locally and it started failing at this
commit :)
It reproduces consistently on
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
loading in test.
### Result
prevents build failure.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With
ssage from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
merlimat closed pull request #565: disable ZooKeeperClientAspectJTest test
URL: https://github.com/apache/incubator-pulsar/pull/565
This is an automated message from the Apache Git Service.
To respond to the message
Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
ented?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
merlimat closed pull request #566: Fix test : avoid multiple registration of
zkClient-aspect in test
URL: https://github.com/apache/incubator-pulsar/pull/566
This is an automated message from the Apache Git Service.
To
ut the way.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
merlimat closed pull request #557: New website and documentation
URL: https://github.com/apache/incubator-pulsar/pull/557
This is an automated message from the Apache Git Service.
To respond to the message, please log on
`master`
### Result
Every commit on master, that creates a change in the website, will trigger
the publishing of the new generated content.
This is an automated message from the Apache Git Service.
To respond to the
merlimat closed pull request #567: Publish website after commits on master
branch
URL: https://github.com/apache/incubator-pulsar/pull/567
This is an automated message from the Apache Git Service.
To respond to the message
the current master. I can still reproduce it
locally. I think we should just merge your other PR that disabled the tests for
now, until we figure out a way.
This is an automated message from the Apache Git Service.
To respond to
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
merlimat closed pull request #565: disable ZooKeeperClientAspectJTest test
URL: https://github.com/apache/incubator-pulsar/pull/565
This is an automated message from the Apache Git Service.
To respond to the message
essage from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
merlimat commented on issue #566: Fix test : avoid multiple registration of
zkClient-aspect in test
URL: https://github.com/apache/incubator-pulsar/pull/566#issuecomment-315238911
I was doing
```
mvn clean install -DskipTests && mvn test -pl pulsar-broker
```
from
later ;)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at
a, 0, data.length, EmptyItem);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
ed numberOfItems (makes a
copy)
+ */
+public Set items(int numberOfItems) {
+Set items = new HashSet<>();
Review comment:
Same here, we already know how many we expect at most
----
This is an automated message
*
+ * @return a new list of all keys (makes a copy)
+ */
+public Set items() {
+Set items = new HashSet<>();
Review comment:
Should we create the `HashSet` with the hint on the number of items?
--------
This is an
y, to avoid
copying the whole queue and creating many `LongPair` instances?
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries a
onal array which just keeps list of deleted items and then
it deletes from the heap.
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specif
------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
eaders=host&X-Amz-Signature=45d27c09815e217e41eedb57c8b92a87b834273f322df1bbc38026524052456d)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific co
### Result
It should not crash the jvm while running tests.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment
handling.
### Modifications
Grouped the instantation of the `EventLoopGroup` into one single util class.
### Result
Better organized code.
This is an automated message from the Apache Git Service.
To
yush1ga closed pull request #559: Add empty check for subscription name
URL: https://github.com/apache/incubator-pulsar/pull/559
This is an automated message from the Apache Git Service.
To respond to the message, please
ent:
can we still add check `Epoll.isAvailable()` to make sure os supports the
group?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the spe
`SocketChannel` needs to match
the `EventLoopGroup` implementation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For
https://pulsar.incubator.apache.org
Steps to reproduce
Go to https://pulsar.incubator.apache.org
System configuration
**Pulsar version**: N/A
This is an automated message from the Apache Git Service.
To re
we're waiting for Apache INFRA
to setup the publishing bridge. See
https://issues.apache.org/jira/browse/INFRA-14587
It should be up in the next few days and I'll update this issue.
This is an automated message from
tomated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
de us with a way to replace
this dependency with another one or implement all coordination on it's own (as
Mesos is working on now)
This is an automated message from the Apache Git Service.
To respond to the message, pleas
iple times.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
https://gist.github.com/rdhabalia/11f138d491693a6dccab933737f6a59e)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries
is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
merlimat closed pull request #569: Revert back to default
ZookeeperClientFactoryImpl
URL: https://github.com/apache/incubator-pulsar/pull/569
This is an automated message from the Apache Git Service.
To respond to the
merlimat closed pull request #573: Fix: register zk-stats listener after broker
service started
URL: https://github.com/apache/incubator-pulsar/pull/573
This is an automated message from the Apache Git Service.
To respond
encompasses a wide range of
documentation changes?mostly content but also CSS?that should be introduced
once the Apache site goes live.
This is an automated message from the Apache Git Service.
To respond to the message
merlimat closed pull request #570: Simplified the instantiation of Netty
EventLoopGroup
URL: https://github.com/apache/incubator-pulsar/pull/570
This is an automated message from the Apache Git Service.
To respond to the
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
/incubator-pulsar` repo.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
merlimat closed pull request #576: Only deploy releases and website from
apache/incubator-pulsar repo
URL: https://github.com/apache/incubator-pulsar/pull/576
This is an automated message from the Apache Git Service.
To
` api.
### Modifications
Add `receiveAsync` api to cpp-client library.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific co
Test.httpsLookupTest:52 ? ThreadTimeout Method
org.testng.intern...
```
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For
:
```java
PulsarClientImpl testClient = (PulsarClientImpl)
service.getPulsarClient();
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL
:
```java
PulsarClientImpl testClient = (PulsarClientImpl) service.getPulsarClient();
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
ine :
yes, thread is stuck while creating `PulsarClientImpl` but don't see a clear
reason, looking into it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
explicitly set, read clusters data from ZK
localCluster = retrieveClusterData();
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the
message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
/pulsar/websocket/WebSocketService.java#L85)
creates `localCluster` on service init so, in this test-case, it should not be
null.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
merlimat closed pull request #563: Fixes for NOTICE and LICENSE files for src
and bin distribution
URL: https://github.com/apache/incubator-pulsar/pull/563
This is an automated message from the Apache Git Service.
To
/pulsar/builds/254662796
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
orkedBooter.runSuitesInProcess(ForkedBooter.java:242)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
```
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log o
and not use any C++11 features in the interface?
If not then I can start work on the same.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to
)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
target?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure
Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
jai1 closed issue #578: Intermittent test failure: Websocket.LookupProtocolTest
URL: https://github.com/apache/incubator-pulsar/issues/578
This is an automated message from the Apache Git Service.
To respond to the message
jai1 closed pull request #580: Fix #578: Force early load of epoll library to
avoid race condition
URL: https://github.com/apache/incubator-pulsar/pull/580
This is an automated message from the Apache Git Service.
To
very long
time.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastru
size.
We should redirect the tests output to files to reduce the text output. Also
it gives the advantage of separating each test output into a separate file.
This is an automated message from the Apache Git Service.
To respond
automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
"Project" in Github to track
all the various tasks in tickets.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comm
r now
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apach
merlimat closed pull request #581: Use redirectTestOutputToFile in unit tests
to reduce build output size
URL: https://github.com/apache/incubator-pulsar/pull/581
This is an automated message from the Apache Git Service
201 - 300 of 840 matches
Mail list logo
