[jira] Created: (QPID-3140) Invalid handling of qpid.max_size

2011-03-14 Thread Gordon Sim (JIRA)
Invalid handling of qpid.max_size - Key: QPID-3140 URL: https://issues.apache.org/jira/browse/QPID-3140 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: 0.8, 0.10

Re: ExchangeTest failing on trunk

2011-03-14 Thread Carl Trieloff
On 03/12/2011 12:18 PM, Alan Conway wrote: This test (one of the C++ unit tests) is failing on trunk: ../../../qpid/cpp/src/tests/ExchangeTest.cpp(282): error in testIVEOption: check 1u == queue3-getMessageCount() failed [1 != 0] Failure appears to be introduced by r1080411: Author: Carl C.

Re: ExchangeTest failing on trunk

2011-03-14 Thread Gordon Sim
On 03/14/2011 01:46 PM, Carl Trieloff wrote: On 03/12/2011 12:18 PM, Alan Conway wrote: This test (one of the C++ unit tests) is failing on trunk: ../../../qpid/cpp/src/tests/ExchangeTest.cpp(282): error in testIVEOption: check 1u == queue3-getMessageCount() failed [1 != 0] Failure appears to

Re: svn commit: r1080411 - in /qpid/trunk/qpid/cpp/src/qpid/broker: TopicExchange.cpp TopicExchange.h

2011-03-14 Thread Carl Trieloff
On 03/11/2011 06:14 AM, Gordon Sim wrote: ..the iterator may be invalidated by a subsequent update to the map once the lock is released. Testing against bindingCache.end() outside the lock is also not safe. I don't believe so, as it holds a smart pointer, the smart pointer will hold the

Re: ExchangeTest failing on trunk

2011-03-14 Thread Carl Trieloff
On 03/14/2011 09:53 AM, Gordon Sim wrote: On 03/14/2011 01:46 PM, Carl Trieloff wrote: On 03/12/2011 12:18 PM, Alan Conway wrote: This test (one of the C++ unit tests) is failing on trunk: ../../../qpid/cpp/src/tests/ExchangeTest.cpp(282): error in testIVEOption: check 1u ==

Re: Testing

2011-03-14 Thread Justin Ross
Hi, Andrew. I very much agree with your complaint and analysis. One of the things I will be proposing and implementing for 0.12 is a new top-level entry point for qpid tests. The idea is that this would be the one place to go to get an up or down result on a change. Our current situation

Re: svn commit: r1080411 - in /qpid/trunk/qpid/cpp/src/qpid/broker: TopicExchange.cpp TopicExchange.h

2011-03-14 Thread Gordon Sim
On 03/14/2011 01:59 PM, Carl Trieloff wrote: On 03/11/2011 06:14 AM, Gordon Sim wrote: ..the iterator may be invalidated by a subsequent update to the map once the lock is released. Testing against bindingCache.end() outside the lock is also not safe. I don't believe so, as it holds a smart

Re: 0-10 JIRAs

2011-03-14 Thread Justin Ross
Using 0.9 and 0.10 as an example: 0.9 is simply another name for 0.10-dev. Qpid developers know this, so they can resolve a 0.9 bug to the 0.10 release just as easily as they can resolve a 0.10-dev bug to the 0.10 release. And of course, all release versions would appear in jira. Justin

Re: svn commit: r1080411 - in /qpid/trunk/qpid/cpp/src/qpid/broker: TopicExchange.cpp TopicExchange.h

2011-03-14 Thread Gordon Sim
On 03/14/2011 02:07 PM, Gordon Sim wrote: On 03/14/2011 01:59 PM, Carl Trieloff wrote: On 03/11/2011 06:14 AM, Gordon Sim wrote: ..the iterator may be invalidated by a subsequent update to the map once the lock is released. Testing against bindingCache.end() outside the lock is also not safe.

Re: svn commit: r1080411 - in /qpid/trunk/qpid/cpp/src/qpid/broker: TopicExchange.cpp TopicExchange.h

2011-03-14 Thread Carl Trieloff
On 03/14/2011 10:07 AM, Gordon Sim wrote: Its the iterator that is the issue, not the smart pointer that it points to. You test (it == bindingCache.end()) outside the lock and that is not safe. FYI -- .end() function is independent of the validity of the iterator. 'it' will either == the

[jira] Commented: (QPID-3137) old examples are installed incorrectly

2011-03-14 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006418#comment-13006418 ] Andrew Stitcher commented on QPID-3137: --- Change looks fine for 0.10 branch to me.

Re: svn commit: r1080411 - in /qpid/trunk/qpid/cpp/src/qpid/broker: TopicExchange.cpp TopicExchange.h

2011-03-14 Thread Andrew Stitcher
On Mon, 2011-03-14 at 10:12 -0400, Carl Trieloff wrote: On 03/14/2011 10:07 AM, Gordon Sim wrote: Its the iterator that is the issue, not the smart pointer that it points to. You test (it == bindingCache.end()) outside the lock and that is not safe. FYI -- .end() function is

[jira] Updated: (QPID-2693) Broker instability with the topic exchange

2011-03-14 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-2693: - Affects Version/s: 0.10 0.9 Fix Version/s: (was: 0.9)

[jira] Resolved: (QPID-3137) old examples are installed incorrectly

2011-03-14 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-3137. -- Resolution: Fixed old examples are installed incorrectly --

[jira] Created: (QPID-3142) enable brokers to use a pre-populated QPID-WORK directory during test run

2011-03-14 Thread Robbie Gemmell (JIRA)
enable brokers to use a pre-populated QPID-WORK directory during test run - Key: QPID-3142 URL: https://issues.apache.org/jira/browse/QPID-3142 Project: Qpid Issue

RE: svn commit: r1080411 - in /qpid/trunk/qpid/cpp/src/qpid/broker: TopicExchange.cpp TopicExchange.h

2011-03-14 Thread Steve Huston
-Original Message- From: Andrew Stitcher [mailto:astitc...@redhat.com] ... On Mon, 2011-03-14 at 10:12 -0400, Carl Trieloff wrote: On 03/14/2011 10:07 AM, Gordon Sim wrote: Its the iterator that is the issue, not the smart pointer that it points to. You test (it ==

[jira] Commented: (QPID-1811) Unable to compile qpid on FreeBSD

2011-03-14 Thread Sudip Kumar Panda (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006474#comment-13006474 ] Sudip Kumar Panda commented on QPID-1811: - Can someone tell me if the poll or

[jira] Created: (QPID-3143) session.createQueue is neither spec compliant nor backwards compatible

2011-03-14 Thread Rajith Attapattu (JIRA)
session.createQueue is neither spec compliant nor backwards compatible -- Key: QPID-3143 URL: https://issues.apache.org/jira/browse/QPID-3143 Project: Qpid Issue Type: Bug

Re: svn commit: r1080411 - in /qpid/trunk/qpid/cpp/src/qpid/broker: TopicExchange.cpp TopicExchange.h

2011-03-14 Thread Gordon Sim
On 03/14/2011 02:12 PM, Carl Trieloff wrote: On 03/14/2011 10:07 AM, Gordon Sim wrote: Its the iterator that is the issue, not the smart pointer that it points to. You test (it == bindingCache.end()) outside the lock and that is not safe. FYI -- .end() function is independent of the validity

[jira] Updated: (QPID-3143) session.createQueue is neither spec compliant nor backwards compatible

2011-03-14 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3143: --- Attachment: QPID-3143.patch The attached patch just removes the line which sets create to

[jira] Updated: (QPID-3143) session.createQueue is neither spec compliant nor backwards compatible

2011-03-14 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3143: --- Attachment: QPID-3143.test.patch Modified the existing test case to test the both default

Request to include QPID-3143 in the 0.10 release

2011-03-14 Thread Rajith Attapattu
The attached patch in QPID-3143 contains a simple one line fix and a modified test case to test the change. The same is committed to trunk at rev 1081460. The fix is low risk IMHO. However the fix is important as it makes the session.createQueue method spec complaint. It also allows the default

Re: ExchangeTest failing on trunk

2011-03-14 Thread Carl Trieloff
On 03/12/2011 12:18 PM, Alan Conway wrote: This test (one of the C++ unit tests) is failing on trunk: ../../../qpid/cpp/src/tests/ExchangeTest.cpp(282): error in testIVEOption: check 1u == queue3-getMessageCount() failed [1 != 0] Failure appears to be introduced by r1080411: Author: Carl C.

Re: 0-10 JIRAs

2011-03-14 Thread Alan Conway
On 03/14/2011 10:09 AM, Justin Ross wrote: Using 0.9 and 0.10 as an example: 0.9 is simply another name for 0.10-dev. Qpid developers know this, so they can resolve a 0.9 bug to the 0.10 release just as easily as they can resolve a 0.10-dev bug to the 0.10 release. And of course, all release

Re: svn commit: r1080411 - in /qpid/trunk/qpid/cpp/src/qpid/broker: TopicExchange.cpp TopicExchange.h

2011-03-14 Thread Alan Conway
On 03/14/2011 10:41 AM, Andrew Stitcher wrote: On Mon, 2011-03-14 at 10:12 -0400, Carl Trieloff wrote: On 03/14/2011 10:07 AM, Gordon Sim wrote: Its the iterator that is the issue, not the smart pointer that it points to. You test (it == bindingCache.end()) outside the lock and that is not

Re: svn commit: r1080411 - in /qpid/trunk/qpid/cpp/src/qpid/broker: TopicExchange.cpp TopicExchange.h

2011-03-14 Thread Carl Trieloff
On 03/14/2011 01:12 PM, Alan Conway wrote: In general end() is not thread safe or constant. If you are using plain pointers as iterators over a C array, then end() is a pointer to one place after the last element of the array and changes if the array size changes. Probably many std

Re: 0-10 JIRAs

2011-03-14 Thread Andrew Stitcher
On Mon, 2011-03-14 at 13:01 -0400, Alan Conway wrote: On 03/14/2011 10:09 AM, Justin Ross wrote: Using 0.9 and 0.10 as an example: 0.9 is simply another name for 0.10-dev. Qpid developers know this, so they can resolve a 0.9 bug to the 0.10 release just as easily as they can resolve

[jira] Commented: (QPID-1811) Unable to compile qpid on FreeBSD

2011-03-14 Thread Steve Huston (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006557#comment-13006557 ] Steve Huston commented on QPID-1811: The supplied patches (or similar) were applied,

[jira] Created: (QPID-3144) qpidd --check does not work with info logging and --log-to-stdout=yes

2011-03-14 Thread Alan Conway (JIRA)
qpidd --check does not work with info logging and --log-to-stdout=yes - Key: QPID-3144 URL: https://issues.apache.org/jira/browse/QPID-3144 Project: Qpid Issue Type: Bug

Request for inclusion in 0.10: QPID-3144

2011-03-14 Thread Alan Conway
https://issues.apache.org/jira/browse/QPID-3144 This is a trivial, risk-free 1 liner. Not urgent but nice to clean it up. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact:

[jira] Commented: (QPID-3144) qpidd --check does not work with info logging and --log-to-stdout=yes

2011-03-14 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006622#comment-13006622 ] Alan Conway commented on QPID-3144: --- Comitted to trunk r1081548, awaiting permission to

[jira] Updated: (QPID-3145) messaging::Message API needs to be documented, little to no Doxygen comments

2011-03-14 Thread David Hickerson (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Hickerson updated QPID-3145: -- Description: The documentation of everything in this class is represented by about 100 words,