[jira] [Commented] (QPID-3602) Fix Consumer message credit issues in 0-10 codepath

[ https://issues.apache.org/jira/browse/QPID-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152626#comment-13152626 ] jirapos...@reviews.apache.org commented on QPID-3602: - bq. On 2011-1

Re: Review Request: Sending of completions should be independent of sending message acks

> On 2011-11-17 22:50:45, Robbie Gemmell wrote: > > Also forgot to mention earlier, I think that you will need to consider > > clearing the contents of your completions list during failover. When Keith > > and I made the changes we did, we had to update the patch to ensure that it > > didnt tr

[jira] [Commented] (QPID-3602) Fix Consumer message credit issues in 0-10 codepath

[ https://issues.apache.org/jira/browse/QPID-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152427#comment-13152427 ] jirapos...@reviews.apache.org commented on QPID-3602: - bq. On 2011-1

Re: Review Request: Sending of completions should be independent of sending message acks

> On 2011-11-17 21:22:31, Robbie Gemmell wrote: > > In addition to the code-specific items already noted, I thought id mention > > that it would be good if this change pulled in the rollback/recover related > > completion issue Keith and I patched today. As I mentioned on the phone > > earlier

[jira] [Commented] (QPID-3602) Fix Consumer message credit issues in 0-10 codepath

[ https://issues.apache.org/jira/browse/QPID-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152417#comment-13152417 ] jirapos...@reviews.apache.org commented on QPID-3602: - ---

Re: Review Request: Sending of completions should be independent of sending message acks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2853/#review3330 --- Also forgot to mention earlier, I think that you will need to consider

[jira] [Commented] (QPID-3602) Fix Consumer message credit issues in 0-10 codepath

[ https://issues.apache.org/jira/browse/QPID-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152415#comment-13152415 ] jirapos...@reviews.apache.org commented on QPID-3602: - bq. On 2011-1

Re: Review Request: Sending of completions should be independent of sending message acks

> On 2011-11-17 21:22:31, Robbie Gemmell wrote: > > In addition to the code-specific items already noted, I thought id mention > > that it would be good if this change pulled in the rollback/recover related > > completion issue Keith and I patched today. As I mentioned on the phone > > earlier

[jira] [Commented] (QPID-3602) Fix Consumer message credit issues in 0-10 codepath

[ https://issues.apache.org/jira/browse/QPID-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152408#comment-13152408 ] jirapos...@reviews.apache.org commented on QPID-3602: - bq. On 2011-1

Re: Review Request: Sending of completions should be independent of sending message acks

> On 2011-11-17 21:22:31, Robbie Gemmell wrote: > > In addition to the code-specific items already noted, I thought id mention > > that it would be good if this change pulled in the rollback/recover related > > completion issue Keith and I patched today. As I mentioned on the phone > > earlier

Re: 0.14 release update - RC1 this week

I have merged the requests Keith and I raised. I also fixed a bunch of files with missing licence headers, mostly in the Java tree (which seemed the least I could do since half of them were my fault :S). The resulting RAT output for the 0.14 branch can be seen at the URL below. One file I didnt to

[jira] [Commented] (QPID-3604) If the connection is stopped the client should release all it's messages in the prefetch buffer

[ https://issues.apache.org/jira/browse/QPID-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152384#comment-13152384 ] jirapos...@reviews.apache.org commented on QPID-3604: - bq. On 2011-1

[jira] [Commented] (QPID-3604) If the connection is stopped the client should release all it's messages in the prefetch buffer

[ https://issues.apache.org/jira/browse/QPID-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152385#comment-13152385 ] jirapos...@reviews.apache.org commented on QPID-3604: - bq. On 2011-1

Re: Review Request: QPID-3604 - If connection is started and stopped, the client may get more messages than required by the prefetch value

> On 2011-11-15 16:41:28, Gordon Sim wrote: > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java, > > line 126 > > > > > > What case(s) is th

Re: Review Request: QPID-3604 - If connection is started and stopped, the client may get more messages than required by the prefetch value

> On 2011-11-16 09:38:21, Keith Wall wrote: > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java, > > line 128 > > > > > > Could this make us

[jira] [Commented] (QPID-3562) the 0-10 client path does not act as expected with asynchronous consumers using a prefetch of 1 on transacted sessions

[ https://issues.apache.org/jira/browse/QPID-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152382#comment-13152382 ] Rajith Attapattu commented on QPID-3562: Thanks for the feedback. I was trying to g

Re: Request to include QPID-3626 in 0.14

Rajith +1 -K - Original Message - > On Thu, Nov 17, 2011 at 12:03 PM, Gordon Sim wrote: > > On 11/17/2011 04:57 PM, Ken Giusti wrote: > >> > >> Hi Justin, > >> > >> Would it be possible to include the fix for QPID-3626 in the > >> upcoming rc? > >> > >> https://issues.apache.org/jira/brow

[jira] [Commented] (QPID-3579) Tool to aid in analyzing trace messages in c++ broker log files

[ https://issues.apache.org/jira/browse/QPID-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152367#comment-13152367 ] Kim van der Riet commented on QPID-3579: Moved on 0.14 branch to cpp/src/tests in r

[jira] [Commented] (QPID-3562) the 0-10 client path does not act as expected with asynchronous consumers using a prefetch of 1 on transacted sessions

[ https://issues.apache.org/jira/browse/QPID-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152359#comment-13152359 ] Robbie Gemmell commented on QPID-3562: -- I would probably have chosen to test prefetch=

[jira] [Commented] (QPID-3602) Fix Consumer message credit issues in 0-10 codepath

[ https://issues.apache.org/jira/browse/QPID-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152336#comment-13152336 ] jirapos...@reviews.apache.org commented on QPID-3602: - ---

Re: Review Request: Sending of completions should be independent of sending message acks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2853/#review3325 --- In addition to the code-specific items already noted, I thought id men

[jira] [Commented] (QPID-3579) Tool to aid in analyzing trace messages in c++ broker log files

[ https://issues.apache.org/jira/browse/QPID-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152332#comment-13152332 ] Justin Ross commented on QPID-3579: --- Regarding "include along side the c++ brokers test t

Re: Request to include QPID-3626 in 0.14

On Thu, Nov 17, 2011 at 12:03 PM, Gordon Sim wrote: > On 11/17/2011 04:57 PM, Ken Giusti wrote: >> >> Hi Justin, >> >> Would it be possible to include the fix for QPID-3626 in the upcoming rc? >> >> https://issues.apache.org/jira/browse/QPID-3626 >> >> Without it, any python client that would like

[jira] [Issue Comment Edited] (QPID-3579) Tool to aid in analyzing trace messages in c++ broker log files

[ https://issues.apache.org/jira/browse/QPID-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152322#comment-13152322 ] Gordon Sim edited comment on QPID-3579 at 11/17/11 8:59 PM: And

[jira] [Commented] (QPID-3579) Tool to aid in analyzing trace messages in c++ broker log files

[ https://issues.apache.org/jira/browse/QPID-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152321#comment-13152321 ] Gordon Sim commented on QPID-3579: -- I like the script. My only concern is with shipping it

[jira] [Commented] (QPID-3579) Tool to aid in analyzing trace messages in c++ broker log files

[ https://issues.apache.org/jira/browse/QPID-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152322#comment-13152322 ] Gordon Sim commented on QPID-3579: -- And just as a point of process, I think adding a new u

Re: credit window sizing behaviour

On 17 November 2011 16:03, Gordon Sim wrote: > On 11/17/2011 02:52 PM, Robbie Gemmell wrote: >> >> Keith and I noticed some behavioural difference between the Java and >> C++ broker with regards to credit window sizing, whilst investigating >> QPID-2703. As per QPID-3629, it appears that the C++ b

[jira] [Assigned] (QPID-3629) CPP Broker allows credit window to exceed the request size.

[ https://issues.apache.org/jira/browse/QPID-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim reassigned QPID-3629: Assignee: Gordon Sim > CPP Broker allows credit window to exceed the request size. > ---

[jira] [Commented] (QPID-3579) Tool to aid in analyzing trace messages in c++ broker log files

[ https://issues.apache.org/jira/browse/QPID-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152216#comment-13152216 ] Justin Ross commented on QPID-3579: --- Kim asked me in person to consider this for 0.14. I

[jira] [Updated] (QPID-3617) AMQQueueMBean.viewMessages: Viewing message without priority set ends with NullPointerException

[ https://issues.apache.org/jira/browse/QPID-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-3617: - Affects Version/s: (was: 0.15) (was: 0.14) > AMQQueueMBean.view

[jira] [Updated] (QPID-2703) Transaction Rollback/Recover does not restore consumer credit

[ https://issues.apache.org/jira/browse/QPID-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-2703: - Affects Version/s: (was: 0.15) Fix Version/s: (was: 0.15) 0.

[jira] [Updated] (QPID-2703) Transaction Rollback/Recover does not restore consumer credit

[ https://issues.apache.org/jira/browse/QPID-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-2703: - Affects Version/s: (was: 0.14) > Transaction Rollback/Recover does not restore consumer cr

[jira] [Updated] (QPID-3622) Add Sorted Queue

[ https://issues.apache.org/jira/browse/QPID-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-3622: - Comment: was deleted (was: Wrong patch is attached) > Add Sorted Queue > > >

[jira] [Assigned] (QPID-3622) Add Sorted Queue

[ https://issues.apache.org/jira/browse/QPID-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-3622: Assignee: Keith Wall (was: Alex Rudyy) > Add Sorted Queue > > >

[jira] [Updated] (QPID-3622) Add Sorted Queue

[ https://issues.apache.org/jira/browse/QPID-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-3622: - Attachment: (was: 0001-QPID-3622-Add-Sorted-Queue-funtionality.patch) > Add Sorted Queue > ---

[jira] [Updated] (QPID-3622) Add Sorted Queue

[ https://issues.apache.org/jira/browse/QPID-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-3622: - Attachment: 0001-QPID-3622-Add-Sorted-Queue-funtionality.patch > Add Sorted Queue > >

[jira] [Updated] (QPID-3622) Add Sorted Queue

[ https://issues.apache.org/jira/browse/QPID-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-3622: - Status: Ready To Review (was: In Progress) > Add Sorted Queue > > >

Re: Problem Deploying JCA Test Programs

Hi Dan, Good question. All message types are supported by the adapter so you have should no issues regardless of which one(s) you want to use. Regards, Weston On Nov 17, 2011, at 1:32 PM, Dan Carda wrote: > > Hey Weston, > I'll keep my eyes peeled for the next release. However, I'm s

[jira] [Updated] (QPID-3617) AMQQueueMBean.viewMessages: Viewing message without priority set ends with NullPointerException

[ https://issues.apache.org/jira/browse/QPID-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-3617: - Fix Version/s: (was: 0.15) 0.14 Merged to 0.14 release branch.

Re: Problem Deploying JCA Test Programs

Hey Weston, I'll keep my eyes peeled for the next release. However, I'm sure the release I have is going to be more than adequate. Last question: Of the five MDB message types (Stream, Map, Text, Object, and Bytes) which are supported by the connector? Obviously, Text is, but is there any suppo

[jira] [Resolved] (QPID-3626) Provide access to the AMQP 0.10 timestamp delivery property for the python client

[ https://issues.apache.org/jira/browse/QPID-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved QPID-3626. -- Resolution: Fixed > Provide access to the AMQP 0.10 timestamp delivery property for the python > cl

[jira] [Updated] (QPID-3622) Add Sorted Queue

[ https://issues.apache.org/jira/browse/QPID-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-3622: - Assignee: Alex Rudyy (was: Keith Wall) Status: Open (was: Ready To Review) Wrong patch is attached

[jira] [Commented] (QPID-3617) AMQQueueMBean.viewMessages: Viewing message without priority set ends with NullPointerException

[ https://issues.apache.org/jira/browse/QPID-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152183#comment-13152183 ] Justin Ross commented on QPID-3617: --- Reviewed by Robbie. Approved for 0.14.

[jira] [Resolved] (QPID-3617) AMQQueueMBean.viewMessages: Viewing message without priority set ends with NullPointerException

[ https://issues.apache.org/jira/browse/QPID-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-3617. -- Resolution: Fixed Fix Version/s: 0.15 Assignee: Robbie Gemmell Fixed. Looks good

Re: Requests for inclusion in 0.14

Done. I was sitting beside Keith looking at the screen when the change was made, we just forgot to close the JIRA :) Robbie On 17 November 2011 18:07, Justin Ross wrote: > Hi, Keith.  I've approved 2703.  I'm currently hunting for a reviewer for > 3617.  If anyone has a moment to look, please vo

Re: 0.14 release update - RC1 this week

A number of new inclusion requests have come in today, and I'd like our first release candidate to have a real chance at being final. I'm going to postpone creating the RC1 distribution to tomorrow so all the approved changes can land. Thanks, Justin On Tue, 15 Nov 2011, Justin Ross wrote:

[jira] [Assigned] (QPID-3622) Add Sorted Queue

[ https://issues.apache.org/jira/browse/QPID-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-3622: Assignee: Alex Rudyy (was: Keith Wall) > Add Sorted Queue > > >

[jira] [Updated] (QPID-3626) Provide access to the AMQP 0.10 timestamp delivery property for the python client

[ https://issues.apache.org/jira/browse/QPID-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated QPID-3626: -- Fix Version/s: (was: Future) 0.14 > Provide access to the AMQP 0.10 timestamp

[jira] [Assigned] (QPID-3622) Add Sorted Queue

[ https://issues.apache.org/jira/browse/QPID-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-3622: Assignee: Keith Wall (was: Alex Rudyy) > Add Sorted Queue > > >

[jira] [Updated] (QPID-3622) Add Sorted Queue

[ https://issues.apache.org/jira/browse/QPID-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-3622: - Status: Ready To Review (was: In Progress) > Add Sorted Queue > > >

[jira] [Commented] (QPID-3626) Provide access to the AMQP 0.10 timestamp delivery property for the python client

[ https://issues.apache.org/jira/browse/QPID-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152177#comment-13152177 ] Justin Ross commented on QPID-3626: --- Reviewed by Rafi; approved for 0.14.

[jira] [Updated] (QPID-3622) Add Sorted Queue

[ https://issues.apache.org/jira/browse/QPID-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-3622: - Attachment: 0001-QPID-3622-Add-Sorted-Queue-funtionality.patch Attached patch with a sorted queue implemen

[jira] [Assigned] (QPID-3622) Add Sorted Queue

[ https://issues.apache.org/jira/browse/QPID-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-3622: Assignee: Keith Wall Keith, Could you please review and commit the patch? > Add Sor

Re: Requests for inclusion in 0.14

Hi, Keith. I've approved 2703. I'm currently hunting for a reviewer for 3617. If anyone has a moment to look, please voice your approval in a jira comment, and I'll approve it for 0.14. The change appears to be trivial. Justin On Thu, 17 Nov 2011, Keith W wrote: Hello Justin Can the fo

[jira] [Commented] (QPID-3626) Provide access to the AMQP 0.10 timestamp delivery property for the python client

[ https://issues.apache.org/jira/browse/QPID-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152168#comment-13152168 ] Rafael H. Schloming commented on QPID-3626: --- looks good > Provid

Re: Requests for inclusion in 0.14

Yes, certainly. On Thu, 17 Nov 2011, Robbie Gemmell wrote: Could we also put this SSL cert update into 0.14? http://svn.apache.org/viewvc?rev=1203235&view=rev Robbie On 17 November 2011 12:47, Keith W wrote: Hello Justin Can the following JIRAs be considered for inclusion in 0.14 please?

[jira] [Commented] (QPID-2703) Transaction Rollback/Recover does not restore consumer credit

[ https://issues.apache.org/jira/browse/QPID-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152161#comment-13152161 ] Justin Ross commented on QPID-2703: --- Reviewed by Rajith. Approved for 0.14.

Re: Problem Deploying JCA Test Programs

Hi Dan, Glad to hear your up and running! Currently the code you have was used in putting the adapter and the examples together prior to going upstream for review and eventual inclusion. We are planning on having the latest code upstream in short order, but the timing is not qu

Re: Problem Deploying JCA Test Programs

Thank you Weston, I got it deploying and the run-client tests are running fine. Question: You said I have an older version? Where do I get the most recent version from? BTW, good job on this entire module. You guys did a great job. Daniel Weston M. Price wrote: > > Hi Dan, > I

[jira] [Created] (QPID-3631) The "Programming in Apache Qpid" book does not cover all Java Connection URL options

The "Programming in Apache Qpid" book does not cover all Java Connection URL options Key: QPID-3631 URL: https://issues.apache.org/jira/browse/QPID-3631 Project: Qpi

Re: Request to include QPID-3626 in 0.14

On 11/17/2011 04:57 PM, Ken Giusti wrote: Hi Justin, Would it be possible to include the fix for QPID-3626 in the upcoming rc? https://issues.apache.org/jira/browse/QPID-3626 Without it, any python client that would like to access the timestamp would have to revert to using the old client API

Request to include QPID-3626 in 0.14

Hi Justin, Would it be possible to include the fix for QPID-3626 in the upcoming rc? https://issues.apache.org/jira/browse/QPID-3626 Without it, any python client that would like to access the timestamp would have to revert to using the old client API, something we don't want to encourage goin

Re: credit window sizing behaviour

On 11/17/2011 02:52 PM, Robbie Gemmell wrote: Keith and I noticed some behavioural difference between the Java and C++ broker with regards to credit window sizing, whilst investigating QPID-2703. As per QPID-3629, it appears that the C++ broker will effectively allow clients to expand the credit

[jira] [Commented] (QPID-2703) Transaction Rollback/Recover does not restore consumer credit

[ https://issues.apache.org/jira/browse/QPID-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152129#comment-13152129 ] Rajith Attapattu commented on QPID-2703: I think this is a good short term fix for

Re: Problem Deploying JCA Test Programs

Hi Dan, I see, this is an older version of the adapter. The adapter hasn't officially been released upstream yet, but the examples you have should work just fine. Quick check of the code you have, the property in build.xml is actually called: simply modify this to be and then ant

Re: Requests for inclusion in 0.14

Could we also put this SSL cert update into 0.14? http://svn.apache.org/viewvc?rev=1203235&view=rev Robbie On 17 November 2011 12:47, Keith W wrote: > Hello Justin > > Can the following JIRAs be considered for inclusion in 0.14 please? > > QPID-3617 - AMQQueueMBean.viewMessages: Viewing message

Re: Problem Deploying JCA Test Programs

Hey Weston, Wow, thanks for the fast response. I acquired the adapter from here: https://github.com/astitcher/qpid-jca Looks like this is the 0.10 version. Is there a more current version? I will look into that target container variable right now. THANKS!!! Weston M. Price wrote: >

Re: Problem Deploying JCA Test Programs

Hi Dan, It looks like from your syntax for your destination your using the Geronimo version of the examples: > jca:/qpid.jca/QpidJCAAdapter/JCAAdminObject/HelloQueue In your build.xml file you should see a property target.host By default this is set to Geronimo, you simply need to cha

Problem Deploying JCA Test Programs

Hi! Got a problem with the JCA adapter. I'm basically building and deploy the stock code. The only exception is I went though and changed all the amqp references to reflect our local bus. I move the qpid-ra-0.10.rar to our JBoss 6.1's ./server/all/deploy directory and all is well. Using the

[jira] [Created] (QPID-3630) Remove the "max-session-rate" feature in the C++ Broker.

Remove the "max-session-rate" feature in the C++ Broker. Key: QPID-3630 URL: https://issues.apache.org/jira/browse/QPID-3630 Project: Qpid Issue Type: Bug Components: C++ Bro

[jira] [Commented] (QPID-2703) Transaction Rollback/Recover does not restore consumer credit

[ https://issues.apache.org/jira/browse/QPID-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152096#comment-13152096 ] Rajith Attapattu commented on QPID-2703: Part of the reason is in the java client c

Re: Requests for inclusion in 0.14

On 11/17/2011 03:01 PM, Robbie Gemmell wrote: On 17 November 2011 14:37, Gordon Sim wrote: On 11/17/2011 12:47 PM, Keith W wrote: QPID-2703 - Transaction rollback/recover does not restore consumer credit. There are two separate aspects to this change. A Broker side bug affecting 0-8..0-9-1

Re: Requests for inclusion in 0.14

On 17 November 2011 14:37, Gordon Sim wrote: > On 11/17/2011 12:47 PM, Keith W wrote: >> >> QPID-2703 - Transaction rollback/recover does not restore consumer credit. >> >> There are two separate aspects to this change.  A Broker side bug >> affecting 0-8..0-9-1 and a client side issue affecting 0

credit window sizing behaviour

Hi all, Keith and I noticed some behavioural difference between the Java and C++ broker with regards to credit window sizing, whilst investigating QPID-2703. As per QPID-3629, it appears that the C++ broker will effectively allow clients to expand the credit window beyond the limits specified by t

Re: Question re: Java broker's message selector implementation...

On 17 November 2011 15:28, Ken Giusti wrote: > Hi Rob, thanks for the info - very helpful. I'll write up a more formal > description of the proposed functionality shortly - give us something a > little more tangible to review. > > One question specific to the Java broker's behavior - an edge-cas

Re: Requests for inclusion in 0.14

On 11/17/2011 12:47 PM, Keith W wrote: QPID-2703 - Transaction rollback/recover does not restore consumer credit. There are two separate aspects to this change. A Broker side bug affecting 0-8..0-9-1 and a client side issue affecting 0-10. In the former case the Broker needs to restore credit

Re: Question re: Java broker's message selector implementation...

Hi Rob, thanks for the info - very helpful. I'll write up a more formal description of the proposed functionality shortly - give us something a little more tangible to review. One question specific to the Java broker's behavior - an edge-case I'm trying to wrap my head around: With selectors,

Re: Review Request: QPID-3604 - If connection is started and stopped, the client may get more messages than required by the prefetch value

> > > > On 2011-11-16 09:38:21, Keith Wall wrote: > > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java, > > > line 128 > > > > > > > > > Cou

Requests for inclusion in 0.14

Hello Justin Can the following JIRAs be considered for inclusion in 0.14 please? QPID-3617 - AMQQueueMBean.viewMessages: Viewing message without priority set ends with NullPointerException This is a very minor changes that would affect users of the Python client with the Java Broker. It prevents

[jira] [Updated] (QPID-3629) CPP Broker allows credit window to exceed the request size.

[ https://issues.apache.org/jira/browse/QPID-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-3629: - Attachment: 0001-QPID-3629-demonstrate-credit-window-issue-using-pyth.patch > CPP Broker allows credit

[jira] [Created] (QPID-3629) CPP Broker allows credit window to exceed the request size.

CPP Broker allows credit window to exceed the request size. --- Key: QPID-3629 URL: https://issues.apache.org/jira/browse/QPID-3629 Project: Qpid Issue Type: Bug Components: C

[jira] [Resolved] (QPID-2703) Transaction Rollback/Recover does not restore consumer credit

[ https://issues.apache.org/jira/browse/QPID-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved QPID-2703. -- Resolution: Fixed Fix Version/s: 0.15 > Transaction Rollback/Recover does not restore consume

[jira] [Commented] (QPID-3604) If the connection is stopped the client should release all it's messages in the prefetch buffer

[ https://issues.apache.org/jira/browse/QPID-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151974#comment-13151974 ] jirapos...@reviews.apache.org commented on QPID-3604: - bq. On 2011-1

Re: Review Request: QPID-3604 - If connection is started and stopped, the client may get more messages than required by the prefetch value

> On 2011-11-16 09:38:21, Keith Wall wrote: > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java, > > line 128 > > > > > > Could this make us

[jira] [Updated] (QPID-2703) Transaction Rollback/Recover does not restore consumer credit

[ https://issues.apache.org/jira/browse/QPID-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-2703: - Description: When a transaction rollback/recover occurs on the 0-8/0-9/0-91 code path the messages are pu

[jira] [Commented] (QPID-3604) If the connection is stopped the client should release all it's messages in the prefetch buffer

[ https://issues.apache.org/jira/browse/QPID-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151958#comment-13151958 ] jirapos...@reviews.apache.org commented on QPID-3604: - bq. On 2011-1

Re: Review Request: QPID-3604 - If connection is started and stopped, the client may get more messages than required by the prefetch value

> On 2011-11-15 16:41:28, Gordon Sim wrote: > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java, > > line 126 > > > > > > What case(s) is th

[jira] [Updated] (QPID-2703) Transaction Rollback/Recover does not restore consumer credit

[ https://issues.apache.org/jira/browse/QPID-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-2703: - Description: When a transaction rollback/recover occurs on the 0-8/0-9/0-91 code path the messages

[jira] [Assigned] (QPID-2703) Transaction Rollback does not restore consumer credit - TRUNK MERGE

[ https://issues.apache.org/jira/browse/QPID-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned QPID-2703: Assignee: Keith Wall (was: Martin Ritchie) > Transaction Rollback does not restore consumer cre