Review Request: Fix for QPID-3575

2012-07-05 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5794/ --- Review request for qpid, Robbie Gemmell, Keith Wall, and Rob Godfrey. Descriptio

[jira] [Closed] (QPID-4108) HA does not replicate user - missing user property in management-schema

2012-07-05 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway closed QPID-4108. - Resolution: Invalid The bug as stated does not make sense. Will open a new bug for HA with authentication

Re: [Proton] ERROR amqp:connection:framing-error connection aborted

2012-07-05 Thread Rafael Schloming
According to the log output you posted, the body of the loop is never running. Can you log the value that pn_connection_state is returning and verify that the test is working as expected? I don't recall offhand how exactly bitwise operators work in Ruby. --Rafael On Thu, 2012-07-05 at 16:20 -0400

[jira] [Resolved] (QPID-4101) Fixes building the Ruby language bindings for Ruby 1.9

2012-07-05 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved QPID-4101. --- Resolution: Fixed Fix Version/s: 0.17 Fixed in r1357945 > Fixes buildi

[jira] [Updated] (QPID-4101) Fixes building the Ruby language bindings for Ruby 1.9

2012-07-05 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce updated QPID-4101: --- Attachment: 0001-Fixes-the-Cmake-build-process-for-the-Ruby-language-.patch > Fixes buildi

[jira] [Updated] (QPID-4101) Fixes building the Ruby language bindings for Ruby 1.9

2012-07-05 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce updated QPID-4101: --- Attachment: (was: 0001-Fixes-the-Cmake-build-process-for-the-Ruby-language-.patch) >

[jira] [Assigned] (QPID-4101) Fixes building the Ruby language bindings for Ruby 1.9

2012-07-05 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher reassigned QPID-4101: - Assignee: Andrew Stitcher > Fixes building the Ruby language bindings for Ruby 1.9 > -

[jira] [Resolved] (QPID-2567) [c++] Timer - possible thread lock ordering violation

2012-07-05 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/QPID-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved QPID-2567. --- Resolution: Fixed Fix Version/s: 0.17 Probably fixed by r1357827 > [c+

[jira] [Commented] (QPID-2567) [c++] Timer - possible thread lock ordering violation

2012-07-05 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/QPID-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407470#comment-13407470 ] Andrew Stitcher commented on QPID-2567: --- I think it is very likely this bug is fixed

Re: [Proton] ERROR amqp:connection:framing-error connection aborted

2012-07-05 Thread Darryl L. Pierce
On Tue, Jul 03, 2012 at 05:13:17PM -0400, Rafael Schloming wrote: > Can you post the ruby code you're using? I took a look at the original > python example you're transcoding and based on the trace it's likely > something is messed up around this part: > > # we're done, close and wait for the

[jira] [Resolved] (QPID-4085) HA fails long running failover test

2012-07-05 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved QPID-4085. --- Resolution: Fixed Fixed by the following commits: Committed r1357846 Committed r1357848 Committed r135

[jira] [Created] (QPID-4111) 0.18 release tasks

2012-07-05 Thread Justin Ross (JIRA)
Justin Ross created QPID-4111: - Summary: 0.18 release tasks Key: QPID-4111 URL: https://issues.apache.org/jira/browse/QPID-4111 Project: Qpid Issue Type: Task Components: Packaging

Re: Review Request: Add log entries for correlatable broker object life cycles

2012-07-05 Thread Gordon Sim
> On July 3, 2012, 11:04 a.m., Gordon Sim wrote: > > trunk/qpid/cpp/src/qpid/broker/Exchange.cpp, line 381 > > > > > > I notice we are not recording connection id here... > > Chug Rolke wrote: > This is the constru

Re: Review Request: Add log entries for correlatable broker object life cycles

2012-07-05 Thread Chug Rolke
> On July 3, 2012, 3:35 p.m., Alan Conway wrote: > > trunk/qpid/cpp/src/qpid/acl/Acl.cpp, line 296 > > > > > > Performance problem: mapEncodeValues is called even if the log > > statememnt is disabled. > > > >

Re: Review Request: Add log entries for correlatable broker object life cycles

2012-07-05 Thread Chug Rolke
> On July 3, 2012, 11:04 a.m., Gordon Sim wrote: > > trunk/qpid/cpp/src/qpid/broker/Exchange.cpp, line 251 > > > > > > Why does the name need to be passed in here? The management object was > > given the name when it w

[jira] [Updated] (QPID-3999) [Java Broker] Implement Web based management tool for the Java Broker

2012-07-05 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-3999: - Attachment: 0001-QPID-3999-System-tests-for-Rest-API.patch Attached patch with system tests for REST API

[jira] [Updated] (QPID-3575) session exceptions do not properly close connections, causing connections leak

2012-07-05 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3575: --- Fix Version/s: 0.17 > session exceptions do not properly close connections, causing connec

[jira] [Commented] (QPID-3977) Add charting framework for new distributed tests framwork

2012-07-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407214#comment-13407214 ] Keith Wall commented on QPID-3977: -- Patches applied. > Add charting frame

[jira] [Resolved] (QPID-4110) [Java Performance Tests] Add topic support to distributed test framework

2012-07-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved QPID-4110. -- Resolution: Fixed Fix Version/s: (was: Future) 0.17 Reviewed, no comments.

[jira] [Updated] (QPID-4110) [Java Performance Tests] Add topic support to distributed test framework

2012-07-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-4110: - Status: Ready To Review (was: In Progress) > [Java Performance Tests] Add topic support to distribute

Re: Review Request: Add log entries for correlatable broker object life cycles

2012-07-05 Thread Gordon Sim
> On July 3, 2012, 11:04 a.m., Gordon Sim wrote: > > trunk/qpid/cpp/include/qpid/SessionId.h, line 45 > > > > > > I think adding this here is wrong. A session id does not logically > > include the connection id. See sug

[jira] [Updated] (QPID-3977) Add charting framework for new distributed tests framwork

2012-07-05 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey updated QPID-3977: Attachment: 0001-QPID-3977-fixed-in-previous-patch-where-we-tried-to-.patch attached patch to fix pr

Re: Review Request: Add log entries for correlatable broker object life cycles

2012-07-05 Thread Chug Rolke
> On July 3, 2012, 11:04 a.m., Gordon Sim wrote: > > trunk/qpid/cpp/include/qpid/SessionId.h, line 45 > > > > > > I think adding this here is wrong. A session id does not logically > > include the connection id. See sug

[jira] [Comment Edited] (QPID-4109) Reenable LoggingManagement MBean

2012-07-05 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407159#comment-13407159 ] Alex Rudyy edited comment on QPID-4109 at 7/5/12 2:25 PM: -- Hi Keit

[jira] [Commented] (QPID-4109) Reenable LoggingManagement MBean

2012-07-05 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407159#comment-13407159 ] Alex Rudyy commented on QPID-4109: -- Hi Keith, I reviewed your code. The changes looks goo

[jira] [Commented] (QPID-4108) HA does not replicate user - missing user property in management-schema

2012-07-05 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407076#comment-13407076 ] Alan Conway commented on QPID-4108: --- Perhaps the user shouldn't be replicated. Instead HA

[jira] [Updated] (QPID-4103) [Java Performance Tests] Allow specifying of test configuration with Javascript

2012-07-05 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey updated QPID-4103: Summary: [Java Performance Tests] Allow specifying of test configuration with Javascript (was: [Jav

[jira] [Updated] (QPID-3977) Add charting framework for new distributed tests framwork

2012-07-05 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey updated QPID-3977: Attachment: 0002-QPID-3977-tidy-up-chart-generation.-Specifically.patch attached patch to tidy up so

[jira] [Assigned] (QPID-4110) [Java Performance Tests] Add topic support to distributed test framework

2012-07-05 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey reassigned QPID-4110: --- Assignee: Keith Wall (was: Philip Harvey) Keith - please can you review and commit if you're

[jira] [Updated] (QPID-4110) [Java Performance Tests] Add topic support to distributed test framework

2012-07-05 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey updated QPID-4110: Attachment: 0005-QPID-4110-added-topic-support-to-performance-tests.-.patch attached patch

[jira] [Created] (QPID-4110) [Java Performance Tests] Add topic support to distributed test framework

2012-07-05 Thread Philip Harvey (JIRA)
Philip Harvey created QPID-4110: --- Summary: [Java Performance Tests] Add topic support to distributed test framework Key: QPID-4110 URL: https://issues.apache.org/jira/browse/QPID-4110 Project: Qpid

[jira] [Assigned] (QPID-4109) Reenable LoggingManagement MBean

2012-07-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned QPID-4109: Assignee: Alex Rudyy (was: Keith Wall) > Reenable LoggingManagement MBean > ---

[jira] [Updated] (QPID-4109) Reenable LoggingManagement MBean

2012-07-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-4109: - Status: Ready To Review (was: In Progress) > Reenable LoggingManagement MBean > -

[jira] [Commented] (QPID-4109) Reenable LoggingManagement MBean

2012-07-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406939#comment-13406939 ] Keith Wall commented on QPID-4109: -- Patch applied. > Reenable LoggingMana

[jira] [Updated] (QPID-4093) [Java Broker] extract the JMX management functionality into its own module

2012-07-05 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-4093: - Component/s: Java Management : JMX Console > [Java Broker] extract the JMX management functionality in

[jira] [Created] (QPID-4109) Reenable LoggingManagement MBean

2012-07-05 Thread Keith Wall (JIRA)
Keith Wall created QPID-4109: Summary: Reenable LoggingManagement MBean Key: QPID-4109 URL: https://issues.apache.org/jira/browse/QPID-4109 Project: Qpid Issue Type: Task Components: Ja