[jira] [Commented] (QPID-4533) Java broker performance tests should support writing results to database

2013-01-30 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566318#comment-13566318 ] Philip Harvey commented on QPID-4533: - Thanks for reviewing this Keith. I've

[jira] [Updated] (QPID-4533) Java broker performance tests should support writing results to database

2013-01-30 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey updated QPID-4533: Status: Ready To Review (was: In Progress) Java broker performance tests should support

[jira] [Resolved] (QPID-4533) Java broker performance tests should support writing results to database

2013-01-30 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey resolved QPID-4533. - Resolution: Fixed Fix Version/s: 0.21 Already reviewed by Keith. Java

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/#review15837 --- Is abort() the right call to make? What about close()? It looks to

[jira] [Reopened] (QPID-4533) Java broker performance tests should support writing results to database

2013-01-30 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey reopened QPID-4533: - I now realise that one of the unit tests is timezone-specific. Java broker

[jira] [Assigned] (QPID-4552) C++ Messaging examples don't build

2013-01-30 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim reassigned QPID-4552: Assignee: Darryl L. Pierce C++ Messaging examples don't build

[jira] [Commented] (QPID-4552) C++ Messaging examples don't build

2013-01-30 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566452#comment-13566452 ] Gordon Sim commented on QPID-4552: -- I agree with Chuck,

[jira] [Updated] (QPID-4533) Java broker performance tests should support writing results to database

2013-01-30 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey updated QPID-4533: Status: Ready To Review (was: In Progress) Java broker performance tests should support

[jira] [Assigned] (QPID-4533) Java broker performance tests should support writing results to database

2013-01-30 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey reassigned QPID-4533: --- Assignee: Keith Wall (was: Philip Harvey) Fixed timezone bug. Please could you review?

[jira] [Resolved] (QPID-4471) Add docbook for producer transaction timeout feature of Java Broker.

2013-01-30 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey resolved QPID-4471. - Resolution: Fixed Looks good. Apologies for the delay reviewing this change.

[jira] [Resolved] (QPID-4552) C++ Messaging examples don't build

2013-01-30 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce resolved QPID-4552. Resolution: Fixed Fix Version/s: 0.21 C++ Messaging examples don't build

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Alan Conway
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Alan Conway
On Jan. 29, 2013, 9:59 p.m., Andrew Stitcher wrote: /trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp, line 99 https://reviews.apache.org/r/9137/diff/2/?file=253082#file253082line99 I don't think this should be protected by !readError as the read and write sides are independent.

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Gordon Sim
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: QPID tools: fix the incorrect use of 'ssl_keyfile' SSL configuration parameter

2013-01-30 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9139/#review15848 --- /trunk/qpid/tools/src/py/qpid-cluster

Re: Review Request: QPID tools: fix the incorrect use of 'ssl_keyfile' SSL configuration parameter

2013-01-30 Thread Kenneth Giusti
On Jan. 30, 2013, 2:55 p.m., Chug Rolke wrote: /trunk/qpid/tools/src/py/qpid-cluster, line 296 https://reviews.apache.org/r/9139/diff/1/?file=253002#file253002line296 This instance is missing the pattern 'if not opts.ssl_certificate:' Actually, the options checking for that

Re: Review Request: QPID tools: fix the incorrect use of 'ssl_keyfile' SSL configuration parameter

2013-01-30 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9139/#review15850 --- Ship it! Ship It! - Chug Rolke On Jan. 29, 2013, 9:32 p.m.,

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Andrew Stitcher
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Alan Conway
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/#review15855 --- Ship it! I'm happy to have this code change in trunk, even if

Re: svn commit: r1439431 - /qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp

2013-01-30 Thread Alan Conway
On Mon, 2013-01-28 at 17:51 +, Robbie Gemmell wrote: It wasnt just Windows. I had been meaning to send a mail today saying the Ubuntu builds on Jenkins were also failing since last week ..and also that the original commit didnt seem like a NO-JIRA. I didn't JIRA it because it was a

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Gordon Sim
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Qpid book build is broken

2013-01-30 Thread Alan Conway
On Mon, 2013-01-28 at 23:54 +, Robbie Gemmell wrote: The sections causing it to spit out those messages dont look to have changed in a very long time (e.g in cpp-broker/Qpid-Management-Framework.xml which is unchanged since Rob moved it about 9 months ago), meaning it has probably always

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Andrew Stitcher
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Gordon Sim
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Andrew Stitcher
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Gordon Sim
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Review Request: Remove read throttling from C++ IO code

2013-01-30 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9161/ --- Review request for qpid, Alan Conway, Gordon Sim, Kenneth Giusti, michael

Re: Review Request: Remove read throttling from C++ IO code

2013-01-30 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9161/#review15870 --- Ship it! Ship It! - Gordon Sim On Jan. 30, 2013, 5:09 p.m.,

[jira] [Resolved] (QPID-4554) QPID tools use of SSL parameter ssl_keyfile is incorrect.

2013-01-30 Thread Ken Giusti (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved QPID-4554. -- Resolution: Fixed http://svn.apache.org/viewvc?view=revisionrevision=1440543 QPID

Re: Review Request: Remove read throttling from C++ IO code

2013-01-30 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9161/#review15874 --- Ship it! Good cleanup, I overlooked the readcredit stuff when I was

[jira] [Commented] (QPID-3396) Specifying username/password in JMS clients should not be mandatory

2013-01-30 Thread Fraser Adams (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566742#comment-13566742 ] Fraser Adams commented on QPID-3396: Comment following a conversation with Pavel on the

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/ --- (Updated Jan. 30, 2013, 6:39 p.m.) Review request for qpid and Andrew Stitcher.

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/ --- (Updated Jan. 30, 2013, 6:40 p.m.) Review request for qpid and Andrew Stitcher.

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/ --- (Updated Jan. 30, 2013, 6:40 p.m.) Review request for qpid and Andrew Stitcher.

[jira] [Commented] (QPID-4514) Remove obsolete code related to active-active-cluster

2013-01-30 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566944#comment-13566944 ] Andrew Stitcher commented on QPID-4514: --- r1440616 QPID-4514: Remove IO readCredit

[jira] [Created] (QPID-4555) Bug 906060 - HA tests fail when run in a loop.

2013-01-30 Thread Alan Conway (JIRA)
Alan Conway created QPID-4555: - Summary: Bug 906060 - HA tests fail when run in a loop. Key: QPID-4555 URL: https://issues.apache.org/jira/browse/QPID-4555 Project: Qpid Issue Type: Bug

Review Request: Reconcile C99 and C++ inconsistencies within proton

2013-01-30 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9169/ --- Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and