[jira] [Commented] (QPID-4720) C++ Broker Headers exchange match comparison issue with value types

2013-04-12 Thread Chuck Rolke (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630052#comment-13630052 ] Chuck Rolke commented on QPID-4720: --- The correct behavior is to match values when they

[jira] [Commented] (QPID-4739) [Java Broker] complete functionality to configure multiple key store and trust stores and assign them per-port

2013-04-12 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630262#comment-13630262 ] Robbie Gemmell commented on QPID-4739: -- Change made on trunk at

Re: Review Request: Headers exchange binding match self tests do not use same logic as mission code

2013-04-12 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10436/#review19108 --- trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp

Re: Review Request: Headers exchange binding match self tests do not use same logic as mission code

2013-04-12 Thread Chug Rolke
On April 12, 2013, 9:21 p.m., Andrew Stitcher wrote: trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp, line 346 https://reviews.apache.org/r/10436/diff/1/?file=280864#file280864line346 I think there's more code you can remove - getMatch() and the stuff it uses transitively too.