[jira] [Commented] (QPID-4958) Java Performance Tests - race condition client registration detection causes tests to hang

2013-07-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696660#comment-13696660 ] ASF subversion and git services commented on QPID-4958: --- Commit 14983

Re: Review Request: provide means of configuring subscription queues for 'topics' over AMQP 1.0

2013-07-01 Thread Gordon Sim
On 06/29/2013 03:47 PM, Fraser Adams wrote: Some of this is making me a little nervous in particular the response around my headers Address String, but I might me misunderstanding e.g. "That would now be handled in two steps. The first is a configuration step whereby a 'topic' is created referen

[jira] [Resolved] (QPID-4958) Java Performance Tests - race condition client registration detection causes tests to hang

2013-07-01 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey resolved QPID-4958. - Resolution: Fixed Fix Version/s: 0.23 > Java Performance Tests - race condition client

[jira] [Created] (QPID-4970) [Java Broker] Configure MessageStores based on VirtualHost object not XML Configuration

2013-07-01 Thread Rob Godfrey (JIRA)
Rob Godfrey created QPID-4970: - Summary: [Java Broker] Configure MessageStores based on VirtualHost object not XML Configuration Key: QPID-4970 URL: https://issues.apache.org/jira/browse/QPID-4970 Project

[jira] [Commented] (QPID-4970) [Java Broker] Configure MessageStores based on VirtualHost object not XML Configuration

2013-07-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696681#comment-13696681 ] ASF subversion and git services commented on QPID-4970: --- Commit 14983

[jira] [Commented] (QPID-4969) C++ Broker headers exchange allows creation of bindings with duplicate keys

2013-07-01 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696748#comment-13696748 ] Gordon Sim commented on QPID-4969: -- This also breaks the unit tests, though in that case i

[jira] [Commented] (QPID-4969) C++ Broker headers exchange allows creation of bindings with duplicate keys

2013-07-01 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696750#comment-13696750 ] Gordon Sim commented on QPID-4969: -- The test should also be fixed, e.g.: {noformat} Index

Re: [VOTE] Remove autotools build for C++ build

2013-07-01 Thread Ken Giusti
> > [X] * When 0.25 opens after the 0.24 beta branch remove the C++ > qpid autotools build infrastructure in favour of the cmake tools. > * A heads up message to the user mailing list. > * Add a release note to 0.24 to say it is the last release that will > contain an autoto

Re: [VOTE] Remove autotools build for C++ build

2013-07-01 Thread Robbie Gemmell
[ x ] * When 0.25 opens after the 0.24 beta branch remove the C++ qpid autotools build infrastructure in favour of the cmake tools. On 27 June 2013 05:40, Andrew Stitcher wrote: > In March this year we had a discussion about removing finally switching > from autotools to cmake in the C++

New Defects reported by Coverity Scan for Apache-Qpid

2013-07-01 Thread scan-admin
Hi, Please find the latest report on new defect(s) introduced to Apache-Qpid found with Coverity Scan Defect(s) Reported-by: Coverity Scan ** CID 1040638: Mixing enum types (MIXED_ENUMS) /qpidbuilds/trunk/qpid/cpp/src/qpid/acl/AclData.cpp: 184 ** CID 1040637: Missing unlock (LOCK) /q

[jira] [Commented] (QPID-4969) C++ Broker headers exchange allows creation of bindings with duplicate keys

2013-07-01 Thread Chuck Rolke (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696920#comment-13696920 ] Chuck Rolke commented on QPID-4969: --- Gordon's patch (thanks for that!) still fails Fraser

[jira] [Commented] (QPID-4969) C++ Broker headers exchange allows creation of bindings with duplicate keys

2013-07-01 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696947#comment-13696947 ] Gordon Sim commented on QPID-4969: -- Actually... I take that back. I'm not sure it is corre

[jira] [Commented] (QPID-4969) C++ Broker headers exchange allows creation of bindings with duplicate keys

2013-07-01 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696936#comment-13696936 ] Gordon Sim commented on QPID-4969: -- My patch _does_ fix Fraser's case (at least as far as

Re: New Defects reported by Coverity Scan for Apache-Qpid

2013-07-01 Thread Ken Giusti
Unless I'm missing something subtle, this appears to be a false positive. Coverity marked a few uses of ScopedLock with this error, but not all, which seems curious. -K - Forwarded Message - > From: scan-ad...@coverity.com > To: dev@qpid.apache.org > Sent: Sunday, June 30, 2013 5:39:43

RE: New Defects reported by Coverity Scan for Apache-Qpid

2013-07-01 Thread Steve Huston
I agree, Ken. If anyone knows how to make Coverity stop this, please let me know. Else I'll check into it. I know there are a few ways to mark things as false positive. > -Original Message- > From: Ken Giusti [mailto:kgiu...@redhat.com] > Sent: Monday, July 01, 2013 1:17 PM > To: Qpid De

Re: New Defects reported by Coverity Scan for Apache-Qpid

2013-07-01 Thread Ken Giusti
Hi Steve, I've marked that particular error as "false positive" in Coverity Connect, but from what I can tell, the "right" way to fix such lock wrapper classes is to create a "model" for those wrapper classes. There's some documentation here: http://scan5.coverity.com:8080/docs/en/cov_checker

Re: New Defects reported by Coverity Scan for Apache-Qpid

2013-07-01 Thread Ted Ross
That particular ScopedLock had a ScopedUnlock inside its scope. I wonder if that is leading Coverity astray. -Ted On 07/01/2013 01:16 PM, Ken Giusti wrote: Unless I'm missing something subtle, this appears to be a false positive. Coverity marked a few uses of ScopedLock with this error, but

RE: New Defects reported by Coverity Scan for Apache-Qpid

2013-07-01 Thread Steve Huston
Yes, there is a way - I can do it, probably because I'm the admin for the project. If you create one, I'll set it up. > -Original Message- > From: Ken Giusti [mailto:kgiu...@redhat.com] > Sent: Monday, July 01, 2013 2:11 PM > To: dev@qpid.apache.org > Subject: Re: New Defects reported by

[jira] [Created] (QPID-4971) C++ Broker queue settings have uninitialized variables

2013-07-01 Thread Chuck Rolke (JIRA)
Chuck Rolke created QPID-4971: - Summary: C++ Broker queue settings have uninitialized variables Key: QPID-4971 URL: https://issues.apache.org/jira/browse/QPID-4971 Project: Qpid Issue Type: Bug

[jira] [Commented] (QPID-4971) C++ Broker queue settings have uninitialized variables

2013-07-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13697084#comment-13697084 ] ASF subversion and git services commented on QPID-4971: --- Commit 14986

[jira] [Commented] (QPID-4943) [Java Broker] Introduce a feature for 0-8/0-9/0-9-1protocols to close a connection on receiving a mandatory unroutable message in a transacted session

2013-07-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13697095#comment-13697095 ] ASF subversion and git services commented on QPID-4943: --- Commit 14986

[jira] [Commented] (QPID-4969) C++ Broker headers exchange allows creation of bindings with duplicate keys

2013-07-01 Thread Chuck Rolke (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13697113#comment-13697113 ] Chuck Rolke commented on QPID-4969: --- We need to call the federation addOrigin function as

[jira] [Commented] (QPID-4969) C++ Broker headers exchange allows creation of bindings with duplicate keys

2013-07-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13697139#comment-13697139 ] ASF subversion and git services commented on QPID-4969: --- Commit 14986

Re: New Defects reported by Coverity Scan for Apache-Qpid

2013-07-01 Thread Ken Giusti
Ok - I'll give it a go, stay tuned. -K - Original Message - > From: "Steve Huston" > To: dev@qpid.apache.org > Sent: Monday, July 1, 2013 2:32:14 PM > Subject: RE: New Defects reported by Coverity Scan for Apache-Qpid > > Yes, there is a way - I can do it, probably because I'm the admin