Re: Review Request 16316: Implement control of internal logging in qpid::messaging API

> On Dec. 17, 2013, 5:17 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/include/qpid/messaging/Logger.h, line 85 > > > > > > Those are the category names (I didn't want to be much more specific as > > they aren't rea

Re: Review Request 16316: Implement control of internal logging in qpid::messaging API

> On Dec. 17, 2013, 5:22 p.m., Alan Conway wrote: > > /trunk/qpid/cpp/src/qpid/messaging/Logger.cpp, line 68 > > > > > > That's really, really weird. I had no idea you could omit the braces in > > a function definition

Re: Review Request 16316: Implement control of internal logging in qpid::messaging API

> On Dec. 17, 2013, 5:22 p.m., Alan Conway wrote: > > /trunk/qpid/cpp/src/qpid/messaging/Logger.cpp, line 68 > > > > > > That's really, really weird. I had no idea you could omit the braces in > > a function definition

Re: Review Request 16316: Implement control of internal logging in qpid::messaging API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16316/#review30543 --- Ship it! /trunk/qpid/cpp/src/qpid/messaging/Logger.cpp

Re: Review Request 16316: Implement control of internal logging in qpid::messaging API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16316/#review30541 --- /trunk/qpid/cpp/include/qpid/messaging/Logger.h

Re: Review Request 16316: Implement control of internal logging in qpid::messaging API

> On Dec. 17, 2013, 5:10 p.m., Alan Conway wrote: > > /trunk/qpid/cpp/include/qpid/messaging/Logger.h, line 85 > > > > > > Chuck did some work to provide a set of sensible "subsystem" labels > > that the pattern can ma

Re: Review Request 16316: Implement control of internal logging in qpid::messaging API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16316/#review30540 --- Ship it! Nice job! /trunk/qpid/cpp/include/qpid/messaging/Logger.

Re: Review Request 16316: Implement control of internal logging in qpid::messaging API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16316/ --- (Updated Dec. 17, 2013, 5:02 p.m.) Review request for qpid, Chug Rolke and Gord

[jira] [Resolved] (QPID-5217) Dispatch - Cleanup of API inconsistencies and oddities

[ https://issues.apache.org/jira/browse/QPID-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved QPID-5217. Resolution: Fixed > Dispatch - Cleanup of API inconsistencies and oddities > ---

[jira] [Resolved] (QPID-5367) Dispatch - Add man pages and stubs for other documentation

[ https://issues.apache.org/jira/browse/QPID-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved QPID-5367. Resolution: Fixed > Dispatch - Add man pages and stubs for other documentation > ---

[jira] [Resolved] (QPID-5380) Dispatch - Simplify use of non-system instances

[ https://issues.apache.org/jira/browse/QPID-5380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved QPID-5380. Resolution: Fixed > Dispatch - Simplify use of non-system instances > --

[jira] [Resolved] (QPID-5392) Dispatch - Remove ChangeLog; use jira and our website release pages instead

[ https://issues.apache.org/jira/browse/QPID-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved QPID-5392. Resolution: Fixed > Dispatch - Remove ChangeLog; use jira and our website release pages instead > --

[jira] [Commented] (QPID-5392) Dispatch - Remove ChangeLog; use jira and our website release pages instead

[ https://issues.apache.org/jira/browse/QPID-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850661#comment-13850661 ] ASF subversion and git services commented on QPID-5392: --- Commit 15516

Re: 0.26 RC1 RAT output

On 12/16/2013 06:13 PM, Gordon Sim wrote: On 12/16/2013 07:29 PM, Robbie Gemmell wrote: On 16 December 2013 18:54, Alan Conway wrote: The following are processed by various programs, I don't know if there's a safe comment syntax. Can we get an exemption for such files? QPID_VERSION.txt cpp/QP

[jira] [Commented] (QPID-5255) 0.26 release tasks

[ https://issues.apache.org/jira/browse/QPID-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850657#comment-13850657 ] ASF subversion and git services commented on QPID-5255: --- Commit 15516

[jira] [Commented] (QPID-5255) 0.26 release tasks

[ https://issues.apache.org/jira/browse/QPID-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850658#comment-13850658 ] ASF subversion and git services commented on QPID-5255: --- Commit 15516

Re: Review Request 16316: Implement control of internal logging in qpid::messaging API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16316/#review30539 --- /trunk/qpid/cpp/include/qpid/messaging/Logger.h

Re: Review Request 16316: Implement control of internal logging in qpid::messaging API

> On Dec. 17, 2013, 2:46 p.m., Chug Rolke wrote: > > /trunk/qpid/cpp/src/qpid/messaging/Logger.cpp, line 68 > > > > > > How is this function's body not surrounded with {}? Seems unnatural. This is just a rarely used pa

[jira] [Assigned] (QPID-5428) heartbeats not in use when attempting to connect

[ https://issues.apache.org/jira/browse/QPID-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim reassigned QPID-5428: Assignee: Alan Conway > heartbeats not in use when attempting to connect > -

Re: Review Request 16316: Implement control of internal logging in qpid::messaging API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16316/#review30530 --- Ship it! Minor doc nits and some explanation for the wiki . /trun

[jira] [Commented] (QPID-5419) [JMS Client] The JMS Client fails to start a dispatcher thread for Durable Consumer's

[ https://issues.apache.org/jira/browse/QPID-5419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850414#comment-13850414 ] Rob Godfrey commented on QPID-5419: --- Merged to 0.26 branch: https://svn.apache.org/r1551

Re: Review Request 16316: Implement control of internal logging in qpid::messaging API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16316/#review30527 --- Ship it! Couple of questions, just to be sure, but looks good to me

[jira] [Updated] (QPID-5429) Java Broker does not always write the reason it cannot start-up to qpid.log

[ https://issues.apache.org/jira/browse/QPID-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-5429: - Priority: Minor (was: Major) > Java Broker does not always write the reason it cannot start-up to qpid.lo

[jira] [Created] (QPID-5429) Java Broker does not always write the reason it cannot start-up to qpid.log

Keith Wall created QPID-5429: Summary: Java Broker does not always write the reason it cannot start-up to qpid.log Key: QPID-5429 URL: https://issues.apache.org/jira/browse/QPID-5429 Project: Qpid

[jira] [Created] (QPID-5428) heartbeats not in use when attempting to connect

Gordon Sim created QPID-5428: Summary: heartbeats not in use when attempting to connect Key: QPID-5428 URL: https://issues.apache.org/jira/browse/QPID-5428 Project: Qpid Issue Type: Bug

[jira] [Commented] (QPID-5415) Implement logging control in qpid::messaging API

[ https://issues.apache.org/jira/browse/QPID-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850240#comment-13850240 ] Andrew Stitcher commented on QPID-5415: --- Currently the tests for the proposed change

[jira] [Created] (QPID-5427) It is possible to mask critical logging messages

Andrew Stitcher created QPID-5427: - Summary: It is possible to mask critical logging messages Key: QPID-5427 URL: https://issues.apache.org/jira/browse/QPID-5427 Project: Qpid Issue Type: Bug

[jira] [Comment Edited] (QPID-5415) Implement logging control in qpid::messaging API

[ https://issues.apache.org/jira/browse/QPID-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850222#comment-13850222 ] Andrew Stitcher edited comment on QPID-5415 at 12/17/13 8:05 AM:

[jira] [Commented] (QPID-5415) Implement logging control in qpid::messaging API

[ https://issues.apache.org/jira/browse/QPID-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850222#comment-13850222 ] Andrew Stitcher commented on QPID-5415: --- There is an open review for proposed code:

Review Request 16316: Implement control of internal logging in qpid::messaging API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16316/ --- Review request for qpid, Chug Rolke and Gordon Sim. Bugs: QPID-5415 https:/