Review Request 28209: QPID-4710: [AMQP 1.0] Support for transactions in qpid.messaging C++ client.

2014-11-18 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28209/ --- Review request for qpid and Gordon Sim. Repository: qpid Description ---

Request for Proton code review: SSL certificate stores (Windows and more)

2014-11-18 Thread Cliff Jansen
Following Andrew's lead, I've posted a pull request for review feedback on an "extended usage pattern" to the Proton API to specify alternate certificate containers, for Windows in this case, but it should also apply to alternate SSL/TLS implementations such as NSS or Java keystores. https://git

Re: Request for Proton code review: IO layer refactor.

2014-11-18 Thread Andrew Stitcher
On Mon, 2014-11-17 at 15:14 -0500, Andrew Stitcher wrote: > I've posted a pull request against the Github Apache proton mirror to > get review feedback for my IO layer refactoring. > > https://github.com/apache/qpid-proton/pull/1 I've added a change to this request to correctly support the previo

Re: Request for Proton code review: IO layer refactor.

2014-11-18 Thread Andrew Stitcher
On Tue, 2014-11-18 at 14:00 -0500, Rafael Schloming wrote: > On Tue, Nov 18, 2014 at 1:07 PM, Andrew Stitcher > wrote: > > > On Tue, 2014-11-18 at 17:41 +, Gordon Sim wrote: > > > On 11/18/2014 05:29 PM, Andrew Stitcher wrote: > > > > On Tue, 2014-11-18 at 09:35 -0500, Rafael Schloming wrote:

Re: Request for Proton code review: IO layer refactor.

2014-11-18 Thread Rafael Schloming
On Tue, Nov 18, 2014 at 12:29 PM, Andrew Stitcher wrote: > On Tue, 2014-11-18 at 09:35 -0500, Rafael Schloming wrote: > > On Mon, Nov 17, 2014 at 4:48 PM, Andrew Stitcher > > wrote: > > ... > > There are a couple things I don't like about the API after the change. > > > > 1. pn_transport_client(

Re: Request for Proton code review: IO layer refactor.

2014-11-18 Thread Rafael Schloming
On Tue, Nov 18, 2014 at 1:07 PM, Andrew Stitcher wrote: > On Tue, 2014-11-18 at 17:41 +, Gordon Sim wrote: > > On 11/18/2014 05:29 PM, Andrew Stitcher wrote: > > > On Tue, 2014-11-18 at 09:35 -0500, Rafael Schloming wrote: > > >> 2. Given that we have a distinct configuration phase regardless

Re: Request for Proton code review: IO layer refactor.

2014-11-18 Thread Andrew Stitcher
On Tue, 2014-11-18 at 17:41 +, Gordon Sim wrote: > On 11/18/2014 05:29 PM, Andrew Stitcher wrote: > > On Tue, 2014-11-18 at 09:35 -0500, Rafael Schloming wrote: > >> 2. Given that we have a distinct configuration phase regardless, it is > >> simply unnecessary to force people to choose client v

Re: Request for Proton code review: IO layer refactor.

2014-11-18 Thread Gordon Sim
On 11/18/2014 05:29 PM, Andrew Stitcher wrote: On Tue, 2014-11-18 at 09:35 -0500, Rafael Schloming wrote: 2. Given that we have a distinct configuration phase regardless, it is simply unnecessary to force people to choose client vs server up front. We can simply default the mode to client and ha

Re: Request for Proton code review: IO layer refactor.

2014-11-18 Thread Andrew Stitcher
On Tue, 2014-11-18 at 09:35 -0500, Rafael Schloming wrote: > On Mon, Nov 17, 2014 at 4:48 PM, Andrew Stitcher > wrote: > ... > There are a couple things I don't like about the API after the change. > > 1. pn_transport_client()/pn_transport_server() don't follow our naming > conventions, as constr

[jira] [Commented] (QPID-6233) [Java Broker] Update operational logging appendix in Java Broker documentation

2014-11-18 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216445#comment-14216445 ] ASF subversion and git services commented on QPID-6233: --- Commit 16403

[jira] [Created] (QPID-6233) [Java Broker] Update operational logging appendix in Java Broker documentation

2014-11-18 Thread Alex Rudyy (JIRA)
Alex Rudyy created QPID-6233: Summary: [Java Broker] Update operational logging appendix in Java Broker documentation Key: QPID-6233 URL: https://issues.apache.org/jira/browse/QPID-6233 Project: Qpid

[jira] [Commented] (QPID-6226) Running client/server C++ client examples fail against the Java Broker with 'Cannot declare queue..'

2014-11-18 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216437#comment-14216437 ] ASF subversion and git services commented on QPID-6226: --- Commit 16403

[jira] [Assigned] (QPID-6231) [Perftests framework] Make performance framework fully JMS compatible

2014-11-18 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-6231: Assignee: Keith Wall (was: Alex Rudyy) Keith, Could you please review the changes? > [Perftests fr

[jira] [Updated] (QPID-6231) [Perftests framework] Make performance framework fully JMS compatible

2014-11-18 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-6231: - Status: Reviewable (was: In Progress) > [Perftests framework] Make performance framework fully JMS compati

[jira] [Commented] (DISPATCH-74) Allow changes to logging configuration of a running router.

2014-11-18 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216340#comment-14216340 ] ASF subversion and git services commented on DISPATCH-74: - Commit

[jira] [Commented] (QPID-6231) [Perftests framework] Make performance framework fully JMS compatible

2014-11-18 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216312#comment-14216312 ] ASF subversion and git services commented on QPID-6231: --- Commit 16403

[jira] [Updated] (QPID-6230) [linearstore] qpid-qls-analyze fails when analyzing empty journal

2014-11-18 Thread Kim van der Riet (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kim van der Riet updated QPID-6230: --- Fix Version/s: 0.31 > [linearstore] qpid-qls-analyze fails when analyzing empty journal > -

[jira] [Closed] (QPID-6232) [C++ broker] Linearstore segfaults when ulimit prevents creating new file in EFP

2014-11-18 Thread Pavel Moravec (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Moravec closed QPID-6232. --- Resolution: Fixed Fix Version/s: Future Committed revision 1640357. > [C++ broker] Linearstore

[jira] [Commented] (QPID-6232) [C++ broker] Linearstore segfaults when ulimit prevents creating new file in EFP

2014-11-18 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216255#comment-14216255 ] ASF subversion and git services commented on QPID-6232: --- Commit 16403

[jira] [Created] (QPID-6232) [C++ broker] Linearstore segfaults when ulimit prevents creating new file in EFP

2014-11-18 Thread Pavel Moravec (JIRA)
Pavel Moravec created QPID-6232: --- Summary: [C++ broker] Linearstore segfaults when ulimit prevents creating new file in EFP Key: QPID-6232 URL: https://issues.apache.org/jira/browse/QPID-6232 Project: Q

[jira] [Updated] (QPID-6231) [Perftests framework] Make performance framework fully JMS compatible

2014-11-18 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-6231: - Attachment: 0001-QPID-6231-Perftests-framework-Make-performance-frame.patch Attached a patch with proposed

Re: Request for Proton code review: IO layer refactor.

2014-11-18 Thread Gordon Sim
On 11/18/2014 02:35 PM, Rafael Schloming wrote: I would suggest the following options for this particular API point as both being preferable. 1. if we really want to force people to choose up front, the right way to do it is with a single constructor: pn_transport_t *t = pn_transport(CLI

[jira] [Resolved] (QPID-6230) [linearstore] qpid-qls-analyze fails when analyzing empty journal

2014-11-18 Thread Kim van der Riet (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kim van der Riet resolved QPID-6230. Resolution: Fixed svn r.1640353 adds a simple check for this condition and avoids the error.

[jira] [Commented] (QPID-6230) [linearstore] qpid-qls-analyze fails when analyzing empty journal

2014-11-18 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216240#comment-14216240 ] ASF subversion and git services commented on QPID-6230: --- Commit 16403

[jira] [Created] (QPID-6231) [Perftests framework] Make performance framework fully JMS compatible

2014-11-18 Thread Alex Rudyy (JIRA)
Alex Rudyy created QPID-6231: Summary: [Perftests framework] Make performance framework fully JMS compatible Key: QPID-6231 URL: https://issues.apache.org/jira/browse/QPID-6231 Project: Qpid Iss

[jira] [Created] (QPID-6230) [linearstore] qpid-qls-analyze fails when analyzing empty journal

2014-11-18 Thread Kim van der Riet (JIRA)
Kim van der Riet created QPID-6230: -- Summary: [linearstore] qpid-qls-analyze fails when analyzing empty journal Key: QPID-6230 URL: https://issues.apache.org/jira/browse/QPID-6230 Project: Qpid

Re: Request for Proton code review: IO layer refactor.

2014-11-18 Thread Rafael Schloming
On Mon, Nov 17, 2014 at 4:48 PM, Andrew Stitcher wrote: > On Mon, 2014-11-17 at 20:56 +, Gordon Sim wrote: > > On 11/17/2014 08:14 PM, Andrew Stitcher wrote: > > > As we currently don't have reviewboard set up for Qpid Proton (since > the > > > git migration). > > > > > > I've posted a pull r

[jira] [Updated] (QPID-6208) PermittedNodeList seen to disappear while performing certain HA operations

2014-11-18 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-6208: - Affects Version/s: 0.30 > PermittedNodeList seen to disappear while performing certain HA operations >

[jira] [Commented] (QPID-4708) [AMQP 1.0] failover support (i.e. reconnect=true)

2014-11-18 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216133#comment-14216133 ] Gordon Sim commented on QPID-4708: -- This issue is for the c++ client. I believe the JMS cl

[jira] [Comment Edited] (QPID-4708) [AMQP 1.0] failover support (i.e. reconnect=true)

2014-11-18 Thread Gianni Codevico (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216097#comment-14216097 ] Gianni Codevico edited comment on QPID-4708 at 11/18/14 11:46 AM: ---

[jira] [Commented] (QPID-4708) [AMQP 1.0] failover support (i.e. reconnect=true)

2014-11-18 Thread Gianni Codevico (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216097#comment-14216097 ] Gianni Codevico commented on QPID-4708: --- Hi, I am testing a connection using the QPid

[jira] [Resolved] (QPID-6208) PermittedNodeList seen to disappear while performing certain HA operations

2014-11-18 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-6208. -- Resolution: Fixed The change look reasonable to me > PermittedNodeList seen to disappear while performin

[jira] [Resolved] (QPID-6222) [Java Broker] Replica can go into a loop if it runs out of disk space

2014-11-18 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-6222. -- Resolution: Fixed The change look reasonable to me > [Java Broker] Replica can go into a loop if it runs

[jira] [Reopened] (QPID-6222) [Java Broker] Replica can go into a loop if it runs out of disk space

2014-11-18 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reopened QPID-6222: -- > [Java Broker] Replica can go into a loop if it runs out of disk space > ---

Re: Request for Proton code review: IO layer refactor.

2014-11-18 Thread Gordon Sim
On 11/17/2014 09:48 PM, Andrew Stitcher wrote: On Mon, 2014-11-17 at 20:56 +, Gordon Sim wrote: On 11/17/2014 08:14 PM, Andrew Stitcher wrote: As we currently don't have reviewboard set up for Qpid Proton (since the git migration). I've posted a pull request against the Github Apache proto

[jira] [Commented] (QPID-6222) [Java Broker] Replica can go into a loop if it runs out of disk space

2014-11-18 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215999#comment-14215999 ] ASF subversion and git services commented on QPID-6222: --- Commit 16402

[jira] [Commented] (QPID-6208) PermittedNodeList seen to disappear while performing certain HA operations

2014-11-18 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215997#comment-14215997 ] ASF subversion and git services commented on QPID-6208: --- Commit 16402

Re: Request for Proton code review: IO layer refactor.

2014-11-18 Thread Cliff Jansen
I say "Ship it!". I don't feel strongly about the deprecated bits, but if we don't remove them now, when is the "right" or at least better time? Cliff On Mon, Nov 17, 2014 at 12:14 PM, Andrew Stitcher wrote: > As we currently don't have reviewboard set up for Qpid Proton (since the > git migrat