Re: Review Request 34229: Expose subject from peer's certificate

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34229/#review83857 --- proton-c/include/proton/ssl.h

Re: Review Request 34229: Expose subject from peer's certificate

> On May 14, 2015, 8:17 p.m., Andrew Stitcher wrote: > > This looks good to me - essentially what I was starting with. > > > > Although we may nned something more specific to interoperate with qpidd as > > it has a very specific notion of what the authid for sasl external looks > > like - I ne

Re: Review Request 34229: Expose subject from peer's certificate

> On May 14, 2015, 8:17 p.m., Andrew Stitcher wrote: > > This looks good to me - essentially what I was starting with. > > > > Although we may nned something more specific to interoperate with qpidd as > > it has a very specific notion of what the authid for sasl external looks > > like - I ne

Re: Review Request 34229: Expose subject from peer's certificate

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34229/ --- (Updated May 14, 2015, 8:27 p.m.) Review request for qpid, Andrew Stitcher, Cli

Re: Review Request 34229: Expose subject from peer's certificate

> On May 14, 2015, 8:17 p.m., Andrew Stitcher wrote: > > proton-c/src/ssl/openssl.c, line 1263 > > > > > > I think _oneline would be closer in format to using flags > > XN_FLAGS_ONELINE Oops, I didn't mean to lea

Re: Review Request 34229: Expose subject from peer's certificate

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34229/#review83829 --- This looks good to me - essentially what I was starting with. Altho

Re: Review Request 34229: Expose subject from peer's certificate

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34229/#review83830 --- Ship it! Ship It! - Alan Conway On May 14, 2015, 7:54 p.m., Gord

Review Request 34229: Expose subject from peer's certificate

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34229/ --- Review request for qpid, Andrew Stitcher, Cliff Jansen, Kenneth Giusti, and Rafa

[jira] [Updated] (QPID-6382) [Java Broker] REST API and Management UI should allow management of objects with '/' in their name

[ https://issues.apache.org/jira/browse/QPID-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated QPID-6382: -- Attachment: QPID-6382-v3.patch A further refinement to cope with the case that an authentication provider

[jira] [Commented] (QPID-6382) [Java Broker] REST API and Management UI should allow management of objects with '/' in their name

[ https://issues.apache.org/jira/browse/QPID-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543832#comment-14543832 ] Rob Godfrey commented on QPID-6382: --- So I looked at util.js and it seemed like the only p

[jira] [Commented] (QPID-6542) [Java Broker] Add additional logging when errors occur during management actions

[ https://issues.apache.org/jira/browse/QPID-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543778#comment-14543778 ] Lorenz Quack commented on QPID-6542: looks good. minor comments about coding style: Acc

[jira] [Commented] (QPID-6541) [Java Broker] In rare cases it is possible for newly arrived messages to be enqueued ahead of recovering messages in asynchronous recovery

[ https://issues.apache.org/jira/browse/QPID-6541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543774#comment-14543774 ] Lorenz Quack commented on QPID-6541: yes. looks good. > [Java Broker] In rare cases it

[jira] [Commented] (QPID-6382) [Java Broker] REST API and Management UI should allow management of objects with '/' in their name

[ https://issues.apache.org/jira/browse/QPID-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543768#comment-14543768 ] Lorenz Quack commented on QPID-6382: /*rant mode*/ Why can't people adhere to standards

[jira] [Commented] (QPIDJMS-49) Not all messages can be received by the Qpid JMS client

[ https://issues.apache.org/jira/browse/QPIDJMS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543750#comment-14543750 ] Robbie Gemmell commented on QPIDJMS-49: --- Hi Jakub, The likely cause for qpid-send (

[jira] [Commented] (QPID-6541) [Java Broker] In rare cases it is possible for newly arrived messages to be enqueued ahead of recovering messages in asynchronous recovery

[ https://issues.apache.org/jira/browse/QPID-6541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543729#comment-14543729 ] Rob Godfrey commented on QPID-6541: --- I agree with your assessment. I've made what I th

[jira] [Commented] (QPID-6541) [Java Broker] In rare cases it is possible for newly arrived messages to be enqueued ahead of recovering messages in asynchronous recovery

[ https://issues.apache.org/jira/browse/QPID-6541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543726#comment-14543726 ] ASF subversion and git services commented on QPID-6541: --- Commit 16793

[jira] [Updated] (QPID-6541) [Java Broker] In rare cases it is possible for newly arrived messages to be enqueued ahead of recovering messages in asynchronous recovery

[ https://issues.apache.org/jira/browse/QPID-6541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorenz Quack updated QPID-6541: --- Attachment: 0001-QPID-6541-improvement.patch > [Java Broker] In rare cases it is possible for newly arr

[jira] [Commented] (QPID-6541) [Java Broker] In rare cases it is possible for newly arrived messages to be enqueued ahead of recovering messages in asynchronous recovery

[ https://issues.apache.org/jira/browse/QPID-6541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543700#comment-14543700 ] Lorenz Quack commented on QPID-6541: Looks good. One small improvement: I think line 10

Re: qpid-proton git commit: PROTON-860: allow acceptor to be configured for ssl

On 05/14/2015 02:23 PM, Rafael Schloming wrote: Sorry about the late comment on the review. No problem, better late than never! I think you want PN_VOID, not PN_WEAKREF. I'll change that right away, thanks! - To unsubscri

Re: qpid-proton git commit: PROTON-860: allow acceptor to be configured for ssl

Hi Gordon, Sorry about the late comment on the review. I think you want PN_VOID, not PN_WEAKREF. I thought I had replied promptly, but apparently I had forgotten to click "publish" and so my comment lingered in reviewboard for quite a while. --Rafael On Thu, May 14, 2015 at 8:34 AM, wrote: >

Re: Review Request 33902: Allow acceptor to be configured for ssl

> On May 6, 2015, 5:49 p.m., Rafael Schloming wrote: > > proton-c/src/reactor/acceptor.c, line 95 > > > > > > Any particular reason to make this a weakref? > > Gordon Sim wrote: > I initially made it a PN_OBJECT, b

[jira] [Updated] (QPID-6382) [Java Broker] REST API and Management UI should allow management of objects with '/' in their name

[ https://issues.apache.org/jira/browse/QPID-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated QPID-6382: -- Attachment: QPID-6382-v2.patch Hi Lorenz, If I understand your patch correctly I think it will encode th

[jira] [Created] (QPIDJMS-49) Not all messages can be received by the Qpid JMS client

Jakub Scholz created QPIDJMS-49: --- Summary: Not all messages can be received by the Qpid JMS client Key: QPIDJMS-49 URL: https://issues.apache.org/jira/browse/QPIDJMS-49 Project: Qpid JMS Issue

[jira] [Updated] (QPIDJMS-48) Handling of properties with "." in their name

[ https://issues.apache.org/jira/browse/QPIDJMS-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPIDJMS-48: -- Affects Version/s: 0.2.0 Fix Version/s: 0.3.0 > Handling of properties with "." in their

[jira] [Commented] (QPIDJMS-48) Handling of properties with "." in their name

[ https://issues.apache.org/jira/browse/QPIDJMS-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543598#comment-14543598 ] Robbie Gemmell commented on QPIDJMS-48: --- Hi Jakub, Thanks for pointing this out. I

[jira] [Created] (QPIDJMS-48) Handling of properties with "." in their name

Jakub Scholz created QPIDJMS-48: --- Summary: Handling of properties with "." in their name Key: QPIDJMS-48 URL: https://issues.apache.org/jira/browse/QPIDJMS-48 Project: Qpid JMS Issue Type: Bug

[jira] [Updated] (QPID-6382) [Java Broker] REST API and Management UI should allow management of objects with '/' in their name

[ https://issues.apache.org/jira/browse/QPID-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorenz Quack updated QPID-6382: --- Attachment: 0001-QPID-6382-Java-Broker-REST-API-and-Management-UI-sho.patch adds a second stage of enco

Re: open Pull Request for C++ build on OSX

On 14 May 2015 at 07:32, Andrew Stitcher wrote: > On Thu, 2015-05-07 at 17:14 +0100, Robbie Gemmell wrote: >> Chucks recent Pull Request update made me look at what we have open. >> There was one that looks complete from the JIR, but wasnt closed via >> the commits, so I commented asking the user