Re: Review Request 37195: Validate the incoming frame header

2015-08-07 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37195/#review94505 --- Ship it! Ship It! - Gordon Sim On Aug. 6, 2015, 6:58 p.m., Kenne

[jira] [Commented] (QPID-6667) [Java Broker] Unusued temporary queues are not deleted on connection disconnect

2015-08-07 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661677#comment-14661677 ] Alex Rudyy commented on QPID-6667: -- I investigated the issue and here is the summary of my

Re: Review Request 37195: Validate the incoming frame header

2015-08-07 Thread Robbie Gemmell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37195/#review94529 --- Ship it! Looks good. I verified that this stopped the crashes seen

Re: Review Request 37195: Validate the incoming frame header

2015-08-07 Thread Kenneth Giusti
> On Aug. 7, 2015, 11:44 a.m., Robbie Gemmell wrote: > > Looks good. I verified that this stopped the crashes seen when trying to > > use DIGEST-MD5. I even saw (viatrace logs) the example work entirely and > > send its message some times. > > > > I did have some tiny tweaks for the tests, to

[jira] [Resolved] (QPID-3521) failover process for the 0-8 client does not clear the pre-dispatch queue

2015-08-07 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved QPID-3521. -- Resolution: Fixed Changes look reasonable to me. > failover process for the 0-8 client does not clear th

[jira] [Updated] (QPID-3521) failover process for the 0-8 client does not clear the pre-dispatch queue

2015-08-07 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-3521: - Fix Version/s: qpid-java-6.0 > failover process for the 0-8 client does not clear the pre-dispatch queue >

[jira] [Closed] (QPID-3521) failover process for the 0-8 client does not clear the pre-dispatch queue

2015-08-07 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall closed QPID-3521. > failover process for the 0-8 client does not clear the pre-dispatch queue > ---

[jira] [Commented] (QPID-6670) Exchange deletion does not await binding deletion leading to possibility of a IllegalStateException : Task executor is not in ACTIVE state

2015-08-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661747#comment-14661747 ] ASF subversion and git services commented on QPID-6670: --- Commit 16946

[jira] [Commented] (QPID-6664) Connection#close may hang awaiting failover to exhaust retries

2015-08-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661807#comment-14661807 ] ASF subversion and git services commented on QPID-6664: --- Commit 16946

[jira] [Closed] (QPID-6664) Connection#close may hang awaiting failover to exhaust retries

2015-08-07 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall closed QPID-6664. > Connection#close may hang awaiting failover to exhaust retries > --

[jira] [Commented] (QPID-6664) Connection#close may hang awaiting failover to exhaust retries

2015-08-07 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661810#comment-14661810 ] Keith Wall commented on QPID-6664: -- Changes look reasonable to me. I removed the dead cod

Review Request 37217: Switch from handle to concrete class or reference in C++ client

2015-08-07 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37217/ --- Review request for qpid, Alan Conway and Andrew Stitcher. Bugs: PROTON-865

[jira] [Comment Edited] (QPID-6667) [Java Broker] Unusued temporary queues are not deleted on connection disconnect

2015-08-07 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661677#comment-14661677 ] Alex Rudyy edited comment on QPID-6667 at 8/7/15 2:09 PM: -- I inves

Re: [VOTE] Move Dispatch to git

2015-08-07 Thread Ted Ross
+1 [Yes] On 08/04/2015 10:06 AM, Ken Giusti wrote: Given that there seems to be interest in moving the qpid-dispatch source repository to git, I'm calling a formal vote on the topic. [ ] Yes - move the qpid-dispatch repo to git [ ] No - no change: leave qpid-dispatch on subversion thanks, -

Re: Review Request 37217: Switch from handle to concrete class or reference in C++ client

2015-08-07 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37217/#review94542 --- I would like to try something simpler (sorry!) There are 2 things I

[jira] [Updated] (QPID-6671) java.util.NoSuchElementException whilst trying to deregister a connection mbean

2015-08-07 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-6671: - Attachment: potential-fix-for-NoSuchElementException-on-concurrent-vhn-close-in-broker-config-thread-and-co

Re: Review Request 37217: Switch from handle to concrete class or reference in C++ client

2015-08-07 Thread Alan Conway
> On Aug. 7, 2015, 2:54 p.m., Alan Conway wrote: > > I would like to try something simpler (sorry!) > > > > There are 2 things I'd like to separate: > > > > 1. Clean, simple, no-value-add access to proton types. > > 2. Separate convenience classes to make proton easier to use. > > > > For 1. t

Re: [VOTE] Move Dispatch to git

2015-08-07 Thread Ken Giusti
Just a head's up - I'm on vacation next week, so I'll let this vote remain open until I get back. I'll close the vote on 8/17 - Original Message - > Sent: Tuesday, August 4, 2015 10:06:14 AM > Subject: [VOTE] Move Dispatch to git > > > Given that there seems to be interest in moving t

[jira] [Created] (QPID-6683) Jetty thread seemingly spins if many HTTP ports are defined on hosts with large numbers of core

2015-08-07 Thread Keith Wall (JIRA)
Keith Wall created QPID-6683: Summary: Jetty thread seemingly spins if many HTTP ports are defined on hosts with large numbers of core Key: QPID-6683 URL: https://issues.apache.org/jira/browse/QPID-6683 P

[jira] [Resolved] (QPID-6681) Disallow the changing of an object's type

2015-08-07 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-6681. -- Resolution: Fixed Assignee: Alex Rudyy (was: Lorenz Quack) The changes look Ok to me > Disallow t

Re: Review Request 37217: Switch from handle to concrete class or reference in C++ client

2015-08-07 Thread Cliff Jansen
> On Aug. 7, 2015, 2:54 p.m., Alan Conway wrote: > > I would like to try something simpler (sorry!) > > > > There are 2 things I'd like to separate: > > > > 1. Clean, simple, no-value-add access to proton types. > > 2. Separate convenience classes to make proton easier to use. > > > > For 1. t

[jira] [Commented] (QPID-6662) Use direct byte buffers

2015-08-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662106#comment-14662106 ] ASF subversion and git services commented on QPID-6662: --- Commit 16947

[jira] [Commented] (QPID-6683) Jetty thread seemingly spins if many HTTP ports are defined on hosts with large numbers of core

2015-08-07 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662121#comment-14662121 ] Keith Wall commented on QPID-6683: -- The issue is that Qpid is constraining the Jetty *Serv

[jira] [Assigned] (QPID-6683) Jetty thread seemingly spins if many HTTP ports are defined on hosts with large numbers of core

2015-08-07 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned QPID-6683: Assignee: Keith Wall > Jetty thread seemingly spins if many HTTP ports are defined on hosts with >

[jira] [Comment Edited] (QPID-6683) Jetty thread seemingly spins if many HTTP ports are defined on hosts with large numbers of core

2015-08-07 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662121#comment-14662121 ] Keith Wall edited comment on QPID-6683 at 8/7/15 5:34 PM: -- The iss

[jira] [Comment Edited] (QPID-6683) Jetty thread seemingly spins if many HTTP ports are defined on hosts with large numbers of core

2015-08-07 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662121#comment-14662121 ] Keith Wall edited comment on QPID-6683 at 8/7/15 5:35 PM: -- The iss

[jira] [Comment Edited] (QPID-6683) Jetty thread seemingly spins if many HTTP ports are defined on hosts with large numbers of core

2015-08-07 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662121#comment-14662121 ] Keith Wall edited comment on QPID-6683 at 8/7/15 5:36 PM: -- The iss

[jira] [Comment Edited] (QPID-6683) Jetty thread seemingly spins if many HTTP ports are defined on hosts with large numbers of core

2015-08-07 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662121#comment-14662121 ] Keith Wall edited comment on QPID-6683 at 8/7/15 5:54 PM: -- The iss