Re: Review Request 42700: PROTON-1104 - move the deallocation and cleanup of the reactor's timer to pn_reactor_stop, do not close pipes until reactor is finalized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42700/#review116225 --- Ship it! Ship It! - Alan Conway On Jan. 24, 2016, 10:20 p.m.

Re: Review Request 42647: PROTON-1071: EventInjector hangs on Windows: add new interrupt primitives to selector and reactor

On Jan. 25, 2016, 2:42 p.m., Cliff Jansen wrote: > > Since the interrupt is now essentially a special method on the reactor, > > EventInjector as a separate, user-visiable class doesn't make as much sense > > in my view. I'd be inclined to try and merge it into Container. > > Alan Conway wrote

[jira] [Created] (DISPATCH-204) Identity mapping from X.509 certificate data to a descriptive nickname

Ted Ross created DISPATCH-204: - Summary: Identity mapping from X.509 certificate data to a descriptive nickname Key: DISPATCH-204 URL: https://issues.apache.org/jira/browse/DISPATCH-204 Project: Qpid Disp

[jira] [Commented] (QPID-7021) BDB hot backup (takeBackupNoLock) may fail with IOException

[ https://issues.apache.org/jira/browse/QPID-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115657#comment-15115657 ] Keith Wall commented on QPID-7021: -- The advice from Oracle is here: http://docs.oracle.com

[jira] [Commented] (QPID-6999) [Java Broker, BDBStore, HA] In replicated environment JE transactions aborted on committing can cause Broker shutdown

[ https://issues.apache.org/jira/browse/QPID-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115547#comment-15115547 ] Lorenz Quack commented on QPID-6999: * In {{GroupCreator#awaitNodeToAttainAttributeValu

[jira] [Commented] (DISPATCH-201) Initial release of management console

[ https://issues.apache.org/jira/browse/DISPATCH-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115536#comment-15115536 ] Robbie Gemmell commented on DISPATCH-201: - I notice there havent been any LICENS

[jira] [Commented] (QPID-6997) [Java Broker, BDBStore] HA JE Transaction commit might end up in NullPointerException when commit is invoked when majority is lost

[ https://issues.apache.org/jira/browse/QPID-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115534#comment-15115534 ] ASF subversion and git services commented on QPID-6997: --- Commit 17266

[jira] [Commented] (QPID-6999) [Java Broker, BDBStore, HA] In replicated environment JE transactions aborted on committing can cause Broker shutdown

[ https://issues.apache.org/jira/browse/QPID-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115533#comment-15115533 ] ASF subversion and git services commented on QPID-6999: --- Commit 17266

Re: Introducing container_engine: integrate proton with arbitrary IO and concurrency models.

I've only scanned the code a bit, but +1 - this looks promising. - Original Message - > From: "Alan Conway" > To: "dev" > Sent: Sunday, January 24, 2016 2:23:09 AM > Subject: Introducing container_engine: integrate proton with arbitrary IO and > concurrency models. > > The proton conne

[jira] [Commented] (QPID-6997) [Java Broker, BDBStore] HA JE Transaction commit might end up in NullPointerException when commit is invoked when majority is lost

[ https://issues.apache.org/jira/browse/QPID-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115518#comment-15115518 ] ASF subversion and git services commented on QPID-6997: --- Commit 17266

[jira] [Commented] (QPID-6999) [Java Broker, BDBStore, HA] In replicated environment JE transactions aborted on committing can cause Broker shutdown

[ https://issues.apache.org/jira/browse/QPID-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115517#comment-15115517 ] ASF subversion and git services commented on QPID-6999: --- Commit 17266

Re: Review Request 42647: PROTON-1071: EventInjector hangs on Windows: add new interrupt primitives to selector and reactor

On Jan. 25, 2016, 2:42 p.m., Cliff Jansen wrote: > > Since the interrupt is now essentially a special method on the reactor, > > EventInjector as a separate, user-visiable class doesn't make as much sense > > in my view. I'd be inclined to try and merge it into Container. > > Alan Conway wrote

[jira] [Commented] (QPID-7021) BDB hot backup (takeBackupNoLock) may fail with IOException

[ https://issues.apache.org/jira/browse/QPID-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115486#comment-15115486 ] Lorenz Quack commented on QPID-7021: The change looks good. However, how confident are

[jira] [Commented] (QPID-6961) Use maven to generate Java Broker and (legacy) Java Client docbook

[ https://issues.apache.org/jira/browse/QPID-6961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115444#comment-15115444 ] ASF subversion and git services commented on QPID-6961: --- Commit 17266

Re: Review Request 42647: PROTON-1071: EventInjector hangs on Windows: add new interrupt primitives to selector and reactor

> On Jan. 25, 2016, 2:42 p.m., Gordon Sim wrote: > > proton-c/src/events/event.c, line 140 > > > > > > It would be worth a comment here explaining why PN_INTERRUPT is a > > special case. PN_REACTOR_INTERRUPT please

Re: Review Request 42647: PROTON-1071: EventInjector hangs on Windows: add new interrupt primitives to selector and reactor

> On Jan. 25, 2016, 2:42 p.m., Gordon Sim wrote: > > proton-c/bindings/python/cproton.i, line 447 > > > > > > 'async_notify' is a horrible name... is this in addition to or instead > > of on_interrupt? I'm ok with

[jira] [Commented] (QPID-6997) [Java Broker, BDBStore] HA JE Transaction commit might end up in NullPointerException when commit is invoked when majority is lost

[ https://issues.apache.org/jira/browse/QPID-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115378#comment-15115378 ] ASF subversion and git services commented on QPID-6997: --- Commit 17266

[jira] [Updated] (QPID-7021) BDB hot backup (takeBackupNoLock) may fail with IOException

[ https://issues.apache.org/jira/browse/QPID-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7021: - Assignee: Lorenz Quack (was: Keith Wall) > BDB hot backup (takeBackupNoLock) may fail with IOException > -

[jira] [Assigned] (QPID-7021) BDB hot backup (takeBackupNoLock) may fail with IOException

[ https://issues.apache.org/jira/browse/QPID-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned QPID-7021: Assignee: Keith Wall > BDB hot backup (takeBackupNoLock) may fail with IOException > ---

[jira] [Updated] (QPID-7021) BDB hot backup (takeBackupNoLock) may fail with IOException

[ https://issues.apache.org/jira/browse/QPID-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7021: - Description: The BDB hot backup script may fail with the following exception. The program is flawed in tha

[jira] [Updated] (QPID-7021) BDB hot backup (takeBackupNoLock) may fail with IOException

[ https://issues.apache.org/jira/browse/QPID-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7021: - Fix Version/s: qpid-java-6.0.1 > BDB hot backup (takeBackupNoLock) may fail with IOException >

[jira] [Updated] (QPID-7021) BDB hot backup (takeBackupNoLock) may fail with IOException

[ https://issues.apache.org/jira/browse/QPID-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7021: - Fix Version/s: qpid-java-6.1 > BDB hot backup (takeBackupNoLock) may fail with IOException > --

[jira] [Updated] (QPID-7021) BDB hot backup (takeBackupNoLock) may fail with IOException

[ https://issues.apache.org/jira/browse/QPID-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7021: - Status: Reviewable (was: In Progress) > BDB hot backup (takeBackupNoLock) may fail with IOException >

[jira] [Commented] (QPID-7021) BDB hot backup (takeBackupNoLock) may fail with IOException

[ https://issues.apache.org/jira/browse/QPID-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115388#comment-15115388 ] ASF subversion and git services commented on QPID-7021: --- Commit 17266

[jira] [Resolved] (QPID-7015) Add system test that ensure ability to login correctly with Scram-SHA based authentication providers

[ https://issues.apache.org/jira/browse/QPID-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorenz Quack resolved QPID-7015. Resolution: Fixed looks good > Add system test that ensure ability to login correctly with Scram-SHA

[jira] [Created] (QPID-7021) BDB hot backup (takeBackupNoLock) may fail with IOException

Keith Wall created QPID-7021: Summary: BDB hot backup (takeBackupNoLock) may fail with IOException Key: QPID-7021 URL: https://issues.apache.org/jira/browse/QPID-7021 Project: Qpid Issue Type: B

[jira] [Updated] (QPID-7021) BDB hot backup (takeBackupNoLock) may fail with IOException

[ https://issues.apache.org/jira/browse/QPID-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7021: - Description: The BDB hot backup script may fail with the following exception. The program is flawed in tha

Re: Review Request 42647: PROTON-1071: EventInjector hangs on Windows: add new interrupt primitives to selector and reactor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42647/#review116070 --- proton-c/bindings/python/cproton.i (line 409)

[jira] [Closed] (QPID-7017) Include Queue UUID in QUE-1001/1002 operational log message

[ https://issues.apache.org/jira/browse/QPID-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall closed QPID-7017. > Include Queue UUID in QUE-1001/1002 operational log message > -

[jira] [Resolved] (QPID-7009) BDD HA: DbPing call should have an independent timeout control

[ https://issues.apache.org/jira/browse/QPID-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorenz Quack resolved QPID-7009. Resolution: Fixed > BDD HA: DbPing call should have an independent timeout control >

Re: Review Request 42700: PROTON-1104 - move the deallocation and cleanup of the reactor's timer to pn_reactor_stop, do not close pipes until reactor is finalized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42700/#review116089 --- Ship it! Seems ok to me. - Gordon Sim On Jan. 24, 2016, 10:2

[jira] [Updated] (QPID-7015) Add system test that ensure ability to login correctly with Scram-SHA based authentication providers

[ https://issues.apache.org/jira/browse/QPID-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7015: - Status: Reviewable (was: In Progress) > Add system test that ensure ability to login correctly with Scram-

[jira] [Updated] (QPID-7015) Add system test that ensure ability to login correctly with Scram-SHA based authentication providers

[ https://issues.apache.org/jira/browse/QPID-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7015: - Fix Version/s: qpid-java-6.1 > Add system test that ensure ability to login correctly with Scram-SHA based

[jira] [Updated] (QPID-7015) Add system test that ensure ability to login correctly with Scram-SHA based authentication providers

[ https://issues.apache.org/jira/browse/QPID-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7015: - Assignee: Lorenz Quack (was: Keith Wall) > Add system test that ensure ability to login correctly with Scr

[jira] [Commented] (QPID-7015) Add system test that ensure ability to login correctly with Scram-SHA based authentication providers

[ https://issues.apache.org/jira/browse/QPID-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115221#comment-15115221 ] ASF subversion and git services commented on QPID-7015: --- Commit 17266

[jira] [Updated] (QPID-7015) Add system test that ensure ability to login correctly with Scram-SHA based authentication providers

[ https://issues.apache.org/jira/browse/QPID-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7015: - Priority: Minor (was: Major) > Add system test that ensure ability to login correctly with Scram-SHA based

[jira] [Assigned] (QPID-7015) Add system test that ensure ability to login correctly with Scram-SHA based authentication providers

[ https://issues.apache.org/jira/browse/QPID-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned QPID-7015: Assignee: Keith Wall > Add system test that ensure ability to login correctly with Scram-SHA based

[jira] [Commented] (QPID-7009) BDD HA: DbPing call should have an independent timeout control

[ https://issues.apache.org/jira/browse/QPID-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115220#comment-15115220 ] ASF subversion and git services commented on QPID-7009: --- Commit 17266

Re: Review Request 42700: PROTON-1104 - move the deallocation and cleanup of the reactor's timer to pn_reactor_stop, do not close pipes until reactor is finalized.

> On Jan. 25, 2016, 10:31 a.m., Gordon Sim wrote: > > Does the reactor still shut itself down when the last connection is removed? Yes - once there are no more open connections or scheduled tasks, pn_reactor_process() returns false. - Kenneth

[jira] [Commented] (QPID-7016) BDB JE cleaner can make no progress allowing for unbounded store growth

[ https://issues.apache.org/jira/browse/QPID-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115137#comment-15115137 ] ASF subversion and git services commented on QPID-7016: --- Commit 17266

[jira] [Commented] (QPID-6999) [Java Broker, BDBStore, HA] In replicated environment JE transactions aborted on committing can cause Broker shutdown

[ https://issues.apache.org/jira/browse/QPID-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115058#comment-15115058 ] ASF subversion and git services commented on QPID-6999: --- Commit 17266

[jira] [Resolved] (QPID-7017) Include Queue UUID in QUE-1001/1002 operational log message

[ https://issues.apache.org/jira/browse/QPID-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorenz Quack resolved QPID-7017. Resolution: Fixed > Include Queue UUID in QUE-1001/1002 operational log message > ---

[jira] [Commented] (QPID-7017) Include Queue UUID in QUE-1001/1002 operational log message

[ https://issues.apache.org/jira/browse/QPID-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115045#comment-15115045 ] ASF subversion and git services commented on QPID-7017: --- Commit 17266

[jira] [Commented] (QPID-7009) BDD HA: DbPing call should have an independent timeout control

[ https://issues.apache.org/jira/browse/QPID-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115017#comment-15115017 ] Lorenz Quack commented on QPID-7009: Changes look good. Not closing until backport is c

Re: Review Request 42700: PROTON-1104 - move the deallocation and cleanup of the reactor's timer to pn_reactor_stop, do not close pipes until reactor is finalized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42700/#review116069 --- Does the reactor still shut itself down when the last connection i

[jira] [Closed] (QPID-6993) [Java Broker] Improve security of SCRAM-* authentication managers by not storing the salted passwords

[ https://issues.apache.org/jira/browse/QPID-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall closed QPID-6993. > [Java Broker] Improve security of SCRAM-* authentication managers by not > storing the salted passwords >

[jira] [Updated] (QPID-6993) [Java Broker] Improve security of SCRAM-* authentication managers by not storing the salted passwords

[ https://issues.apache.org/jira/browse/QPID-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-6993: - Fix Version/s: qpid-java-6.0.1 > [Java Broker] Improve security of SCRAM-* authentication managers by not

[jira] [Comment Edited] (QPID-7017) Include Queue UUID in QUE-1001/1002 operational log message

[ https://issues.apache.org/jira/browse/QPID-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114995#comment-15114995 ] Lorenz Quack edited comment on QPID-7017 at 1/25/16 10:09 AM: --

[jira] [Commented] (QPID-7017) Include Queue UUID in QUE-1001/1002 operational log message

[ https://issues.apache.org/jira/browse/QPID-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114995#comment-15114995 ] Lorenz Quack commented on QPID-7017: Change looks good to me. For the record in the {{

[jira] [Commented] (DISPATCH-201) Initial release of management console

[ https://issues.apache.org/jira/browse/DISPATCH-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114960#comment-15114960 ] ASF subversion and git services commented on DISPATCH-201: -- Com

[jira] [Closed] (QPID-7007) Add the ability to mutate JE configuration properties at runtime

[ https://issues.apache.org/jira/browse/QPID-7007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall closed QPID-7007. > Add the ability to mutate JE configuration properties at runtime >

[jira] [Closed] (QPID-7006) Expose BDB JE cleanLog/checkpoint as an model operations of the BDBVH/BDBHAVHN

[ https://issues.apache.org/jira/browse/QPID-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall closed QPID-7006. > Expose BDB JE cleanLog/checkpoint as an model operations of the BDBVH/BDBHAVHN > --

[jira] [Resolved] (QPID-7006) Expose BDB JE cleanLog/checkpoint as an model operations of the BDBVH/BDBHAVHN

[ https://issues.apache.org/jira/browse/QPID-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved QPID-7006. -- Resolution: Fixed Changes look reasonable to me > Expose BDB JE cleanLog/checkpoint as an model operatio

[jira] [Updated] (QPID-7009) BDD HA: DbPing call should have an independent timeout control

[ https://issues.apache.org/jira/browse/QPID-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7009: - Assignee: Lorenz Quack (was: Alex Rudyy) > BDD HA: DbPing call should have an independent timeout control