[jira] [Commented] (PROTON-1622) Add coverage reporting to CMake build

2017-10-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217526#comment-16217526 ] ASF subversion and git services commented on PROTON-1622: - Commit

[jira] [Resolved] (DISPATCH-860) Link Route tests failing intermittently.

2017-10-24 Thread Ganesh Murthy (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-860. Resolution: Fixed > Link Route tests failing intermittently. >

[GitHub] qpid-dispatch pull request #213: Added delivery reference protrection from q...

2017-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/213 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-860) Link Route tests failing intermittently.

2017-10-24 Thread Ganesh Murthy (JIRA)
Ganesh Murthy created DISPATCH-860: -- Summary: Link Route tests failing intermittently. Key: DISPATCH-860 URL: https://issues.apache.org/jira/browse/DISPATCH-860 Project: Qpid Dispatch Issue

[jira] [Comment Edited] (QPID-7646) [Java Broker] fix AbstractAMQPSession#getLocalTransactionOpen to support values > 1

2017-10-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217167#comment-16217167 ] Keith Wall edited comment on QPID-7646 at 10/24/17 4:16 PM: I think it is

[jira] [Commented] (QPID-7646) [Java Broker] fix AbstractAMQPSession#getLocalTransactionOpen to support values > 1

2017-10-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217167#comment-16217167 ] Keith Wall commented on QPID-7646: -- I think it is useful to think first about the use-cases for the

[jira] [Comment Edited] (QPID-7646) [Java Broker] fix AbstractAMQPSession#getLocalTransactionOpen to support values > 1

2017-10-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217167#comment-16217167 ] Keith Wall edited comment on QPID-7646 at 10/24/17 4:15 PM: I think it is

[jira] [Updated] (QPID-7971) [Java Broker] [AMQP1.0] [AMQP0-9] Queue#ConsumerCountWithCredit statistic not decremented when consumer disconnects

2017-10-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7971: - Status: Reviewable (was: In Progress) > [Java Broker] [AMQP1.0] [AMQP0-9] Queue#ConsumerCountWithCredit

[jira] [Assigned] (QPID-7971) [Java Broker] [AMQP1.0] [AMQP0-9] Queue#ConsumerCountWithCredit statistic not decremented when consumer disconnects

2017-10-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned QPID-7971: Assignee: Keith Wall > [Java Broker] [AMQP1.0] [AMQP0-9] Queue#ConsumerCountWithCredit statistic

[jira] [Commented] (QPID-7832) Refactor store/protocol API using Collection

2017-10-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217160#comment-16217160 ] ASF subversion and git services commented on QPID-7832: --- Commit

[jira] [Commented] (PROTON-1176) Core dump if reactor creation fails

2017-10-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217143#comment-16217143 ] ASF subversion and git services commented on PROTON-1176: - Commit

[GitHub] qpid-proton pull request #:

2017-10-24 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/commit/da7f5056a45528196be6733fc56a1f41bda58ded#commitcomment-25161035 In tests/python/proton_tests/utils.py: In tests/python/proton_tests/utils.py on line 180: Thanks, that test is

[jira] [Commented] (QPID-7981) [Java Broker] [AMQP1.0] Handle erroneous null termini cases

2017-10-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216852#comment-16216852 ] Keith Wall commented on QPID-7981: -- Hi Rob, I agree with your ideas you put above with regard to desired

[GitHub] qpid-proton pull request #:

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on the pull request: https://github.com/apache/qpid-proton/commit/da7f5056a45528196be6733fc56a1f41bda58ded#commitcomment-25156357 In tests/python/proton_tests/utils.py: In tests/python/proton_tests/utils.py on line 180: this has to be `except

[jira] [Updated] (QPID-7981) [Java Broker] [AMQP1.0] Handle erroneous null termini cases

2017-10-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7981: - Description: Testing the Broker against Rhea's {{example/helloworld.js}} shows that the AMQP 1.0 protocol

[jira] [Updated] (QPID-7981) [Java Broker] [AMQP1.0] Handle erroneous null termini cases

2017-10-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7981: - Summary: [Java Broker] [AMQP1.0] Handle erroneous null termini cases (was: [Java Broker] [AMQP1.0]

[jira] [Updated] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread JIRA
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated PROTON-1651: --- Attachment: (was: idea_dictionary.xml) > Run spellchecker on proton-c code >

[jira] [Updated] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread JIRA
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated PROTON-1651: --- Attachment: idea_dictionary.xml > Run spellchecker on proton-c code >

[jira] [Commented] (QPID-7910) [Java Broker] Improve qpid.stop script

2017-10-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216794#comment-16216794 ] ASF subversion and git services commented on QPID-7910: --- Commit

[jira] [Commented] (QPID-7971) [Java Broker] [AMQP1.0] [AMQP0-9] Queue#ConsumerCountWithCredit statistic not decremented when consumer disconnects

2017-10-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216792#comment-16216792 ] ASF subversion and git services commented on QPID-7971: --- Commit

[jira] [Updated] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread JIRA
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated PROTON-1651: --- Attachment: idea_dictionary.xml Attached dictionary from IntelliJ, which I used for spellchecking. I

[jira] [Commented] (QPID-7986) [Qpid Broker-J] [AMQP0-10] Remove redundant casts left by collapse of ServerConnection/SessionSession etc

2017-10-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216793#comment-16216793 ] ASF subversion and git services commented on QPID-7986: --- Commit

[jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216788#comment-16216788 ] ASF GitHub Bot commented on PROTON-1651: Github user jdanekrh commented on a diff in the pull

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146539425 --- Diff: proton-c/bindings/cpp/src/messaging_adapter.cpp --- @@ -275,7 +275,7 @@ void on_transport_closed(messaging_handler& handler, pn_event_t*

[jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216787#comment-16216787 ] ASF GitHub Bot commented on PROTON-1651: Github user jdanekrh commented on the issue:

[GitHub] qpid-proton issue #127: PROTON-1651 Fix typos found by the spellchecker

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on the issue: https://github.com/apache/qpid-proton/pull/127 What is blech? > transport_consume(transport);// blech - testBindAfterOpen --- - To unsubscribe,

[jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216784#comment-16216784 ] ASF GitHub Bot commented on PROTON-1651: Github user jdanekrh commented on a diff in the pull

[jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216781#comment-16216781 ] ASF GitHub Bot commented on PROTON-1651: Github user jdanekrh commented on a diff in the pull

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146539063 --- Diff: tests/python/proton_tests/messenger.py --- @@ -629,7 +629,7 @@ def testDefaultRewriteSUHPN(self): def testDefaultRewriteSUPHPN(self):

[jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216776#comment-16216776 ] ASF GitHub Bot commented on PROTON-1651: Github user jdanekrh commented on a diff in the pull

[jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216780#comment-16216780 ] ASF GitHub Bot commented on PROTON-1651: Github user jdanekrh commented on a diff in the pull

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538990 --- Diff: tests/python/proton_tests/message.py --- @@ -69,7 +69,7 @@ def testPriority(self): def testTtl(self): self._test("ttl", 0,

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538930 --- Diff: proton-c/bindings/ruby/lib/reactor/container.rb --- @@ -155,7 +155,7 @@ def create_sender(context, opts = {})

[jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216778#comment-16216778 ] ASF GitHub Bot commented on PROTON-1651: Github user jdanekrh commented on a diff in the pull

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538833 --- Diff: proton-c/bindings/ruby/lib/handler/endpoint_state_handler.rb --- @@ -164,7 +164,7 @@ def on_link_error(event)

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538752 --- Diff: proton-c/bindings/ruby/lib/core/ssl.rb --- @@ -126,25 +126,25 @@ def cipher_name end # Returns the name of the SSL

[jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216775#comment-16216775 ] ASF GitHub Bot commented on PROTON-1651: Github user jdanekrh commented on a diff in the pull

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538680 --- Diff: proton-c/bindings/ruby/lib/core/connection.rb --- @@ -201,7 +201,7 @@ def remote_desired_capabilities # @return [Data] The remote

[jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216774#comment-16216774 ] ASF GitHub Bot commented on PROTON-1651: Github user jdanekrh commented on a diff in the pull

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538625 --- Diff: proton-c/bindings/javascript/module.js --- @@ -327,7 +327,7 @@ Module.EventDispatch = new function() { // Note the use of new to create a

[jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216773#comment-16216773 ] ASF GitHub Bot commented on PROTON-1651: Github user jdanekrh commented on a diff in the pull

[jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216772#comment-16216772 ] ASF GitHub Bot commented on PROTON-1651: Github user jdanekrh commented on a diff in the pull

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538458 --- Diff: proton-c/bindings/cpp/src/interop_test.cpp --- @@ -57,8 +57,8 @@ void test_data_ostream() { ASSERT_EQUAL("true, false, 42, 42, -42,

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/127#discussion_r146538275 --- Diff: examples/cpp/multithreaded_client.cpp --- @@ -47,7 +47,7 @@ #include #include -// Lock output from threads to avoid

[jira] [Commented] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216771#comment-16216771 ] ASF GitHub Bot commented on PROTON-1651: GitHub user jdanekrh opened a pull request:

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

2017-10-24 Thread jdanekrh
GitHub user jdanekrh opened a pull request: https://github.com/apache/qpid-proton/pull/127 PROTON-1651 Fix typos found by the spellchecker > injecter proton.Injecter * injector, maybe. this is public api, so probably should not be touched, though > Now that we've

[jira] [Created] (QPID-7986) [Qpid Broker-J] [AMQP0-10] Remove redundant casts left by collapse of ServerConnection/SessionSession etc

2017-10-24 Thread Keith Wall (JIRA)
Keith Wall created QPID-7986: Summary: [Qpid Broker-J] [AMQP0-10] Remove redundant casts left by collapse of ServerConnection/SessionSession etc Key: QPID-7986 URL: https://issues.apache.org/jira/browse/QPID-7986

[jira] [Updated] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread JIRA
[ https://issues.apache.org/jira/browse/PROTON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated PROTON-1651: --- Priority: Minor (was: Major) > Run spellchecker on proton-c code >

[jira] [Commented] (QPID-7971) [Java Broker] [AMQP1.0] [AMQP0-9] Queue#ConsumerCountWithCredit statistic not decremented when consumer disconnects

2017-10-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216601#comment-16216601 ] Keith Wall commented on QPID-7971: -- The 0-10 path is different because on session detach, the

[jira] [Updated] (QPID-7971) [Java Broker] [AMQP1.0] [AMQP0-9] Queue#ConsumerCountWithCredit statistic not decremented when consumer disconnects

2017-10-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7971: - Summary: [Java Broker] [AMQP1.0] [AMQP0-9] Queue#ConsumerCountWithCredit statistic not decremented when

[jira] [Created] (PROTON-1651) Run spellchecker on proton-c code

2017-10-24 Thread JIRA
Jiri Daněk created PROTON-1651: -- Summary: Run spellchecker on proton-c code Key: PROTON-1651 URL: https://issues.apache.org/jira/browse/PROTON-1651 Project: Qpid Proton Issue Type: Task