Re: Review Request 67139: treat attach after detach as new link

2018-05-15 Thread Gordon Sim
On 15/05/18 22:10, Alan Conway wrote: Having trouble loggingn into reviewboard I'm not sure if this is correct. If the link is not PN_LOCAL_CLOSED, then the application is well within its rights to close() it. I don't understand your point. This has no effect on what the application can do wi

Re: Review Request 67139: treat attach after detach as new link

2018-05-15 Thread Alan Conway
Having trouble loggingn into reviewboard I'm not sure if this is correct. If the link is not PN_LOCAL_CLOSED, then the application is well within its rights to close() it. If we have re-used it for another link that could close the wrong link. This would be the 3rd time we've changed this particu

[jira] [Updated] (PROTON-1845) treat attach received after detach as implying new link

2018-05-15 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated PROTON-1845: Component/s: proton-c > treat attach received after detach as implying new link >

[jira] [Updated] (PROTON-1845) treat attach received after detach as implying new link

2018-05-15 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated PROTON-1845: Fix Version/s: (was: proton-j-0.28.0) proton-c-0.23.0 > treat attach receive

[jira] [Updated] (PROTON-1845) [c] Treat attach received after detach as implying new link

2018-05-15 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated PROTON-1845: Summary: [c] Treat attach received after detach as implying new link (was: treat attach received

[jira] [Commented] (DISPATCH-994) segfault in qdr_link_second_attach

2018-05-15 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476363#comment-16476363 ] Gordon Sim commented on DISPATCH-994: - I think this is fixed by https://issues.apach

[jira] [Commented] (DISPATCH-997) reusing link name from link closed uncleanly on link routes no longer works

2018-05-15 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476362#comment-16476362 ] Gordon Sim commented on DISPATCH-997: - I think this is fixed by https://issues.apach

[jira] [Commented] (PROTON-1845) treat attach received after detach as implying new link

2018-05-15 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476351#comment-16476351 ] Gordon Sim commented on PROTON-1845: Suggested change: https://reviews.apache.org/r/6

Review Request 67139: treat attach after detach as new link

2018-05-15 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67139/ --- Review request for qpid, Alan Conway, Ganesh Murthy, Justin Ross, and Ted Ross.

[jira] [Updated] (QPID-8141) [JMS AMQP 0-x] Sending message to address based destinations that matches the address of a previously resolved address fails

2018-05-15 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-8141: - Summary: [JMS AMQP 0-x] Sending message to address based destinations that matches the address of a previou

[jira] [Updated] (QPID-8141) [JMS AMQP 0-x] Sending message to address based destinations that matches the address of a previously resolved address fails

2018-05-15 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-8141: - Description: Address based destination resolution functionality {{AMQSession#resolveAddress}} sets a numbe

[jira] [Created] (PROTON-1845) treat attach received after detach as implying new link

2018-05-15 Thread Gordon Sim (JIRA)
Gordon Sim created PROTON-1845: -- Summary: treat attach received after detach as implying new link Key: PROTON-1845 URL: https://issues.apache.org/jira/browse/PROTON-1845 Project: Qpid Proton Is

[jira] [Commented] (PROTON-1833) [cpp] Crash on Windows after calling container::stop()

2018-05-15 Thread Cliff Jansen (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476036#comment-16476036 ] Cliff Jansen commented on PROTON-1833: -- While I could not reproduce, it is plausible

[jira] [Closed] (DISPATCH-999) error querying large number of addresses with qdmanage

2018-05-15 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim closed DISPATCH-999. --- Resolution: Duplicate > error querying large number of addresses with qdmanage > ---

[jira] [Resolved] (PROTON-1844) Windows proactor memory corruption on cleanup

2018-05-15 Thread Cliff Jansen (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cliff Jansen resolved PROTON-1844. -- Resolution: Fixed > Windows proactor memory corruption on cleanup > ---

[jira] [Resolved] (PROTON-1514) [proton-c] When last frame of multi-frame transfer has settled=true, Proton still considers delivery as unsettled

2018-05-15 Thread Cliff Jansen (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cliff Jansen resolved PROTON-1514. -- Resolution: Fixed > [proton-c] When last frame of multi-frame transfer has settled=true, Proton

[GitHub] qpid-dispatch pull request #304: Dispatch 990 Use patterns for policy vhost ...

2018-05-15 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/304 Dispatch 990 Use patterns for policy vhost hostnames This adds all the code (schema, management, run time) and supporting self tests and old style doc. This does not add anything to doc/new

[jira] [Issue Comment Deleted] (QPID-8184) [linearstore] Recovery intermittently produces JERR_EFP_BADEFPDIRNAME error followed by core

2018-05-15 Thread Kim van der Riet (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kim van der Riet updated QPID-8184: --- Comment: was deleted (was: Commit from Kim van der Riet with incorrect tag QPIDIT-8184 instead

[jira] [Commented] (QPID-8184) [linearstore] Recovery intermittently produces JERR_EFP_BADEFPDIRNAME error followed by core

2018-05-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475883#comment-16475883 ] ASF subversion and git services commented on QPID-8184: --- Commit d4908

[jira] [Resolved] (QPID-8184) [linearstore] Recovery intermittently produces JERR_EFP_BADEFPDIRNAME error followed by core

2018-05-15 Thread Kim van der Riet (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kim van der Riet resolved QPID-8184. Resolution: Fixed > [linearstore] Recovery intermittently produces JERR_EFP_BADEFPDIRNAME err

[jira] [Commented] (QPID-8184) [linearstore] Recovery intermittently produces JERR_EFP_BADEFPDIRNAME error followed by core

2018-05-15 Thread Kim van der Riet (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475877#comment-16475877 ] Kim van der Riet commented on QPID-8184: Commit from Kim van der Riet with incorrec

[jira] [Updated] (QPID-8185) [JMS AMQP 0-x][AMQP 0-8..0-91] Make sure that client closes TCP connection on failure with sending connection.close and avoid spurious NPEs whilst awaiting channel closure

2018-05-15 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8185: - Issue Type: Bug (was: Improvement) > [JMS AMQP 0-x][AMQP 0-8..0-91] Make sure that client closes TCP conne

[GitHub] qpid-proton issue #143: NO-JIRA: [c] link fuzzing binaries using CXX linker

2018-05-15 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/qpid-proton/pull/143 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/143?src=pr&el=h1) Report > Merging [#143](https://codecov.io/gh/apache/qpid-proton/pull/143?src=pr&el=desc) into [master](https:

[GitHub] qpid-proton pull request #143: NO-JIRA: [c] link fuzzing binaries using CXX ...

2018-05-15 Thread jdanekrh
GitHub user jdanekrh opened a pull request: https://github.com/apache/qpid-proton/pull/143 NO-JIRA: [c] link fuzzing binaries using CXX linker This should allow for removal of patch file https://github.com/google/oss-fuzz/blob/1909d92b8bb068dd7aa94bdf22da4028ada385ea/projects/qpid-p

[jira] [Assigned] (QPID-8190) [JMS AMQP 0-x] Release Qpid JMS AMQP 0-x 6.3.1

2018-05-15 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-8190: Assignee: Alex Rudyy > [JMS AMQP 0-x] Release Qpid JMS AMQP 0-x 6.3.1 >

[jira] [Updated] (QPID-8139) [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or JMSCorrelationID expressed using the AMQP type encoded form values fail to select target message

2018-05-15 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8139: - Description: When using the Qpid JMS AMQP 1.0 Client with Broker-J, if the consumer specifies a JMS messag

[jira] [Updated] (QPID-8139) [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or JMSCorrelationID expressed using the AMQP type encoded form values fail to select target message

2018-05-15 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8139: - Attachment: 0001-QPID-8139-Broker-J-AMQP-1.0-Make-sure-that-selector-.patch > [Broker-J] [AMQP1-0] [JMSBIND

[jira] [Updated] (QPID-8139) [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or JMSCorrelationID expressed using the AMQP type encoded form values fail to select target message

2018-05-15 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8139: - Attachment: (was: 0001-QPID-8139-Broker-J-AMQP-1.0-Make-sure-that-selector-.patch) > [Broker-J] [AMQP1

[jira] [Updated] (QPID-8139) [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or JMSCorrelationID expressed using the AMQP type encoded form values fail to select target message

2018-05-15 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8139: - Attachment: (was: 0002-QPID-8139-Broker-J-AMQP-1.0-Summport-all-message-for.patch) > [Broker-J] [AMQP1

[jira] [Commented] (QPID-8139) [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or JMSCorrelationID expressed using the AMQP type encoded form values fail to select target message

2018-05-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475449#comment-16475449 ] ASF subversion and git services commented on QPID-8139: --- Commit f7d3e

[jira] [Commented] (QPID-8167) [Broker-J] Broker command line option '-mmqv/--management-mode-quiesce-virtualhosts' does not quiesce virtual hosts

2018-05-15 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475444#comment-16475444 ] Keith Wall commented on QPID-8167: -- Changes reviewed.  Documentation corrected. > [Broker

[jira] [Updated] (QPID-8167) [Broker-J] Broker command line option '-mmqv/--management-mode-quiesce-virtualhosts' does not quiesce virtual hosts

2018-05-15 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-8167: - Priority: Minor (was: Major) > [Broker-J] Broker command line option > '-mmqv/--management-mode-quiesce-v

[jira] [Updated] (QPID-8167) [Broker-J] Broker command line option '-mmqv/--management-mode-quiesce-virtualhosts' does not quiesce virtual hosts

2018-05-15 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-8167: - Fix Version/s: qpid-java-broker-7.1 > [Broker-J] Broker command line option > '-mmqv/--management-mode-qui

[jira] [Resolved] (QPID-8167) [Broker-J] Broker command line option '-mmqv/--management-mode-quiesce-virtualhosts' does not quiesce virtual hosts

2018-05-15 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved QPID-8167. -- Resolution: Fixed > [Broker-J] Broker command line option > '-mmqv/--management-mode-quiesce-virtualhost

[jira] [Commented] (QPID-8139) [Broker-J] [AMQP1-0] [JMSBINDMAP] JMS selectors using JMSMessageID or JMSCorrelationID expressed using the AMQP type encoded form values fail to select target message

2018-05-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475434#comment-16475434 ] ASF subversion and git services commented on QPID-8139: --- Commit 86b31

[jira] [Commented] (QPID-8167) [Broker-J] Broker command line option '-mmqv/--management-mode-quiesce-virtualhosts' does not quiesce virtual hosts

2018-05-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475435#comment-16475435 ] ASF subversion and git services commented on QPID-8167: --- Commit 2d85f

[jira] [Updated] (QPID-8172) [Broker-J] OAuth2 authentication provider should not mandate setting of client secret

2018-05-15 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-8172: - Affects Version/s: qpid-java-6.0 qpid-java-6.1 > [Broker-J] OAuth2 authentication pr

[jira] [Updated] (QPID-8172) [Broker-J] OAuth2 authentication provider should not mandate setting of client secret

2018-05-15 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-8172: - Fix Version/s: qpid-java-broker-7.1.0 > [Broker-J] OAuth2 authentication provider should not mandate settin

[jira] [Resolved] (QPID-8172) [Broker-J] OAuth2 authentication provider should not mandate setting of client secret

2018-05-15 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved QPID-8172. -- Resolution: Fixed > [Broker-J] OAuth2 authentication provider should not mandate setting of > client sec

[jira] [Commented] (QPID-8172) [Broker-J] OAuth2 authentication provider should not mandate setting of client secret

2018-05-15 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475424#comment-16475424 ] Keith Wall commented on QPID-8172: -- Changes look reasonable to me. > [Broker-J] OAuth2 au