[jira] [Created] (DISPATCH-1611) In debug mode, provide time and backtrace of leaked pool allocations

2020-03-27 Thread Ted Ross (Jira)
Ted Ross created DISPATCH-1611: -- Summary: In debug mode, provide time and backtrace of leaked pool allocations Key: DISPATCH-1611 URL: https://issues.apache.org/jira/browse/DISPATCH-1611 Project: Qpid Di

[jira] [Commented] (PROTON-2158) Add 'Automatic-Module-Name' to MANIFEST.MF to support Java 9+ modules

2020-03-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068968#comment-17068968 ] ASF GitHub Bot commented on PROTON-2158: gemmellr commented on issue #37: PROTON

[GitHub] [qpid-proton-j] gemmellr commented on issue #37: PROTON-2158 Adding automatic module name entry.

2020-03-27 Thread GitBox
gemmellr commented on issue #37: PROTON-2158 Adding automatic module name entry. URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-605201737 I had a look, and the module name addition itself seems fine, but I want to look into some odd behaviour around other manifest entries

[GitHub] [qpid-dispatch] ChugR commented on issue #711: Added debug-dump backtrace for leaked objects in pooled memory.

2020-03-27 Thread GitBox
ChugR commented on issue #711: Added debug-dump backtrace for leaked objects in pooled memory. URL: https://github.com/apache/qpid-dispatch/pull/711#issuecomment-605177820 It would also be valuable to have a timestamp on the allocation. Then it could be correlated with the log file accurat

[jira] [Commented] (DISPATCH-1585) Allow specifying address/source/target to be used for a multitenant listener

2020-03-27 Thread Ted Ross (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068927#comment-17068927 ] Ted Ross commented on DISPATCH-1585: Could you provide a concrete example of how t

[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #711: Added debug-dump backtrace for leaked objects in pooled memory.

2020-03-27 Thread GitBox
ted-ross commented on a change in pull request #711: Added debug-dump backtrace for leaked objects in pooled memory. URL: https://github.com/apache/qpid-dispatch/pull/711#discussion_r399406070 ## File path: src/alloc_pool.c ## @@ -501,11 +537,25 @@ void qd_alloc_finalize(v

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #711: Added debug-dump backtrace for leaked objects in pooled memory.

2020-03-27 Thread GitBox
kgiusti commented on a change in pull request #711: Added debug-dump backtrace for leaked objects in pooled memory. URL: https://github.com/apache/qpid-dispatch/pull/711#discussion_r399404250 ## File path: src/alloc_pool.c ## @@ -501,11 +537,25 @@ void qd_alloc_finalize(vo

[GitHub] [qpid-proton-j] franz1981 commented on issue #36: PROTON-2178 Implement efficient search of encoded Symbol on ReadableBuffer

2020-03-27 Thread GitBox
franz1981 commented on issue #36: PROTON-2178 Implement efficient search of encoded Symbol on ReadableBuffer URL: https://github.com/apache/qpid-proton-j/pull/36#issuecomment-605095230 Hi @gemmellr I can close this and sorry to have made you to review this: I've included this general purpo

[jira] [Commented] (PROTON-2178) Implement efficient search of encoded Symbol on ReadableBuffer

2020-03-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068854#comment-17068854 ] ASF GitHub Bot commented on PROTON-2178: franz1981 commented on issue #36: PROTO

[jira] [Commented] (PROTON-2178) Implement efficient search of encoded Symbol on ReadableBuffer

2020-03-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068855#comment-17068855 ] ASF GitHub Bot commented on PROTON-2178: franz1981 commented on pull request #36

[GitHub] [qpid-proton-j] franz1981 closed pull request #36: PROTON-2178 Implement efficient search of encoded Symbol on ReadableBuffer

2020-03-27 Thread GitBox
franz1981 closed pull request #36: PROTON-2178 Implement efficient search of encoded Symbol on ReadableBuffer URL: https://github.com/apache/qpid-proton-j/pull/36 This is an automated message from the Apache Git Service. To

[jira] [Commented] (PROTON-2178) Implement efficient search of encoded Symbol on ReadableBuffer

2020-03-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068847#comment-17068847 ] ASF GitHub Bot commented on PROTON-2178: gemmellr commented on pull request #36:

[GitHub] [qpid-proton-j] gemmellr commented on a change in pull request #36: PROTON-2178 Implement efficient search of encoded Symbol on ReadableBuffer

2020-03-27 Thread GitBox
gemmellr commented on a change in pull request #36: PROTON-2178 Implement efficient search of encoded Symbol on ReadableBuffer URL: https://github.com/apache/qpid-proton-j/pull/36#discussion_r379357315 ## File path: proton-j/src/main/java/org/apache/qpid/proton/amqp/Symbol.java ###

[jira] [Commented] (PROTON-2178) Implement efficient search of encoded Symbol on ReadableBuffer

2020-03-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068849#comment-17068849 ] ASF GitHub Bot commented on PROTON-2178: gemmellr commented on pull request #36:

[GitHub] [qpid-proton-j] gemmellr commented on a change in pull request #36: PROTON-2178 Implement efficient search of encoded Symbol on ReadableBuffer

2020-03-27 Thread GitBox
gemmellr commented on a change in pull request #36: PROTON-2178 Implement efficient search of encoded Symbol on ReadableBuffer URL: https://github.com/apache/qpid-proton-j/pull/36#discussion_r399378171 ## File path: proton-j/src/main/java/org/apache/qpid/proton/amqp/Symbol.java ###

[jira] [Commented] (PROTON-2178) Implement efficient search of encoded Symbol on ReadableBuffer

2020-03-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068846#comment-17068846 ] ASF GitHub Bot commented on PROTON-2178: gemmellr commented on pull request #36:

[GitHub] [qpid-proton-j] gemmellr commented on a change in pull request #36: PROTON-2178 Implement efficient search of encoded Symbol on ReadableBuffer

2020-03-27 Thread GitBox
gemmellr commented on a change in pull request #36: PROTON-2178 Implement efficient search of encoded Symbol on ReadableBuffer URL: https://github.com/apache/qpid-proton-j/pull/36#discussion_r379357759 ## File path: proton-j/src/main/java/org/apache/qpid/proton/amqp/Symbol.java ###

[jira] [Commented] (PROTON-2178) Implement efficient search of encoded Symbol on ReadableBuffer

2020-03-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068848#comment-17068848 ] ASF GitHub Bot commented on PROTON-2178: gemmellr commented on pull request #36:

[GitHub] [qpid-proton-j] gemmellr commented on a change in pull request #36: PROTON-2178 Implement efficient search of encoded Symbol on ReadableBuffer

2020-03-27 Thread GitBox
gemmellr commented on a change in pull request #36: PROTON-2178 Implement efficient search of encoded Symbol on ReadableBuffer URL: https://github.com/apache/qpid-proton-j/pull/36#discussion_r399379661 ## File path: proton-j/src/main/java/org/apache/qpid/proton/amqp/Symbol.java ###

[GitHub] [qpid-dispatch] ted-ross opened a new pull request #711: Added debug-dump backtrace for leaked objects in pooled memory.

2020-03-27 Thread GitBox
ted-ross opened a new pull request #711: Added debug-dump backtrace for leaked objects in pooled memory. URL: https://github.com/apache/qpid-dispatch/pull/711 If QD_MEMORY_DEBUG is defined, this stores a backtrace for each allocated pool object so that objects left unfreed can be better de

[jira] [Commented] (PROTON-2187) Python client leak on early Connection.close

2020-03-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068812#comment-17068812 ] ASF GitHub Bot commented on PROTON-2187: cliffjansen commented on pull request #

[GitHub] [qpid-proton] cliffjansen opened a new pull request #236: PROTON-2187: Python client: connection cleanup on close while still c…

2020-03-27 Thread GitBox
cliffjansen opened a new pull request #236: PROTON-2187: Python client: connection cleanup on close while still c… URL: https://github.com/apache/qpid-proton/pull/236 Proposed fix: Check if the close operation precedes the TCP handshake completion, and reproduce the missing cleanup steps.

[jira] [Resolved] (DISPATCH-1610) qd_pn_free_link_session_t objects leaking when connections are socket closed

2020-03-27 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1610. - Fix Version/s: 1.12.0 Resolution: Fixed > qd_pn_free_link_session_t objects lea

[jira] [Commented] (DISPATCH-1610) qd_pn_free_link_session_t objects leaking when connections are socket closed

2020-03-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068786#comment-17068786 ] ASF subversion and git services commented on DISPATCH-1610: ---

[jira] [Commented] (DISPATCH-1610) qd_pn_free_link_session_t objects leaking when connections are socket closed

2020-03-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068787#comment-17068787 ] ASF GitHub Bot commented on DISPATCH-1610: -- asfgit commented on pull request

[GitHub] [qpid-dispatch] asfgit closed pull request #710: DISPATCH-1610 - Added call to qd_conn_event_batch_complete() if a PN_…

2020-03-27 Thread GitBox
asfgit closed pull request #710: DISPATCH-1610 - Added call to qd_conn_event_batch_complete() if a PN_… URL: https://github.com/apache/qpid-dispatch/pull/710 This is an automated message from the Apache Git Service. To respo

[GitHub] [qpid-proton] d98762625 commented on a change in pull request #235: [go] Add ability to set capability on the terminus struct

2020-03-27 Thread GitBox
d98762625 commented on a change in pull request #235: [go] Add ability to set capability on the terminus struct URL: https://github.com/apache/qpid-proton/pull/235#discussion_r399247806 ## File path: go/pkg/amqp/url_test.go ## @@ -32,13 +32,6 @@ func ExampleParseURL() {

[GitHub] [qpid-proton] d98762625 opened a new pull request #235: [go] Add ability to set capability on the terminus struct

2020-03-27 Thread GitBox
d98762625 opened a new pull request #235: [go] Add ability to set capability on the terminus struct URL: https://github.com/apache/qpid-proton/pull/235 We found that we needed to be able to set capabilities on the terminus struct, otherwise we couldn't share queues. This PR adds a g

[GitHub] [qpid-proton] d98762625 commented on a change in pull request #231: WIP: Fix memory leak in go message unmarshal

2020-03-27 Thread GitBox
d98762625 commented on a change in pull request #231: WIP: Fix memory leak in go message unmarshal URL: https://github.com/apache/qpid-proton/pull/231#discussion_r399231376 ## File path: go/pkg/amqp/url_test.go ## @@ -32,8 +32,9 @@ func ExampleParseURL() {

[GitHub] [qpid-proton] alanconway commented on issue #231: WIP: Fix memory leak in go message unmarshal

2020-03-27 Thread GitBox
alanconway commented on issue #231: WIP: Fix memory leak in go message unmarshal URL: https://github.com/apache/qpid-proton/pull/231#issuecomment-604972519 /lgtm This is an automated message from the Apache Git Service. To

[GitHub] [qpid-proton] alanconway commented on a change in pull request #231: WIP: Fix memory leak in go message unmarshal

2020-03-27 Thread GitBox
alanconway commented on a change in pull request #231: WIP: Fix memory leak in go message unmarshal URL: https://github.com/apache/qpid-proton/pull/231#discussion_r399227856 ## File path: go/pkg/amqp/url_test.go ## @@ -32,8 +32,9 @@ func ExampleParseURL() {

[GitHub] [qpid-proton] d98762625 opened a new pull request #234: WIP: Add dynamic node properties

2020-03-27 Thread GitBox
d98762625 opened a new pull request #234: WIP: Add dynamic node properties URL: https://github.com/apache/qpid-proton/pull/234 This allows us to use the dynamic node properties of the terminus. This is an automated message fro

[GitHub] [qpid-proton] d98762625 closed pull request #232: WIP: update incorrect variable lengths in proton generator code

2020-03-27 Thread GitBox
d98762625 closed pull request #232: WIP: update incorrect variable lengths in proton generator code URL: https://github.com/apache/qpid-proton/pull/232 This is an automated message from the Apache Git Service. To respond to

[GitHub] [qpid-proton] d98762625 opened a new pull request #233: Fix variable lengths in go wrapper for proton

2020-03-27 Thread GitBox
d98762625 opened a new pull request #233: Fix variable lengths in go wrapper for proton URL: https://github.com/apache/qpid-proton/pull/233 The mappings from C types to Go types are incorrect in the latest generated wrapper for proton. This PR fixes that issue. I made this change o