[GitHub] [qpid-dispatch] codecov-io commented on pull request #1052: DISPATCH-1962 Fix leak of IoAdapter_init

2021-02-20 Thread GitBox
codecov-io commented on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-782762950 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr&el=h1) Report > Merging [#1052](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr&

[jira] [Commented] (DISPATCH-1962) Make LSan suppressions more targeted and specific (within reason)

2021-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287822#comment-17287822 ] ASF GitHub Bot commented on DISPATCH-1962: -- codecov-io commented on pull requ

[jira] [Commented] (DISPATCH-1962) Make LSan suppressions more targeted and specific (within reason)

2021-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287815#comment-17287815 ] ASF GitHub Bot commented on DISPATCH-1962: -- jiridanek opened a new pull reque

[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1052: DISPATCH-1962 Fix leak of IoAdapter_init

2021-02-20 Thread GitBox
jiridanek opened a new pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052 This PR depends on PRs to fix leaks in `qdr_subscription_t` (https://github.com/apache/qpid-dispatch/pull/1051) and `qdr_core_t` (https://github.com/apache/qpid-dispatch/pull/1049). The former

[jira] [Commented] (DISPATCH-1962) Make LSan suppressions more targeted and specific (within reason)

2021-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287808#comment-17287808 ] ASF GitHub Bot commented on DISPATCH-1962: -- codecov-io commented on pull requ

[GitHub] [qpid-dispatch] codecov-io commented on pull request #1051: DISPATCH-1962 Fix leak of qdr_core_subscribe

2021-02-20 Thread GitBox
codecov-io commented on pull request #1051: URL: https://github.com/apache/qpid-dispatch/pull/1051#issuecomment-782757013 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1051?src=pr&el=h1) Report > Merging [#1051](https://codecov.io/gh/apache/qpid-dispatch/pull/1051?src=pr&

[jira] [Commented] (DISPATCH-1962) Make LSan suppressions more targeted and specific (within reason)

2021-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287804#comment-17287804 ] ASF GitHub Bot commented on DISPATCH-1962: -- jiridanek opened a new pull reque

[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1051: DISPATCH-1962 Fix leak of qdr_core_subscribe

2021-02-20 Thread GitBox
jiridanek opened a new pull request #1051: URL: https://github.com/apache/qpid-dispatch/pull/1051 This PR is simply to show that "a solution exists". I have no idea whether I am on the right track here, or not. The original problem is ``` 14: 2021-02-20 20:54:08.332325 +010

[jira] [Commented] (DISPATCH-1962) Make LSan suppressions more targeted and specific (within reason)

2021-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287790#comment-17287790 ] ASF GitHub Bot commented on DISPATCH-1962: -- codecov-io commented on pull requ

[GitHub] [qpid-dispatch] codecov-io commented on pull request #1049: DISPATCH-1962 Fix qdr_core_t leak in run_unit_tests.c

2021-02-20 Thread GitBox
codecov-io commented on pull request #1049: URL: https://github.com/apache/qpid-dispatch/pull/1049#issuecomment-782744008 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1049?src=pr&el=h1) Report > Merging [#1049](https://codecov.io/gh/apache/qpid-dispatch/pull/1049?src=pr&

[jira] [Commented] (DISPATCH-1844) sys_mutex leak detected by LeakSanitizer ASAN (shutdown)

2021-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287788#comment-17287788 ] ASF GitHub Bot commented on DISPATCH-1844: -- jiridanek opened a new pull reque

[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1050: DISPATCH-1844 Leak of sys_mutex

2021-02-20 Thread GitBox
jiridanek opened a new pull request #1050: URL: https://github.com/apache/qpid-dispatch/pull/1050 ``` 69: ../src/router_core/core_link_endpoint.c:124:24: runtime error: store to misaligned address 0x616000147d9c for type 'uint64_t', which requires 8 byte alignment 69: 0x616000147d9c:

[jira] [Commented] (DISPATCH-1962) Make LSan suppressions more targeted and specific (within reason)

2021-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287785#comment-17287785 ] ASF GitHub Bot commented on DISPATCH-1962: -- jiridanek opened a new pull reque

[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1049: DISPATCH-1962 Fix qdr_core_t leak in run_unit_tests.c

2021-02-20 Thread GitBox
jiridanek opened a new pull request #1049: URL: https://github.com/apache/qpid-dispatch/pull/1049 As explained on the Jira, suppressing all leaks from unittests is kind of silly, because it can hide leaks in production code which would be otherwise easy to diagnose, if unittests could reve

[jira] [Commented] (DISPATCH-1942) Use modern idiomatic cmake 3.x

2021-02-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287780#comment-17287780 ] ASF subversion and git services commented on DISPATCH-1942: ---

[jira] [Commented] (DISPATCH-1942) Use modern idiomatic cmake 3.x

2021-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287778#comment-17287778 ] ASF GitHub Bot commented on DISPATCH-1942: -- jiridanek commented on pull reque

[GitHub] [qpid-dispatch] jiridanek merged pull request #1011: DISPATCH-1942 Use findPython when on CMake3.15+

2021-02-20 Thread GitBox
jiridanek merged pull request #1011: URL: https://github.com/apache/qpid-dispatch/pull/1011 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Commented] (DISPATCH-1942) Use modern idiomatic cmake 3.x

2021-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287779#comment-17287779 ] ASF GitHub Bot commented on DISPATCH-1942: -- jiridanek merged pull request #10

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1011: DISPATCH-1942 Use findPython when on CMake3.15+

2021-02-20 Thread GitBox
jiridanek commented on pull request #1011: URL: https://github.com/apache/qpid-dispatch/pull/1011#issuecomment-782737959 CI issue on Ubuntu is a known crash https://issues.apache.org/jira/browse/DISPATCH-1753 system_tests_policy_oversize_basic timeouted with Error in `qdrouterd': free():

[jira] [Commented] (DISPATCH-1965) Dispatch does not compile with gcc 10 when -Og is used

2021-02-20 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1728#comment-1728 ] Jiri Daněk commented on DISPATCH-1965: -- This might be possibly related to DISPATC

[jira] [Updated] (DISPATCH-1753) system_tests_policy_oversize_basic timeouted with Error in `qdrouterd': free(): invalid pointer

2021-02-20 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-1753: - Affects Version/s: 1.15.0 > system_tests_policy_oversize_basic timeouted with Error in `qdrout

[jira] [Commented] (DISPATCH-1753) system_tests_policy_oversize_basic timeouted with Error in `qdrouterd': free(): invalid pointer

2021-02-20 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287772#comment-17287772 ] Jiri Daněk commented on DISPATCH-1753: -- Here's it again, https://travis-ci.com/g

[jira] [Commented] (DISPATCH-1942) Use modern idiomatic cmake 3.x

2021-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287738#comment-17287738 ] ASF GitHub Bot commented on DISPATCH-1942: -- codecov-io edited a comment on pu

[GitHub] [qpid-dispatch] codecov-io edited a comment on pull request #1011: DISPATCH-1942 Use findPython when on CMake3.15+

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #1011: URL: https://github.com/apache/qpid-dispatch/pull/1011#issuecomment-770911588 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=h1) Report > Merging [#1011](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?

[jira] [Commented] (DISPATCH-1941) Crash in HTTP1 adaptor: member access within null pointer of type 'const struct qd_buffer_t'

2021-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287733#comment-17287733 ] ASF GitHub Bot commented on DISPATCH-1941: -- jiridanek commented on pull reque

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1010: DISPATCH-1941 DO-NOT-MERGE Crashing test for HTTP1

2021-02-20 Thread GitBox
jiridanek commented on pull request #1010: URL: https://github.com/apache/qpid-dispatch/pull/1010#issuecomment-782711129 @kgiusti The test is passing now (except for Travis where there is older Python which does not support listen() without parameters). I'll close the PR.

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1032: Make lsan suppressions more specific and fix revealed leaks

2021-02-20 Thread GitBox
jiridanek commented on pull request #1032: URL: https://github.com/apache/qpid-dispatch/pull/1032#issuecomment-782708078 Superseded by #1048 and other PRs still waiting to be proposed. I'll leave this open for a while longer, until the other PRs get processed.

[jira] [Commented] (DISPATCH-1962) Make LSan suppressions more targeted and specific (within reason)

2021-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287731#comment-17287731 ] ASF GitHub Bot commented on DISPATCH-1962: -- jiridanek opened a new pull reque

[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1048: DISPATCH-1962 Make LSan suppressions more targeted and specific

2021-02-20 Thread GitBox
jiridanek opened a new pull request #1048: URL: https://github.com/apache/qpid-dispatch/pull/1048 This introduces build option -DSANITIZE_3RD_PARTY, defaulted to OFF. The reason is that targeted suppressions only work when the .so libraries are installed with debug symbols, which is not al

[jira] [Updated] (DISPATCH-1962) Make LSan suppressions more targeted and specific (within reason)

2021-02-20 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-1962: - Summary: Make LSan suppressions more targeted and specific (within reason) (was: Make LSan su

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2021-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287694#comment-17287694 ] ASF GitHub Bot commented on PROTON-2322: jiridanek merged pull request #289: URL

[jira] [Commented] (PROTON-2320) Apply autofixes to resolve some flake8 code formatting issues

2021-02-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287693#comment-17287693 ] ASF subversion and git services commented on PROTON-2320: - Commi

[GitHub] [qpid-proton] jiridanek merged pull request #289: PROTON-2322 Fix various flake8 warnings (manual changes)

2021-02-20 Thread GitBox
jiridanek merged pull request #289: URL: https://github.com/apache/qpid-proton/pull/289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2021-02-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287692#comment-17287692 ] ASF subversion and git services commented on PROTON-2322: - Commi