[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324755#comment-17324755 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324752#comment-17324752 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-18 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615581743 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,132 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-18 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615585457 ## File path: cpp/src/delivery.cpp ## @@ -40,6 +42,7 @@ namespace proton { delivery::delivery(pn_delivery_t* d): transfer(make_wrapper(d)) {} rece

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324747#comment-17324747 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-18 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615583669 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,115 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324746#comment-17324746 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-18 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615583489 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,115 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324743#comment-17324743 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-18 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615578902 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,132 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324631#comment-17324631 ] ASF GitHub Bot commented on DISPATCH-1878: -- ChugR commented on a change in pu

[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-18 Thread GitBox
ChugR commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615490965 ## File path: src/adaptors/tcp_adaptor.c ## @@ -1257,13 +1489,17 @@ static void qdr_tcp_delivery_update(void *context, qdr_delivery_t *dlv, uint64_t

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324612#comment-17324612 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pul

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-18 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615458277 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,115 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324610#comment-17324610 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pul

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-18 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615455343 ## File path: cpp/src/sender.cpp ## @@ -64,10 +64,18 @@ namespace { uint64_t tag_counter = 0; Review comment: Should I file the bug for this

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324609#comment-17324609 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pul

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-18 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615455111 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,115 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-18 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615454611 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,115 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324606#comment-17324606 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pul

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1136: NO-JIRA-YET Run Travis job on IBM/z

2021-04-18 Thread GitBox
jiridanek commented on pull request #1136: URL: https://github.com/apache/qpid-dispatch/pull/1136#issuecomment-822039387 I am not sure this is useful. The IBM/z is running Ubuntu (Focal, Xenial failed to install Python packages). LeakSanitizer does not work on the platform. https://t

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1136: Jd 2021 04 17 try ibmz travis

2021-04-18 Thread GitBox
codecov-commenter commented on pull request #1136: URL: https://github.com/apache/qpid-dispatch/pull/1136#issuecomment-821977245 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1136?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1136: Jd 2021 04 17 try ibmz travis

2021-04-18 Thread GitBox
jiridanek opened a new pull request #1136: URL: https://github.com/apache/qpid-dispatch/pull/1136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[jira] [Resolved] (DISPATCH-1969) Create CI job that renders Dispatch documentation

2021-04-18 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk resolved DISPATCH-1969. -- Resolution: Fixed > Create CI job that renders Dispatch documentation >

[jira] [Updated] (DISPATCH-1969) Create CI job that renders Dispatch documentation

2021-04-18 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-1969: - Status: Reviewable (was: In Progress) > Create CI job that renders Dispatch documentation > -

[jira] [Updated] (DISPATCH-2059) Support running router under rr during test execution

2021-04-18 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-2059: - Description: Dispatch has env variable {{QPID_DISPATCH_RUNNER}} which is (according to commen

[jira] [Commented] (DISPATCH-1959) Update PatternFly packages for the 1.16.0 release

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324450#comment-17324450 ] ASF GitHub Bot commented on DISPATCH-1959: -- codecov-commenter commented on pu

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1133: DISPATCH-1959 Update PatternFly packages for the 1.16.0 release

2021-04-18 Thread GitBox
codecov-commenter commented on pull request #1133: URL: https://github.com/apache/qpid-dispatch/pull/1133#issuecomment-821954029 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[jira] [Commented] (DISPATCH-836) Source file organization suffers from include hell

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324438#comment-17324438 ] ASF GitHub Bot commented on DISPATCH-836: - jiridanek merged pull request #:

[jira] [Commented] (DISPATCH-836) Source file organization suffers from include hell

2021-04-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324437#comment-17324437 ] ASF subversion and git services commented on DISPATCH-836: -- Co

[GitHub] [qpid-dispatch] jiridanek merged pull request #1111: DISPATCH-836 Remove unused #include s

2021-04-18 Thread GitBox
jiridanek merged pull request #: URL: https://github.com/apache/qpid-dispatch/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[jira] [Commented] (DISPATCH-2039) Memory pool should be manually poisoned so that ASAN works with it

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324434#comment-17324434 ] ASF GitHub Bot commented on DISPATCH-2039: -- jiridanek commented on a change i

[jira] [Commented] (DISPATCH-2039) Memory pool should be manually poisoned so that ASAN works with it

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324433#comment-17324433 ] ASF GitHub Bot commented on DISPATCH-2039: -- jiridanek commented on a change i

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1135: DISPATCH-2039 WIP Instead of poison, set zero capacity of the pool and let it degenerate into immediate malloc/free

2021-04-18 Thread GitBox
jiridanek commented on a change in pull request #1135: URL: https://github.com/apache/qpid-dispatch/pull/1135#discussion_r615353315 ## File path: src/alloc_pool.c ## @@ -495,7 +498,7 @@ void qd_dealloc(qd_alloc_type_desc_t *desc, qd_alloc_pool_t **tpool, char *p) // If th

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1135: DISPATCH-2039 WIP Instead of poison, set zero capacity of the pool and let it degenerate into immediate malloc/free

2021-04-18 Thread GitBox
jiridanek commented on a change in pull request #1135: URL: https://github.com/apache/qpid-dispatch/pull/1135#discussion_r615353256 ## File path: src/alloc_pool.c ## @@ -280,11 +282,12 @@ static void qd_alloc_init(qd_alloc_type_desc_t *desc) if (desc->additional_size)

[jira] [Commented] (DISPATCH-2039) Memory pool should be manually poisoned so that ASAN works with it

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324432#comment-17324432 ] ASF GitHub Bot commented on DISPATCH-2039: -- jiridanek commented on a change i

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1135: DISPATCH-2039 WIP Instead of poison, set zero capacity of the pool and let it degenerate into immediate malloc/free

2021-04-18 Thread GitBox
jiridanek commented on a change in pull request #1135: URL: https://github.com/apache/qpid-dispatch/pull/1135#discussion_r615353187 ## File path: src/alloc_pool.c ## @@ -280,11 +282,12 @@ static void qd_alloc_init(qd_alloc_type_desc_t *desc) if (desc->additional_size)

[jira] [Commented] (DISPATCH-2039) Memory pool should be manually poisoned so that ASAN works with it

2021-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324431#comment-17324431 ] ASF GitHub Bot commented on DISPATCH-2039: -- jiridanek opened a new pull reque