[jira] [Commented] (DISPATCH-2108) TCP adaptor should aggregate statistics for listener and connector

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357619#comment-17357619 ] ASF GitHub Bot commented on DISPATCH-2108: -- ChugR opened a new pull request #1244: URL:

[GitHub] [qpid-dispatch] ChugR opened a new pull request #1244: DISPATCH-2108: Aggregate statistics for TCP listeners and connectors

2021-06-04 Thread GitBox
ChugR opened a new pull request #1244: URL: https://github.com/apache/qpid-dispatch/pull/1244 This commit adds counters * bytesIn * bytesOut * connectionsOpened * connectionsClosed to tcpListener and tcpConnector entities. Individual bytesIn and bytesOut

[jira] [Commented] (PROTON-2095) Move away from SWIG to CFFI

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357585#comment-17357585 ] ASF GitHub Bot commented on PROTON-2095: astitcher commented on pull request #318: URL:

[GitHub] [qpid-proton] astitcher commented on pull request #318: PROTON-2095 Move away from SWIG to CFFI

2021-06-04 Thread GitBox
astitcher commented on pull request #318: URL: https://github.com/apache/qpid-proton/pull/318#issuecomment-854956723 I'm really excited to see someone working to make the python bindings based on cffi rather than swig. I think this will bring significant benefits to Proton in build

[jira] [Commented] (PROTON-2095) Move away from SWIG to CFFI

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357531#comment-17357531 ] ASF GitHub Bot commented on PROTON-2095: jiridanek opened a new pull request #318: URL:

[GitHub] [qpid-proton] jiridanek opened a new pull request #318: PROTON-2095 Move away from SWIG to CFFI

2021-06-04 Thread GitBox
jiridanek opened a new pull request #318: URL: https://github.com/apache/qpid-proton/pull/318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357509#comment-17357509 ] ASF GitHub Bot commented on DISPATCH-1956: -- mgoulish opened a new pull request #1243: URL:

[GitHub] [qpid-dispatch] mgoulish opened a new pull request #1243: DISPATCH-1956: reduce locking around log src lookup

2021-06-04 Thread GitBox
mgoulish opened a new pull request #1243: URL: https://github.com/apache/qpid-dispatch/pull/1243 I noticed that almost all calls to qd_log_source_lh() were very simple: take the lock, call the function, release the lock. But that means that we could move the lock

[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357428#comment-17357428 ] ASF GitHub Bot commented on DISPATCH-1956: -- mgoulish closed pull request #1239: URL:

[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357427#comment-17357427 ] ASF GitHub Bot commented on DISPATCH-1956: -- mgoulish commented on pull request #1239: URL:

[GitHub] [qpid-dispatch] mgoulish closed pull request #1239: DISPATCH-1956: Fix TSan-reported lock-inversion

2021-06-04 Thread GitBox
mgoulish closed pull request #1239: URL: https://github.com/apache/qpid-dispatch/pull/1239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [qpid-dispatch] mgoulish commented on pull request #1239: DISPATCH-1956: Fix TSan-reported lock-inversion

2021-06-04 Thread GitBox
mgoulish commented on pull request #1239: URL: https://github.com/apache/qpid-dispatch/pull/1239#issuecomment-854811592 Closing this PR in favor of a new one, coming soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock

2021-06-04 Thread michael goulish (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357425#comment-17357425 ] michael goulish commented on DISPATCH-1956: --- I meant to close my *PR*.  Cripes.   >

[jira] [Closed] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock

2021-06-04 Thread michael goulish (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] michael goulish closed DISPATCH-1956. - Resolution: Fixed Closing this one in favor of a better one coming shortly. >

[jira] [Reopened] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock

2021-06-04 Thread michael goulish (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] michael goulish reopened DISPATCH-1956: --- No, wait.  I didn't mean it to say 'fixed'.  Dang. > Potential deadlock: logging

[jira] [Updated] (DISPATCH-1943) Collect overview of testing tools for protocol adaptor compatibilty (HTTP/2, ...)

2021-06-04 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-1943: - Description: _I wanted to share this in some public place_ h2. Functionality / Spec

[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock

2021-06-04 Thread michael goulish (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357401#comment-17357401 ] michael goulish commented on DISPATCH-1956: --- Hold on – I think I have a much better solution

[GitHub] [qpid-broker-j] alex-rufous commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
alex-rufous commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645590391 ## File path: broker-core/src/test/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImplTest.java ## @@ -364,6 +366,117 @@ public

[jira] [Commented] (PROTON-2393) Enhancments to the AMQP Test driver

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357370#comment-17357370 ] ASF subversion and git services commented on PROTON-2393: - Commit

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645583709 ## File path: broker-core/src/test/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImplTest.java ## @@ -364,6 +366,117 @@ public

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645582735 ## File path: broker-core/src/test/java/org/apache/qpid/server/security/group/FileGroupDatabaseCaseInsensitiveTest.java ## @@ -168,20 +170,15 @@

[GitHub] [qpid-broker-j] alex-rufous commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
alex-rufous commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645542563 ## File path: broker-core/src/main/java/org/apache/qpid/server/security/group/FileGroupDatabase.java ## @@ -104,25 +105,31 @@ public synchronized

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645489174 ## File path: broker-core/src/test/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImplTest.java ## @@ -364,6 +366,116 @@ public

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645487948 ## File path: broker-core/src/test/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImplTest.java ## @@ -364,6 +366,116 @@ public

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645487711 ## File path: broker-core/src/test/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImplTest.java ## @@ -364,6 +366,116 @@ public

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645487404 ## File path: broker-core/src/test/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImplTest.java ## @@ -364,6 +366,116 @@ public

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645486034 ## File path: broker-core/src/test/java/org/apache/qpid/server/security/group/FileGroupDatabaseCaseInsensitiveTest.java ## @@ -360,6 +357,34 @@

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645482117 ## File path: broker-core/src/test/java/org/apache/qpid/server/security/group/FileGroupDatabaseTest.java ## @@ -215,21 +217,14 @@ public void

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645473474 ## File path: broker-core/src/main/java/org/apache/qpid/server/security/group/FileGroupDatabase.java ## @@ -104,17 +105,21 @@ public synchronized

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645470751 ## File path: broker-core/src/main/java/org/apache/qpid/server/security/group/FileGroupDatabase.java ## @@ -104,17 +105,21 @@ public synchronized

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645469850 ## File path: broker-core/src/main/java/org/apache/qpid/server/security/group/FileGroupDatabase.java ## @@ -104,17 +105,21 @@ public synchronized

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645469201 ## File path: broker-core/src/main/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImpl.java ## @@ -359,16 +359,21 @@ protected void

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645469101 ## File path: broker-core/src/main/java/org/apache/qpid/server/security/group/FileGroupDatabase.java ## @@ -174,10 +179,27 @@ public synchronized

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645380751 ## File path: broker-core/src/main/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImpl.java ## @@ -359,16 +359,21 @@ protected void

[jira] [Commented] (QPID-8526) Connection looping in NonBlockingConnectionTLSDelegate.doWrite()

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/QPID-8526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357175#comment-17357175 ] ASF GitHub Bot commented on QPID-8526: -- dakirily closed pull request #87: URL:

[GitHub] [qpid-broker-j] dakirily closed pull request #87: QPID-8526:[Broker-J] Connection looping in NonBlockingConnectionTLSDelegate.doWrite()

2021-06-04 Thread GitBox
dakirily closed pull request #87: URL: https://github.com/apache/qpid-broker-j/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [qpid-broker-j] alex-rufous commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
alex-rufous commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645165431 ## File path: broker-core/src/main/java/org/apache/qpid/server/security/group/FileGroupDatabase.java ## @@ -104,17 +105,21 @@ public synchronized

[jira] [Commented] (QPID-8529) NPE when trying to access digestCrecentials in the cached mode

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/QPID-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357158#comment-17357158 ] ASF GitHub Bot commented on QPID-8529: -- alex-rufous commented on pull request #89: URL:

[GitHub] [qpid-broker-j] alex-rufous commented on pull request #89: QPID-8529:[Broker-J]set subject on non authenticated http requests

2021-06-04 Thread GitBox
alex-rufous commented on pull request #89: URL: https://github.com/apache/qpid-broker-j/pull/89#issuecomment-854238997 This PR have been already merged into main. Please close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (DISPATCH-1865) [http2] curl client hangs when running multiple clients against HTTP2 adaptor

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357153#comment-17357153 ] ASF GitHub Bot commented on DISPATCH-1865: -- ganeshmurthy opened a new pull request #1241:

[jira] [Commented] (DISPATCH-2115) Leak of qdr_link_route_t in system_tests_edge_router

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357146#comment-17357146 ] ASF GitHub Bot commented on DISPATCH-2115: -- asfgit closed pull request #1236: URL:

[GitHub] [qpid-dispatch] asfgit closed pull request #1236: DISPATCH-2115: Move the removal of connection based link routes befor…

2021-06-04 Thread GitBox
asfgit closed pull request #1236: URL: https://github.com/apache/qpid-dispatch/pull/1236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (DISPATCH-1896) [http2] GOAWAY frame received from server not propagated to client

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357142#comment-17357142 ] ASF GitHub Bot commented on DISPATCH-1896: -- ganeshmurthy opened a new pull request #1242:

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-04 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r644690778 ## File path: broker-core/src/main/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImpl.java ## @@ -205,17 +205,22 @@ public String

[jira] [Commented] (DISPATCH-1865) [http2] curl client hangs when running multiple clients against HTTP2 adaptor

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357139#comment-17357139 ] ASF GitHub Bot commented on DISPATCH-1865: -- ganeshmurthy closed pull request #1241: URL:

[GitHub] [qpid-dispatch] asfgit closed pull request #1240: NO-JIRA: Uncomment http tests in CI

2021-06-04 Thread GitBox
asfgit closed pull request #1240: URL: https://github.com/apache/qpid-dispatch/pull/1240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1241: DISPATCH-1865 - Propagate the GOAWAY frame received from the http2 se…

2021-06-04 Thread GitBox
ganeshmurthy closed pull request #1241: URL: https://github.com/apache/qpid-dispatch/pull/1241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Commented] (QPID-8530) [Broker-J] Duplicated functionality of the Selector::wakeup method in SelectorThread

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/QPID-8530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357137#comment-17357137 ] ASF GitHub Bot commented on QPID-8530: -- mklaca opened a new pull request #90: URL:

[jira] [Commented] (QPID-8526) Connection looping in NonBlockingConnectionTLSDelegate.doWrite()

2021-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/QPID-8526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357134#comment-17357134 ] ASF GitHub Bot commented on QPID-8526: -- alex-rufous commented on pull request #87: URL:

[GitHub] [qpid-broker-j] alex-rufous commented on pull request #87: QPID-8526:[Broker-J] Connection looping in NonBlockingConnectionTLSDelegate.doWrite()

2021-06-04 Thread GitBox
alex-rufous commented on pull request #87: URL: https://github.com/apache/qpid-broker-j/pull/87#issuecomment-854239275 This PR have been already merged into main. Please close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub