[jira] [Commented] (DISPATCH-2246) The 'Address already in use` test issue, in echo server

2021-09-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17412267#comment-17412267 ] ASF GitHub Bot commented on DISPATCH-2246: -- codecov-commenter commented on pull request

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1365: DISPATCH-2246 Use port 0 in systemtests when starting TCP_echo_server, then query for actual port

2021-09-08 Thread GitBox
codecov-commenter commented on pull request #1365: URL: https://github.com/apache/qpid-dispatch/pull/1365#issuecomment-915694700 #

[GitHub] [qpid-proton-j] wx930910 commented on pull request #41: Replace SinkHandler by mocking object and improve test design

2021-09-08 Thread GitBox
wx930910 commented on pull request #41: URL: https://github.com/apache/qpid-proton-j/pull/41#issuecomment-915669651 > I'm not sure I would actually consider this a great improvement overall. Its just as (if not more) verbose as the original but harder to understand from a simple glance,

[jira] [Commented] (DISPATCH-2246) The 'Address already in use` test issue, in echo server

2021-09-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17412215#comment-17412215 ] ASF GitHub Bot commented on DISPATCH-2246: -- jiridanek commented on a change in pull request

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1365: DISPATCH-2246 Use port 0 in systemtests when starting TCP_echo_server, then query for actual port

2021-09-08 Thread GitBox
jiridanek commented on a change in pull request #1365: URL: https://github.com/apache/qpid-dispatch/pull/1365#discussion_r704821655 ## File path: tests/system_tests_tcp_adaptor.py ## @@ -347,12 +342,12 @@ def router(name, mode, connection, extra=None):

[jira] [Resolved] (DISPATCH-2248) link_work item leak due to improper delivery reference drop

2021-09-08 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-2248. -- Resolution: Fixed > link_work item leak due to improper delivery reference drop >

[jira] [Commented] (DISPATCH-2248) link_work item leak due to improper delivery reference drop

2021-09-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411990#comment-17411990 ] ASF GitHub Bot commented on DISPATCH-2248: -- asfgit closed pull request #1364: URL:

[jira] [Commented] (DISPATCH-2248) link_work item leak due to improper delivery reference drop

2021-09-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411988#comment-17411988 ] ASF subversion and git services commented on DISPATCH-2248: --- Commit

[GitHub] [qpid-dispatch] asfgit closed pull request #1364: DISPATCH-2248: fix the dereference of a deliverys link work item

2021-09-08 Thread GitBox
asfgit closed pull request #1364: URL: https://github.com/apache/qpid-dispatch/pull/1364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (DISPATCH-2249) Refactor router shutdown to eliminate leaks and races

2021-09-08 Thread Ken Giusti (Jira)
Ken Giusti created DISPATCH-2249: Summary: Refactor router shutdown to eliminate leaks and races Key: DISPATCH-2249 URL: https://issues.apache.org/jira/browse/DISPATCH-2249 Project: Qpid Dispatch