[jira] [Commented] (DISPATCH-2260) http adaptor link remains after connector deletion on edge router

2021-10-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434072#comment-17434072 ] ASF GitHub Bot commented on DISPATCH-2260: -- codecov-commenter commented on pull request

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1394: DISPATCH-2260: HTTP/1.x: fix deletion of httpConnector and httpListener

2021-10-25 Thread GitBox
codecov-commenter commented on pull request #1394: URL: https://github.com/apache/qpid-dispatch/pull/1394#issuecomment-951471126 #

[jira] [Resolved] (DISPATCH-2257) listener with http=true uses AF_INTE6 even when ipv6 is not supported

2021-10-25 Thread Gordon Sim (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved DISPATCH-2257. -- Fix Version/s: 1.18.0 Resolution: Fixed > listener with http=true uses AF_INTE6 even

[jira] [Commented] (QPID-8565) [Broker-J] Enhancement of ACL rule predicates evaluation

2021-10-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/QPID-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433816#comment-17433816 ] ASF GitHub Bot commented on QPID-8565: -- mklaca edited a comment on pull request #110: URL:

[GitHub] [qpid-broker-j] mklaca edited a comment on pull request #110: QPID-8565: [Broker-J] Enhancement of ACL rule predicates evaluation

2021-10-25 Thread GitBox
mklaca edited a comment on pull request #110: URL: https://github.com/apache/qpid-broker-j/pull/110#issuecomment-950683148 Hi Alex, - The original code contains the class AclRulePredicates that consists of multiple rule predicates. I am not keen on renaming everything. I would like

[jira] [Commented] (DISPATCH-2259) server_name set by Dispatch Router contains illegal characters

2021-10-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433772#comment-17433772 ] ASF GitHub Bot commented on DISPATCH-2259: -- grs commented on pull request #1393: URL:

[GitHub] [qpid-dispatch] grs commented on pull request #1393: DISPATCH-2259: use hostname when setting connection hostname

2021-10-25 Thread GitBox
grs commented on pull request #1393: URL: https://github.com/apache/qpid-dispatch/pull/1393#issuecomment-950955749 @kgiusti changed from strdup to qd_strdup (and changed all the other invocations in that file also), is that what you meant? -- This is an automated message from the Apache

[jira] [Commented] (DISPATCH-1956) log.c rewrite to reduce locking scope

2021-10-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433764#comment-17433764 ] ASF subversion and git services commented on DISPATCH-1956: --- Commit

[jira] [Commented] (DISPATCH-1956) log.c rewrite to reduce locking scope

2021-10-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433763#comment-17433763 ] ASF subversion and git services commented on DISPATCH-1956: --- Commit

[GitHub] [qpid-dispatch] asfgit merged pull request #1392: Dispatch 1956 1

2021-10-25 Thread GitBox
asfgit merged pull request #1392: URL: https://github.com/apache/qpid-dispatch/pull/1392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (DISPATCH-2260) http adaptor link remains after connector deletion on edge router

2021-10-25 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433754#comment-17433754 ] Ken Giusti commented on DISPATCH-2260: -- root cause: The adaptor needs to generate a link detach

[jira] [Created] (DISPATCH-2260) http adaptor link remains after connector deletion on edge router

2021-10-25 Thread Ken Giusti (Jira)
Ken Giusti created DISPATCH-2260: Summary: http adaptor link remains after connector deletion on edge router Key: DISPATCH-2260 URL: https://issues.apache.org/jira/browse/DISPATCH-2260 Project: Qpid

[jira] [Assigned] (DISPATCH-2260) http adaptor link remains after connector deletion on edge router

2021-10-25 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned DISPATCH-2260: Assignee: Ken Giusti > http adaptor link remains after connector deletion on edge

[GitHub] [qpid-dispatch] grs opened a new pull request #1393: DISPATCH-2259: use hostname when setting connection hostname

2021-10-25 Thread GitBox
grs opened a new pull request #1393: URL: https://github.com/apache/qpid-dispatch/pull/1393 not host-port combination -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (DISPATCH-2259) server_name set by Dispatch Router contains illegal characters

2021-10-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433722#comment-17433722 ] ASF GitHub Bot commented on DISPATCH-2259: -- grs opened a new pull request #1393: URL:

[jira] [Commented] (PROTON-2406) [cpp] Use of reconnect_options::failover_urls triggers -Wdeprecated-declarations in examples/cpp/reconnect_client.cpp

2021-10-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433710#comment-17433710 ] ASF GitHub Bot commented on PROTON-2406: codecov-commenter commented on pull request #337: URL:

[jira] [Commented] (PROTON-2406) [cpp] Use of reconnect_options::failover_urls triggers -Wdeprecated-declarations in examples/cpp/reconnect_client.cpp

2021-10-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433709#comment-17433709 ] ASF GitHub Bot commented on PROTON-2406: codecov-commenter edited a comment on pull request

[GitHub] [qpid-proton] codecov-commenter commented on pull request #337: PROTON-2406: [cpp] Replace uses of deprecated reconnect_options::failover_urls with conn…

2021-10-25 Thread GitBox
codecov-commenter commented on pull request #337: URL: https://github.com/apache/qpid-proton/pull/337#issuecomment-950847127 #

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #337: PROTON-2406: [cpp] Replace uses of deprecated reconnect_options::failover_urls with conn…

2021-10-25 Thread GitBox
codecov-commenter edited a comment on pull request #337: URL: https://github.com/apache/qpid-proton/pull/337#issuecomment-950847127 #

[jira] [Commented] (QPID-8565) [Broker-J] Enhancement of ACL rule predicates evaluation

2021-10-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/QPID-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433634#comment-17433634 ] ASF GitHub Bot commented on QPID-8565: -- mklaca commented on pull request #110: URL:

[GitHub] [qpid-broker-j] mklaca commented on pull request #110: QPID-8565: [Broker-J] Enhancement of ACL rule predicates evaluation

2021-10-25 Thread GitBox
mklaca commented on pull request #110: URL: https://github.com/apache/qpid-broker-j/pull/110#issuecomment-950683148 Hi Alex, - The original code contains the class AclRulePredicates that consists of multiple rule predicates. I am not keen on renaming everything. I would like to