[GitHub] [qpid-jms] sebthom commented on pull request #38: Avoid unnecessary cast when throwing IllegalArgumentException

2022-01-11 Thread GitBox
sebthom commented on pull request #38: URL: https://github.com/apache/qpid-jms/pull/38#issuecomment-1010640315 @gemmellr Would you please review. Thanks in advance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (PROTON-2481) [cpp] Improve constructor syntax for maps

2022-01-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17473074#comment-17473074 ] ASF GitHub Bot commented on PROTON-2481: jiridanek commented on pull request #35

[GitHub] [qpid-proton] jiridanek commented on pull request #353: PROTON-2481: [cpp] Improve constructor syntax for maps

2022-01-11 Thread GitBox
jiridanek commented on pull request #353: URL: https://github.com/apache/qpid-proton/pull/353#issuecomment-1010244968 There aren't any usages for the new constructors. I'd like to see some test that calls them. -- This is an automated message from the Apache Git Service. To respond to th

[jira] [Commented] (PROTON-2481) [cpp] Improve constructor syntax for maps

2022-01-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472964#comment-17472964 ] ASF GitHub Bot commented on PROTON-2481: astitcher commented on a change in pull

[GitHub] [qpid-proton] astitcher commented on a change in pull request #353: PROTON-2481: [cpp] Improve constructor syntax for maps

2022-01-11 Thread GitBox
astitcher commented on a change in pull request #353: URL: https://github.com/apache/qpid-proton/pull/353#discussion_r782359276 ## File path: cpp/include/proton/map.hpp ## @@ -26,6 +26,8 @@ #include "./internal/pn_unique_ptr.hpp" #include +#include +#include Review comm

[jira] [Reopened] (PROTON-2440) Configured heartbeats sometimes don't function in inter-cloud environments

2022-01-11 Thread Justin Ross (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross reopened PROTON-2440: - > Configured heartbeats sometimes don't function in inter-cloud environments > -

[jira] [Closed] (PROTON-2440) Configured heartbeats sometimes don't function in inter-cloud environments

2022-01-11 Thread Justin Ross (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross closed PROTON-2440. --- Resolution: Information Provided > Configured heartbeats sometimes don't function in inter-cloud env

[jira] [Closed] (PROTON-2440) Configured heartbeats sometimes don't function in inter-cloud environments

2022-01-11 Thread Justin Ross (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross closed PROTON-2440. --- Resolution: Fixed > Configured heartbeats sometimes don't function in inter-cloud environments > ---

[jira] [Commented] (PROTON-2440) Configured heartbeats sometimes don't function in inter-cloud environments

2022-01-11 Thread Justin Ross (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472863#comment-17472863 ] Justin Ross commented on PROTON-2440: - We think this arose from the timer bug linked

[jira] [Resolved] (PROTON-2479) Improve proactor read performance by actually resizing input buffer

2022-01-11 Thread Andrew Stitcher (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2479. - Resolution: Fixed > Improve proactor read performance by actually resizing input buffer

[jira] [Resolved] (PROTON-2482) Proactor can seem to read nonsense

2022-01-11 Thread Andrew Stitcher (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2482. - Assignee: Andrew Stitcher Resolution: Fixed > Proactor can seem to read nonsense >

[jira] [Commented] (PROTON-2482) Proactor can seem to read nonsense

2022-01-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472845#comment-17472845 ] ASF subversion and git services commented on PROTON-2482: - Commi

[jira] [Commented] (PROTON-2479) Improve proactor read performance by actually resizing input buffer

2022-01-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472846#comment-17472846 ] ASF subversion and git services commented on PROTON-2479: - Commi

[jira] [Updated] (PROTON-2482) Proactor can seem to read nonsense

2022-01-11 Thread Andrew Stitcher (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated PROTON-2482: Description: Missing handling of read exception cases (EOF and EWOULDBLOCK) mean that the

[jira] [Created] (PROTON-2482) Proactor can seem to read nonsense

2022-01-11 Thread Andrew Stitcher (Jira)
Andrew Stitcher created PROTON-2482: --- Summary: Proactor can seem to read nonsense Key: PROTON-2482 URL: https://issues.apache.org/jira/browse/PROTON-2482 Project: Qpid Proton Issue Type: Bu

[jira] [Resolved] (PROTON-2436) TSAN race in epoll.c post_event with raw connection

2022-01-11 Thread Clifford Jansen (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clifford Jansen resolved PROTON-2436. - Fix Version/s: proton-c-0.37.0 Resolution: Fixed Make ownership of scheduled io e

[jira] [Commented] (PROTON-2436) TSAN race in epoll.c post_event with raw connection

2022-01-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472809#comment-17472809 ] ASF subversion and git services commented on PROTON-2436: - Commi