[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1515: Dispatch 1487: message annotations re-write (full patch)

2022-02-15 Thread GitBox
codecov-commenter commented on pull request #1515: URL: https://github.com/apache/qpid-dispatch/pull/1515#issuecomment-1040875303 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1515?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1515: Dispatch 1487: message annotations re-write (full patch)

2022-02-15 Thread GitBox
kgiusti commented on a change in pull request #1515: URL: https://github.com/apache/qpid-dispatch/pull/1515#discussion_r807289522 ## File path: include/qpid/dispatch/amqp.h ## @@ -19,6 +19,8 @@ * under the License. Review comment: May or may not be related to the patc

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1515: Dispatch 1487: message annotations re-write (full patch)

2022-02-15 Thread GitBox
kgiusti commented on a change in pull request #1515: URL: https://github.com/apache/qpid-dispatch/pull/1515#discussion_r807284854 ## File path: include/qpid/dispatch/amqp.h ## @@ -19,6 +19,8 @@ * under the License. Review comment: @jiridanek ouch. No, this triggered

[jira] [Commented] (DISPATCH-2066) [http1] In system_tests_http1_adaptor Http1AdaptorQ2Standalone backpressure tests, block_ct != unblock_ct

2022-02-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492829#comment-17492829 ] ASF GitHub Bot commented on DISPATCH-2066: -- kgiusti commented on a change in

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1516: DISPATCH-2066: fix flakey http1 Q2 test

2022-02-15 Thread GitBox
kgiusti commented on a change in pull request #1516: URL: https://github.com/apache/qpid-dispatch/pull/1516#discussion_r807094965 ## File path: tests/system_tests_http1_adaptor.py ## @@ -951,18 +964,8 @@ def test_02_backpressure_server(self): server_listener.shutdown(s

[jira] [Commented] (QPID-8577) problems when delivering to full queues using AMQP 1.0

2022-02-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/QPID-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492825#comment-17492825 ] ASF GitHub Bot commented on QPID-8577: -- pjfawcett opened a new pull request #29: URL:

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1515: Dispatch 1487: message annotations re-write (full patch)

2022-02-15 Thread GitBox
ganeshmurthy commented on a change in pull request #1515: URL: https://github.com/apache/qpid-dispatch/pull/1515#discussion_r806073948 ## File path: include/qpid/dispatch/compose.h ## @@ -262,6 +263,92 @@ void qd_compose_insert_opaque_elements(qd_composed_field_t *field, */

[jira] [Commented] (DISPATCH-2066) [http1] In system_tests_http1_adaptor Http1AdaptorQ2Standalone backpressure tests, block_ct != unblock_ct

2022-02-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492762#comment-17492762 ] ASF GitHub Bot commented on DISPATCH-2066: -- kgiusti commented on a change in

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1516: DISPATCH-2066: fix flakey http1 Q2 test

2022-02-15 Thread GitBox
kgiusti commented on a change in pull request #1516: URL: https://github.com/apache/qpid-dispatch/pull/1516#discussion_r807140454 ## File path: tests/system_tests_http1_adaptor.py ## @@ -905,7 +918,7 @@ def test_02_backpressure_server(self): client_sock = socket.socket

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1516: DISPATCH-2066: fix flakey http1 Q2 test

2022-02-15 Thread GitBox
kgiusti commented on a change in pull request #1516: URL: https://github.com/apache/qpid-dispatch/pull/1516#discussion_r807094965 ## File path: tests/system_tests_http1_adaptor.py ## @@ -951,18 +964,8 @@ def test_02_backpressure_server(self): server_listener.shutdown(s

[jira] [Commented] (DISPATCH-2066) [http1] In system_tests_http1_adaptor Http1AdaptorQ2Standalone backpressure tests, block_ct != unblock_ct

2022-02-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492736#comment-17492736 ] ASF GitHub Bot commented on DISPATCH-2066: -- kgiusti commented on a change in

[jira] [Resolved] (PROTON-2485) [C++] More work to use C++11 features now that we can

2022-02-15 Thread Andrew Stitcher (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2485. - Resolution: Fixed We'll open another issue when we find more C++ 11 tidying work. > [C+

[jira] [Updated] (PROTON-2485) [C++] More work to use C++11 features now that we can

2022-02-15 Thread Andrew Stitcher (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated PROTON-2485: Description: We can simplify the C++ code by removing our workarounds for having to be com

[jira] [Commented] (PROTON-2451) Reduce (ultimately eliminate) all use of the pn_data_t data structure in AMQP frame processing

2022-02-15 Thread Andrew Stitcher (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492699#comment-17492699 ] Andrew Stitcher commented on PROTON-2451: - I've cloned this issue for the remain

[jira] [Resolved] (PROTON-2451) Reduce (ultimately eliminate) all use of the pn_data_t data structure in AMQP frame processing

2022-02-15 Thread Andrew Stitcher (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2451. - Resolution: Fixed > Reduce (ultimately eliminate) all use of the pn_data_t data structur

[jira] [Updated] (PROTON-2501) Eliminate all use of the pn_data_t data structure in AMQP frame processing crirical path

2022-02-15 Thread Andrew Stitcher (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated PROTON-2501: Summary: Eliminate all use of the pn_data_t data structure in AMQP frame processing criric

[jira] [Updated] (PROTON-2501) CLONE - Reduce (ultimately eliminate) all use of the pn_data_t data structure in AMQP frame processing

2022-02-15 Thread Andrew Stitcher (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated PROTON-2501: Description: In current proton protocol processing code make heavy use of the pn_data_t da

[jira] [Updated] (PROTON-2501) CLONE - Reduce (ultimately eliminate) all use of the pn_data_t data structure in AMQP frame processing

2022-02-15 Thread Andrew Stitcher (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated PROTON-2501: Fix Version/s: (was: proton-c-0.37.0) > CLONE - Reduce (ultimately eliminate) all use

[jira] [Created] (PROTON-2501) CLONE - Reduce (ultimately eliminate) all use of the pn_data_t data structure in AMQP frame processing

2022-02-15 Thread Andrew Stitcher (Jira)
Andrew Stitcher created PROTON-2501: --- Summary: CLONE - Reduce (ultimately eliminate) all use of the pn_data_t data structure in AMQP frame processing Key: PROTON-2501 URL: https://issues.apache.org/jira/browse/P

[GitHub] [qpid-cpp] pjfawcett opened a new pull request #29: QPID-8577 segfault after link error

2022-02-15 Thread GitBox
pjfawcett opened a new pull request #29: URL: https://github.com/apache/qpid-cpp/pull/29 As per Phase One of QPID-8577 - Check for valid link before processing pending "delivery accept". - Remove pending "delivery accept" from session when closing link after error -- This is

[jira] [Commented] (QPID-8577) problems when delivering to full queues using AMQP 1.0

2022-02-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/QPID-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492598#comment-17492598 ] ASF GitHub Bot commented on QPID-8577: -- pjfawcett opened a new pull request #29: URL:

[jira] [Created] (QPID-8577) problems when delivering to full queues using AMQP 1.0

2022-02-15 Thread Pete Fawcett (Jira)
Pete Fawcett created QPID-8577: -- Summary: problems when delivering to full queues using AMQP 1.0 Key: QPID-8577 URL: https://issues.apache.org/jira/browse/QPID-8577 Project: Qpid Issue Type: Bug