[PR] NO-JIRA: Fix miscellaneous typos [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek opened a new pull request, #404: URL: https://github.com/apache/qpid-proton/pull/404 @astitcher just fyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[jira] [Created] (PROTON-2772) [c] Add parameter safety annotations for printf format strings

2023-10-14 Thread Jira
Jiri Daněk created PROTON-2772: -- Summary: [c] Add parameter safety annotations for printf format strings Key: PROTON-2772 URL: https://issues.apache.org/jira/browse/PROTON-2772 Project: Qpid Proton

[PR] PROTON-2772: add parameter safety annotations for printf format strings [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek opened a new pull request, #405: URL: https://github.com/apache/qpid-proton/pull/405 (the commits with fixes are meant to be squashed with the rest, which I plan to do in GitHub webui) -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (PROTON-2772) [c] Add parameter safety annotations for printf format strings

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775203#comment-17775203 ] ASF GitHub Bot commented on PROTON-2772: jiridanek opened a new pull request, #4

Re: [PR] PROTON-2772: add parameter safety annotations for printf format strings [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek commented on PR #405: URL: https://github.com/apache/qpid-proton/pull/405#issuecomment-1762857402 Duplicate of * https://github.com/apache/qpid-proton/pull/397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] PROTON-2772: add parameter safety annotations for printf format strings [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek closed pull request #405: PROTON-2772: add parameter safety annotations for printf format strings URL: https://github.com/apache/qpid-proton/pull/405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (PROTON-2772) [c] Add parameter safety annotations for printf format strings

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775206#comment-17775206 ] ASF GitHub Bot commented on PROTON-2772: jiridanek commented on PR #405: URL: ht

[jira] [Commented] (PROTON-2772) [c] Add parameter safety annotations for printf format strings

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775207#comment-17775207 ] ASF GitHub Bot commented on PROTON-2772: jiridanek closed pull request #405: PRO

Re: [PR] PROTON-2714: add annotations for printf-like format strings and fix linux compiler warnings [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek commented on PR #397: URL: https://github.com/apache/qpid-proton/pull/397#issuecomment-1762870853 Sorry for creating the duplicate, I did not remember I already created a PR for this. It's actually good, since I already have it (mostly) reviewed, and the time has come preparing fo

[jira] [Commented] (PROTON-2714) logger.c:204:41: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Werror=format=]

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775210#comment-17775210 ] ASF GitHub Bot commented on PROTON-2714: jiridanek commented on PR #397: URL: ht

Re: [PR] PROTON-2714: add annotations for printf-like format strings and fix linux compiler warnings [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek merged PR #397: URL: https://github.com/apache/qpid-proton/pull/397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apach

[jira] [Commented] (PROTON-2772) [c] Add parameter safety annotations for printf format strings

2023-10-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775219#comment-17775219 ] ASF subversion and git services commented on PROTON-2772: - Commi

[jira] [Commented] (PROTON-2714) logger.c:204:41: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Werror=format=]

2023-10-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775220#comment-17775220 ] ASF subversion and git services commented on PROTON-2714: - Commi

[jira] [Commented] (PROTON-2714) logger.c:204:41: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Werror=format=]

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775218#comment-17775218 ] ASF GitHub Bot commented on PROTON-2714: jiridanek merged PR #397: URL: https://

[PR] PROTON-2772: add format arg annotations for schannel functions [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek opened a new pull request, #406: URL: https://github.com/apache/qpid-proton/pull/406 What's missing is a compilation failure when any warnings are emitted. MSVC needs `/analyze` to report the problems, there is actually lots of diagnostics printed then, and the mismatched fo

[jira] [Commented] (PROTON-2772) [c] Add parameter safety annotations for printf format strings

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775222#comment-17775222 ] ASF GitHub Bot commented on PROTON-2772: jiridanek opened a new pull request, #4

[jira] [Created] (PROTON-2773) [c] Add various compiler diagnostic helper macros

2023-10-14 Thread Jira
Jiri Daněk created PROTON-2773: -- Summary: [c] Add various compiler diagnostic helper macros Key: PROTON-2773 URL: https://issues.apache.org/jira/browse/PROTON-2773 Project: Qpid Proton Issue Typ

Re: [PR] PROTON-2772: add format arg annotations for schannel functions [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek closed pull request #406: PROTON-2772: add format arg annotations for schannel functions URL: https://github.com/apache/qpid-proton/pull/406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PROTON-2772) [c] Add parameter safety annotations for printf format strings

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775235#comment-17775235 ] ASF GitHub Bot commented on PROTON-2772: jiridanek closed pull request #406: PRO

[PR] PROTON-2772: add format arg annotations for schannel functions [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek opened a new pull request, #407: URL: https://github.com/apache/qpid-proton/pull/407 What's missing is a compilation failure when any warnings are emitted. MSVC needs /analyze to report the problems, there is actually lots of diagnostics printed then, and the mismatched form

[jira] [Commented] (PROTON-2772) [c] Add parameter safety annotations for printf format strings

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775236#comment-17775236 ] ASF GitHub Bot commented on PROTON-2772: jiridanek opened a new pull request, #4

Re: [PR] PROTON-2772: add format arg annotations for schannel functions [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek commented on PR #406: URL: https://github.com/apache/qpid-proton/pull/406#issuecomment-1762922429 I made the PR from a wrong branch, and apparently it is not possible to rename a branch when there is already a PR from that branch. * PR recreated as https://github.com/apache/

[PR] PROTON-2773: add `PN_FALLTHROUGH` macro ready for c++17/c21 [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek opened a new pull request, #408: URL: https://github.com/apache/qpid-proton/pull/408 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (PROTON-2772) [c] Add parameter safety annotations for printf format strings

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775237#comment-17775237 ] ASF GitHub Bot commented on PROTON-2772: jiridanek commented on PR #406: URL: ht

[jira] [Commented] (PROTON-2773) [c] Add various compiler diagnostic helper macros

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775238#comment-17775238 ] ASF GitHub Bot commented on PROTON-2773: jiridanek opened a new pull request, #4

Re: [PR] PROTON-2773: add `PN_FALLTHROUGH` macro ready for c++17/c21 [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek commented on PR #408: URL: https://github.com/apache/qpid-proton/pull/408#issuecomment-1762993831 The original motivation for this is to be able to have composite CMake build with skupper-router. With skupper-router adding proton as cmake subproject. To do this, both projects need

[jira] [Commented] (PROTON-2773) [c] Add various compiler diagnostic helper macros

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775259#comment-17775259 ] ASF GitHub Bot commented on PROTON-2773: jiridanek commented on PR #408: URL: ht

[PR] PROTON-2772: make wrong printf format strings a MSVC compile error [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek opened a new pull request, #409: URL: https://github.com/apache/qpid-proton/pull/409 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (PROTON-2772) [c] Add parameter safety annotations for printf format strings

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775262#comment-17775262 ] ASF GitHub Bot commented on PROTON-2772: jiridanek opened a new pull request, #4

Re: [PR] PROTON-2772: add format arg annotations for schannel functions [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek commented on PR #407: URL: https://github.com/apache/qpid-proton/pull/407#issuecomment-1762994940 * Superseded by https://github.com/apache/qpid-proton/pull/409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] PROTON-2772: add format arg annotations for schannel functions [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek closed pull request #407: PROTON-2772: add format arg annotations for schannel functions URL: https://github.com/apache/qpid-proton/pull/407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PROTON-2772) [c] Add parameter safety annotations for printf format strings

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775264#comment-17775264 ] ASF GitHub Bot commented on PROTON-2772: jiridanek closed pull request #407: PRO

[jira] [Commented] (PROTON-2772) [c] Add parameter safety annotations for printf format strings

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775263#comment-17775263 ] ASF GitHub Bot commented on PROTON-2772: jiridanek commented on PR #407: URL: ht

Re: [PR] PROTON-2772: make wrong printf format strings a MSVC compile error [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek commented on PR #409: URL: https://github.com/apache/qpid-proton/pull/409#issuecomment-1762995906 This PR currently only reveals the issues, it does not try to fix them. There is few tens of warnings generated, for C6328 and C6340 warnings. https://github.com/jiridanek/qpid

[jira] [Commented] (PROTON-2772) [c] Add parameter safety annotations for printf format strings

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775265#comment-17775265 ] ASF GitHub Bot commented on PROTON-2772: jiridanek commented on PR #409: URL: ht

Re: [PR] NO-JIRA: Fix miscellaneous typos [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek merged PR #404: URL: https://github.com/apache/qpid-proton/pull/404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apach

[jira] [Created] (PROTON-2774) Support composite CMake builds

2023-10-14 Thread Jira
Jiri Daněk created PROTON-2774: -- Summary: Support composite CMake builds Key: PROTON-2774 URL: https://issues.apache.org/jira/browse/PROTON-2774 Project: Qpid Proton Issue Type: Improvement

[PR] PROTON-2774: replace `CMAKE_SOURCE_DIR` variable with `PROJECT_SOURCE_DIR` [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek opened a new pull request, #410: URL: https://github.com/apache/qpid-proton/pull/410 This change allows the CMake build file work as an embedded subproject in an composite CMake build. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (PROTON-2774) Support composite CMake builds

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775277#comment-17775277 ] ASF GitHub Bot commented on PROTON-2774: jiridanek opened a new pull request, #4

Re: [PR] PROTON-2773: add `PN_FALLTHROUGH` macro ready for c++17/c21 [qpid-proton]

2023-10-14 Thread via GitHub
jiridanek commented on PR #408: URL: https://github.com/apache/qpid-proton/pull/408#issuecomment-1763064971 > See also https://lore.kernel.org/lkml/a588204afbfe4c8dd56d0cb00d8e6e14dc561a62.ca...@perches.com/ > > where Joe Perches who maintains the Linux kernel's patch validator (scrip

[jira] [Commented] (PROTON-2773) [c] Add various compiler diagnostic helper macros

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775280#comment-17775280 ] ASF GitHub Bot commented on PROTON-2773: jiridanek commented on PR #408: URL: ht