[jira] [Commented] (QPID-3912) Client failover fails to reconnect if a previous attempted reconnection has failed 'late' in the connection start process.

[ https://issues.apache.org/jira/browse/QPID-3912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240295#comment-13240295 ] Keith Wall commented on QPID-3912: -- Patch applied, Andrew can you review please?

[jira] [Commented] (QPID-3905) NullPointerException is thrown on rejecting messages whilst closing the connection

[ https://issues.apache.org/jira/browse/QPID-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237737#comment-13237737 ] Keith Wall commented on QPID-3905: -- Patch applied. Alex, could you review please?

[jira] [Commented] (QPID-3905) NullPointerException is thrown on rejecting messages whilst closing the connection

[ https://issues.apache.org/jira/browse/QPID-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236465#comment-13236465 ] Keith Wall commented on QPID-3905: -- I wonder if my change for QPID-3807 has exposed this d

[jira] [Commented] (QPID-3904) Java client should set AMQConnection#_closed flag on receipt of 0-10 connection.close

[ https://issues.apache.org/jira/browse/QPID-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234331#comment-13234331 ] Keith Wall commented on QPID-3904: -- Patch applied. Andrew, could you review please?

[jira] [Commented] (QPID-3895) A reference to AMQChannel object is not removed from SimpleAMQQueue#_blockedChannels map on closing connections with producer side flow control when flow is blocked

[ https://issues.apache.org/jira/browse/QPID-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230009#comment-13230009 ] Keith Wall commented on QPID-3895: -- Hi Alex, A couple of comments from me: 1) The two ne

[jira] [Commented] (QPID-3894) Improve MessageListener system tests

[ https://issues.apache.org/jira/browse/QPID-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227208#comment-13227208 ] Keith Wall commented on QPID-3894: -- Commit made. Robbie, would you mind reviewing?

[jira] [Commented] (QPID-3879) Session#close() on session can produce spurious "dispatcher is not started" messages at ERROR to client logs

[ https://issues.apache.org/jira/browse/QPID-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221863#comment-13221863 ] Keith Wall commented on QPID-3879: -- There is a race between the Dispatcher thread and the

[jira] [Commented] (QPID-3599) Python session tests fail against the Java Broker due to unexpected redelivered status

[ https://issues.apache.org/jira/browse/QPID-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219269#comment-13219269 ] Keith Wall commented on QPID-3599: -- Stack trace is: qpid.tests.messaging.endpoints.Sessio

[jira] [Commented] (QPID-3868) Test org.apache.qpid.server.queue.TimeToLiveTest.testActiveTTL fails very occasionally on slow CI box.

[ https://issues.apache.org/jira/browse/QPID-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214458#comment-13214458 ] Keith Wall commented on QPID-3868: -- Logs suggest a broker issue rather than test issue. Y

[jira] [Commented] (QPID-3325) make the ApplicationRegistry unregister its shutdown hook when closed by means other than the shutdown hook

[ https://issues.apache.org/jira/browse/QPID-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214095#comment-13214095 ] Keith Wall commented on QPID-3325: -- Hi Robbie, Two minor comments: 1) I think we should

[jira] [Commented] (QPID-3831) the 0-10 Java client should use AcquireMode=PRE_ACQUIRED when using selectors on a Queue destination and server-side selectors are in use

[ https://issues.apache.org/jira/browse/QPID-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210316#comment-13210316 ] Keith Wall commented on QPID-3831: -- No comments, changes look good. > the

[jira] [Commented] (QPID-3835) [Java broker] DurableSubscriptions without a selector on 0-10 connections will initially be unsubscribed at reconnect following upgrade of a legacy message store

[ https://issues.apache.org/jira/browse/QPID-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210302#comment-13210302 ] Keith Wall commented on QPID-3835: -- Minor comment only against the test code. In BDBStore

[jira] [Commented] (QPID-3714) [Java] Performance Improvements

[ https://issues.apache.org/jira/browse/QPID-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210288#comment-13210288 ] Keith Wall commented on QPID-3714: -- Fixed defect in caching logic in BasicContentHeaderPro

[jira] [Commented] (QPID-3842) Java Broker should report platform and memory size on startup

[ https://issues.apache.org/jira/browse/QPID-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208127#comment-13208127 ] Keith Wall commented on QPID-3842: -- Patch applied. Hi Robbie, can you review this commit?

[jira] [Commented] (QPID-3842) Java Broker should report platform and memory size on startup

[ https://issues.apache.org/jira/browse/QPID-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208107#comment-13208107 ] Keith Wall commented on QPID-3842: -- This change will give two new lines of output during s

[jira] [Commented] (QPID-3803) System tests SortedQueueTest#testSortedQueue fail ocasionally on slow machines

[ https://issues.apache.org/jira/browse/QPID-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205312#comment-13205312 ] Keith Wall commented on QPID-3803: -- Patch applied. > System tests SortedQ

[jira] [Commented] (QPID-3803) System tests SortedQueueTest#testSortedQueue fail ocasionally on slow machines

[ https://issues.apache.org/jira/browse/QPID-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205307#comment-13205307 ] Keith Wall commented on QPID-3803: -- We are still seeing the occasional failure on one CI b

[jira] [Commented] (QPID-3824) Additional queue statistics, posix memory statistics, and broker-scope statistics

[ https://issues.apache.org/jira/browse/QPID-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205289#comment-13205289 ] Keith Wall commented on QPID-3824: -- Hi I think this commit broke running of the Python te

[jira] [Commented] (QPID-3739) Java properties qpid.ssl.keyStoreCertType and qpid.ssl.trustStoreCertType have misleading names and would be better called qpid.ssl.[Key|Trust]ManagerFactory.algorithm

[ https://issues.apache.org/jira/browse/QPID-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204770#comment-13204770 ] Keith Wall commented on QPID-3739: -- I'll remove the DEFAULT_ALGORITHM_NAME, we don't need

[jira] [Commented] (QPID-3825) TransactionTimeoutTest.testProducerOpenCommit and others fails sporadically on slower boxes

[ https://issues.apache.org/jira/browse/QPID-3825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204649#comment-13204649 ] Keith Wall commented on QPID-3825: -- Patch applied. Hi Robbie, can you review please?

[jira] [Commented] (QPID-3820) ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles

[ https://issues.apache.org/jira/browse/QPID-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204617#comment-13204617 ] Keith Wall commented on QPID-3820: -- Patch applied to resolve defect in testcase. Robbie,

[jira] [Commented] (QPID-3512) ConnectionCloseTest occasionally fails on java-mms.0-9-1 profile

[ https://issues.apache.org/jira/browse/QPID-3512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204574#comment-13204574 ] Keith Wall commented on QPID-3512: -- The change to AMQStateManager were backout by QPID-381

[jira] [Commented] (QPID-3819) ExhaustiveACLTests can timeout (but still pass) during teardown [0-9-1]

[ https://issues.apache.org/jira/browse/QPID-3819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204570#comment-13204570 ] Keith Wall commented on QPID-3819: -- Patch applied, Robbie can you review please?

[jira] [Commented] (QPID-3819) ExhaustiveACLTests can timeout (but still pass) during teardown [0-9-1]

[ https://issues.apache.org/jira/browse/QPID-3819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204506#comment-13204506 ] Keith Wall commented on QPID-3819: -- This problem was caused by the changes made to AMQStat

[jira] [Commented] (QPID-3820) ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles

[ https://issues.apache.org/jira/browse/QPID-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202839#comment-13202839 ] Keith Wall commented on QPID-3820: -- Whilst I have not been able to successfully reproduce

[jira] [Commented] (QPID-3818) Replace CombinedTest with a simpler JMSReplyToTest

[ https://issues.apache.org/jira/browse/QPID-3818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202252#comment-13202252 ] Keith Wall commented on QPID-3818: -- Hi Robbie, could you review this commit please?

[jira] [Commented] (QPID-3807) Improve the thread safety of JMS session dispatcher

[ https://issues.apache.org/jira/browse/QPID-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201405#comment-13201405 ] Keith Wall commented on QPID-3807: -- It seems to me that the only explanation for QPID-3872

[jira] [Commented] (QPID-3756) ManagedConnectionMBeanTest.testChannels fails on 0-10 spawned profiles

[ https://issues.apache.org/jira/browse/QPID-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201280#comment-13201280 ] Keith Wall commented on QPID-3756: -- I've committed a patch to change the Broker side behav

[jira] [Commented] (QPID-3775) Automate the manual persistent store tests

[ https://issues.apache.org/jira/browse/QPID-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201229#comment-13201229 ] Keith Wall commented on QPID-3775: -- I've changed the two BDB scripts to avoid use of readl

[jira] [Commented] (QPID-3756) ManagedConnectionMBeanTest.testChannels fails on 0-10 spawned profiles

[ https://issues.apache.org/jira/browse/QPID-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200726#comment-13200726 ] Keith Wall commented on QPID-3756: -- I've attached a patch to ConnectionDelegate.java to re

[jira] [Commented] (QPID-3812) [Java] ExceptionListenerTest sporadically fails on java-mms-0.10

[ https://issues.apache.org/jira/browse/QPID-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200538#comment-13200538 ] Keith Wall commented on QPID-3812: -- This is a race condition. The Broker is sending the C

[jira] [Commented] (QPID-1426) [Java] ExceptionListenerTest Failure

[ https://issues.apache.org/jira/browse/QPID-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200526#comment-13200526 ] Keith Wall commented on QPID-1426: -- It seems to me this is a new issue as it affects 0-10,

[jira] [Commented] (QPID-3810) [Java broker] stop the acceptor thread exiting when encountering IOExceptions such as too many open files

[ https://issues.apache.org/jira/browse/QPID-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200514#comment-13200514 ] Keith Wall commented on QPID-3810: -- Changes look fine, but I've just noticed the switch in

[jira] [Commented] (QPID-3810) [Java broker] stop the acceptor thread exiting when encountering IOExceptions such as too many open files

[ https://issues.apache.org/jira/browse/QPID-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200381#comment-13200381 ] Keith Wall commented on QPID-3810: -- Hi Robbie, A couple of comments, most of which could

[jira] [Commented] (QPID-3175) SSL support in Python client libraries

[ https://issues.apache.org/jira/browse/QPID-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197121#comment-13197121 ] Keith Wall commented on QPID-3175: -- I think the change of the default SASL mechanism to AN

[jira] [Commented] (QPID-3784) Add special JVM environment variable to run dispatcher thread as daemon/non deamon depending from its value.

[ https://issues.apache.org/jira/browse/QPID-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195470#comment-13195470 ] Keith Wall commented on QPID-3784: -- I think we should document the new parameter in the Pr

[jira] [Commented] (QPID-3775) Automate the manual persistent store tests

[ https://issues.apache.org/jira/browse/QPID-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195467#comment-13195467 ] Keith Wall commented on QPID-3775: -- Committed patch to correct the argument/QPID_HOME hand

[jira] [Commented] (QPID-3775) Automate the manual persistent store tests

[ https://issues.apache.org/jira/browse/QPID-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195261#comment-13195261 ] Keith Wall commented on QPID-3775: -- Patch applied. > Automate the manual

[jira] [Commented] (QPID-3559) SimpleDateFormat used in thread unsafe manner in JMX interface

[ https://issues.apache.org/jira/browse/QPID-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194202#comment-13194202 ] Keith Wall commented on QPID-3559: -- Addressed review comments (finally - sorry, slipped my

[jira] [Commented] (QPID-3756) ManagedConnectionMBeanTest.testChannels fails on 0-10 spawned profiles

[ https://issues.apache.org/jira/browse/QPID-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190928#comment-13190928 ] Keith Wall commented on QPID-3756: -- My patch has only reduced the window in which this pro

[jira] [Commented] (QPID-3768) Test org.apache.qpid.server.queue.SortedQueueTest.testGetNextWithAck fails sporadically on CI

[ https://issues.apache.org/jira/browse/QPID-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188811#comment-13188811 ] Keith Wall commented on QPID-3768: -- Patch applied. > Test org.apache.qpid

[jira] [Commented] (QPID-3756) ManagedConnectionMBeanTest.testChannels fails on 0-10 spawned profiles

[ https://issues.apache.org/jira/browse/QPID-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185657#comment-13185657 ] Keith Wall commented on QPID-3756: -- Problem is that there is a race condition between the

[jira] [Commented] (QPID-3697) SortedQueue synchronization causes deadlock

[ https://issues.apache.org/jira/browse/QPID-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185615#comment-13185615 ] Keith Wall commented on QPID-3697: -- Patch applied. > SortedQueue synchron

[jira] [Commented] (QPID-3747) PrefetchBehaviourTest.testLowPrefetchCausesMessagesToBeDistributedBetweenConsumers occasionally fails on spawned profiles.

[ https://issues.apache.org/jira/browse/QPID-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185611#comment-13185611 ] Keith Wall commented on QPID-3747: -- Hi Robbie, Changes made as discussed, cheers, Keith.

[jira] [Commented] (QPID-3635) AMQQConnectionTest incorrect assumes an order in which the tests are run

[ https://issues.apache.org/jira/browse/QPID-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184953#comment-13184953 ] Keith Wall commented on QPID-3635: -- Patch applied to generally make these test case more s

[jira] [Commented] (QPID-3747) AMQConnectionTest#testPrefetchSystemProperty occasionally fails on spawned profiles.

[ https://issues.apache.org/jira/browse/QPID-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184832#comment-13184832 ] Keith Wall commented on QPID-3747: -- This seems to be a Java Broker bug affecting 0-10 only

[jira] [Commented] (QPID-3604) If the connection is stopped the client should release all it's messages in the prefetch buffer

[ https://issues.apache.org/jira/browse/QPID-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183947#comment-13183947 ] Keith Wall commented on QPID-3604: -- Hi Rajith It seems this commit is causing may failing

[jira] [Commented] (QPID-3704) SortedQueueTest.testTransactedSortedQueue failing occasionally on 0-9-1 profile

[ https://issues.apache.org/jira/browse/QPID-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180551#comment-13180551 ] Keith Wall commented on QPID-3704: -- Patch applied. > SortedQueueTest.test

[jira] [Commented] (QPID-3704) SortedQueueTest.testTransactedSortedQueue failing occasionally on 0-9-1 profile

[ https://issues.apache.org/jira/browse/QPID-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180249#comment-13180249 ] Keith Wall commented on QPID-3704: -- Problem is a race condition between an incoming enqueu

[jira] [Commented] (QPID-3566) ConnectionCloseTest fails with spurious thread creation

[ https://issues.apache.org/jira/browse/QPID-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179956#comment-13179956 ] Keith Wall commented on QPID-3566: -- With the removal of MINA, the test case ConnectionClo

[jira] [Commented] (QPID-3715) On receiving an empty ObjectMessage java client hangs forever

[ https://issues.apache.org/jira/browse/QPID-3715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179579#comment-13179579 ] Keith Wall commented on QPID-3715: -- Isn't it because an implementation of InputStream#read

[jira] [Commented] (QPID-3715) On receiving an empty ObjectMessage java client hangs forever

[ https://issues.apache.org/jira/browse/QPID-3715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179498#comment-13179498 ] Keith Wall commented on QPID-3715: -- Hi Alex, I can't fault your implementation, but I won

[jira] [Commented] (QPID-3714) [Java] Performance Improvements

[ https://issues.apache.org/jira/browse/QPID-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179460#comment-13179460 ] Keith Wall commented on QPID-3714: -- The MessageEchoTests are provoking a different NPE: {

[jira] [Commented] (QPID-464) Fix Broker Exception Handling

[ https://issues.apache.org/jira/browse/QPID-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179436#comment-13179436 ] Keith Wall commented on QPID-464: - I think the new uncaught exception handler should also tr

[jira] [Commented] (QPID-3714) [Java] Performance Improvements

[ https://issues.apache.org/jira/browse/QPID-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179415#comment-13179415 ] Keith Wall commented on QPID-3714: -- It appears there is an issue with the new publish acce

[jira] [Commented] (QPID-3710) Java codec doesn't support datetime packed in a map/list

[ https://issues.apache.org/jira/browse/QPID-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175987#comment-13175987 ] Keith Wall commented on QPID-3710: -- I don't think this is a defect. java.util.Date is not

[jira] [Commented] (QPID-3707) Unbind queue causes connection failure when using AMQP 0-9-1

[ https://issues.apache.org/jira/browse/QPID-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175088#comment-13175088 ] Keith Wall commented on QPID-3707: -- Hello Frank, Yes, I agree, this is a defect in the Qu

[jira] [Commented] (QPID-3698) org.apache.qpid.server.store.MessageStoreShutdownTest occasionally fails on Jenkins CI

[ https://issues.apache.org/jira/browse/QPID-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173265#comment-13173265 ] Keith Wall commented on QPID-3698: -- Hi Robbie, would you mind reviewing this commit?

[jira] [Commented] (QPID-3698) org.apache.qpid.server.store.MessageStoreShutdownTest occasionally fails on Jenkins CI

[ https://issues.apache.org/jira/browse/QPID-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173213#comment-13173213 ] Keith Wall commented on QPID-3698: -- I think this is a problem with the test, which has bee

[jira] [Commented] (QPID-3683) FailoverBehaviourTest.testPublishClientAcknowledgedWithFailoverMutex/testPublishTransactedAcknowledgedWithFailoverMutex failing regularly on Jenkins.

[ https://issues.apache.org/jira/browse/QPID-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170956#comment-13170956 ] Keith Wall commented on QPID-3683: -- This is a Broker side problem that only manifests its

[jira] [Commented] (QPID-3691) Failover should sync once before indicating successfully failing comepletion

[ https://issues.apache.org/jira/browse/QPID-3691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170951#comment-13170951 ] Keith Wall commented on QPID-3691: -- Patch applied. > Failover should sync

[jira] [Commented] (QPID-3682) Shutdown Plugin Improvements

[ https://issues.apache.org/jira/browse/QPID-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170950#comment-13170950 ] Keith Wall commented on QPID-3682: -- Patch commited. Andrew could you please review?

[jira] [Commented] (QPID-3683) FailoverBehaviourTest.testPublishClientAcknowledgedWithFailoverMutex/testPublishTransactedAcknowledgedWithFailoverMutex failing regularly on Jenkins.

[ https://issues.apache.org/jira/browse/QPID-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169345#comment-13169345 ] Keith Wall commented on QPID-3683: -- It appears that the failing cases are suffering a Con

[jira] [Commented] (QPID-3672) Occasional NPE with Qpid Management Console when connecting to new server

[ https://issues.apache.org/jira/browse/QPID-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166317#comment-13166317 ] Keith Wall commented on QPID-3672: -- I think we should change NavigationView#addManagedBean

[jira] [Commented] (QPID-3631) The "Programming in Apache Qpid" book does not cover all Java Connection URL options

[ https://issues.apache.org/jira/browse/QPID-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161258#comment-13161258 ] Keith Wall commented on QPID-3631: -- I've updated the "Programming in Qpid" docbook to incl

[jira] [Commented] (QPID-3601) Failure to delete queue on a broker shutdown

[ https://issues.apache.org/jira/browse/QPID-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160061#comment-13160061 ] Keith Wall commented on QPID-3601: -- Hi Robbie, can you review this change please?

[jira] [Commented] (QPID-3649) SlowConsumerDetection continues to check (and holds references to) deleted queues

[ https://issues.apache.org/jira/browse/QPID-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159943#comment-13159943 ] Keith Wall commented on QPID-3649: -- I've noticed other places where this problem manifests

[jira] [Commented] (QPID-3642) Implement Dead Letter Queue functionality

[ https://issues.apache.org/jira/browse/QPID-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157187#comment-13157187 ] Keith Wall commented on QPID-3642: -- Hi Alex/Andy My only comment is that AMQBrokerManager

[jira] [Commented] (QPID-3642) Implement Dead Letter Queue functionality

[ https://issues.apache.org/jira/browse/QPID-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156691#comment-13156691 ] Keith Wall commented on QPID-3642: -- Hi Alex Couple of comments: 1) Can you extract the s

[jira] [Commented] (QPID-3641) ACLV2 Simplifications and Improvements for Java Broker

[ https://issues.apache.org/jira/browse/QPID-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156638#comment-13156638 ] Keith Wall commented on QPID-3641: -- Improvements and simplifications to ACL V2 for the Jav

[jira] [Commented] (QPID-3426) Tes org.apache.qpid.test.client.failover.FailoverTest#test4MinuteFailover is broken

[ https://issues.apache.org/jira/browse/QPID-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154967#comment-13154967 ] Keith Wall commented on QPID-3426: -- Patch applied to remove test case. >

[jira] [Commented] (QPID-3576) Test AddressBasedDestinationTest#testDeleteOptions fails against CPP broker occasionally

[ https://issues.apache.org/jira/browse/QPID-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151093#comment-13151093 ] Keith Wall commented on QPID-3576: -- I think this is a Java client bug rather than a defect

[jira] [Commented] (QPID-3576) Test AddressBasedDestinationTest#testDeleteOptions fails against CPP broker occasionally

[ https://issues.apache.org/jira/browse/QPID-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148856#comment-13148856 ] Keith Wall commented on QPID-3576: -- It would appear that this failure has just become much

[jira] [Commented] (QPID-3490) the default exchange should not be implemented as just a regular direct exchange

[ https://issues.apache.org/jira/browse/QPID-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148392#comment-13148392 ] Keith Wall commented on QPID-3490: -- Patch applied. > the default exchange

[jira] [Commented] (QPID-3575) session exceptions do not properly close connections, causing connections leak

[ https://issues.apache.org/jira/browse/QPID-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147550#comment-13147550 ] Keith Wall commented on QPID-3575: -- Alex and I spent some time looking at this issue. We

[jira] [Commented] (QPID-3552) Run python client test suite on Apache Jenkins instance

[ https://issues.apache.org/jira/browse/QPID-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147365#comment-13147365 ] Keith Wall commented on QPID-3552: -- Python Tests now running against the Java Broker (inc

[jira] [Commented] (QPID-3536) Topic Session Rollback/Recover does not work when using ADDR address destinations

[ https://issues.apache.org/jira/browse/QPID-3536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143189#comment-13143189 ] Keith Wall commented on QPID-3536: -- Thanks Rajith. > The flip side is that this prevents

[jira] [Commented] (QPID-3560) Run java client test suite against cpp broker on Apache Jenkins instance

[ https://issues.apache.org/jira/browse/QPID-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143170#comment-13143170 ] Keith Wall commented on QPID-3560: -- Lock now created and jobs Qpid-Java-Cpp-Test and Qpid-

[jira] [Commented] (QPID-3560) Run java client test suite against cpp broker on Apache Jenkins instance

[ https://issues.apache.org/jira/browse/QPID-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142999#comment-13142999 ] Keith Wall commented on QPID-3560: -- Good point, I've put in a request for a Qpid lock.

[jira] [Commented] (QPID-3566) ConnectionCloseTest fails with spurious thread creation

[ https://issues.apache.org/jira/browse/QPID-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141068#comment-13141068 ] Keith Wall commented on QPID-3566: -- I can see from the test output that the test profile w

[jira] [Commented] (QPID-3560) Run java client test suite against cpp broker on Apache Jenkins instance

[ https://issues.apache.org/jira/browse/QPID-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139815#comment-13139815 ] Keith Wall commented on QPID-3560: -- Currently the Ubuntu slaves are missing one or more bu

[jira] [Commented] (QPID-3516) Docbook recent changes to Java client system properties

[ https://issues.apache.org/jira/browse/QPID-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128466#comment-13128466 ] Keith Wall commented on QPID-3516: -- Changes applied to Programming-In-Apache-Qpid and AMQ

[jira] [Commented] (QPID-3274) Jenkins CI - JMX test failures under Solaris

[ https://issues.apache.org/jira/browse/QPID-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128133#comment-13128133 ] Keith Wall commented on QPID-3274: -- Setting -Djava.rmi.server.hostname=localhost does not

[jira] [Commented] (QPID-2442) make TemporaryQueue.delete perform the delete on the broker

[ https://issues.apache.org/jira/browse/QPID-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122145#comment-13122145 ] Keith Wall commented on QPID-2442: -- Hi Robbie, Now committed with your suggested changes.

[jira] [Commented] (QPID-3516) Docbook recent changes to Java client system properties

[ https://issues.apache.org/jira/browse/QPID-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120867#comment-13120867 ] Keith Wall commented on QPID-3516: -- >From best I can tell, amqj.sendBufferSize and amqj.re

[jira] [Commented] (QPID-3513) Avoid use of shell script clean-dir during test cycle

[ https://issues.apache.org/jira/browse/QPID-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117369#comment-13117369 ] Keith Wall commented on QPID-3513: -- Hi Robbie, As discussed.. I resolved the licence typo

[jira] [Commented] (QPID-3512) ConnectionCloseTest occasionally fails on java-mms.0-9-1 profile

[ https://issues.apache.org/jira/browse/QPID-3512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116499#comment-13116499 ] Keith Wall commented on QPID-3512: -- This is a race condition on the client side occurring

[jira] [Commented] (QPID-3444) the Java broker does not reject 0-10 exchange delete/bind/unbind commands which use empty strings for the exchange name

[ https://issues.apache.org/jira/browse/QPID-3444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114988#comment-13114988 ] Keith Wall commented on QPID-3444: -- Hi Robbie Can't a client subvert the check by passing