[GitHub] qpid-dispatch issue #420: DISPATCH-1177 - Added new option -e to qdstat. Thi...

2018-11-14 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/420 @ganeshmurthy I have executed qdstat with -e on a formed network here and I see the "edge" routers from an interior router, and the "interior" router when executed ag

[GitHub] qpid-dispatch pull request #414: DISPATCH-1170 - Fix for system tests execut...

2018-11-05 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/414 DISPATCH-1170 - Fix for system tests execution on python3 only machines You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti

[GitHub] qpid-dispatch pull request #412: DISPATCH-1164 - Modified config.sh to work ...

2018-10-31 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/412 DISPATCH-1164 - Modified config.sh to work with python3 only You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti/qpid-dispatch

[GitHub] qpid-dispatch pull request #369: DISPATCH-1112 - Detach takes a higher prior...

2018-08-31 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/369 DISPATCH-1112 - Detach takes a higher priority when processing link work You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti

[GitHub] qpid-dispatch pull request #352: DISPATCH-1095 - Only adding SASL listener w...

2018-08-03 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/352 DISPATCH-1095 - Only adding SASL listener when SASL available This might resolve the tearDown issue when SASL is not available. You can merge this pull request into a Git repository by

[GitHub] qpid-dispatch pull request #351: DISPATCH-1095 - Improved SkipIfNeeded decor...

2018-08-02 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/351 DISPATCH-1095 - Improved SkipIfNeeded decorator and added it to metho… …ds using SASL when it is not installed You can merge this pull request into a Git repository by running

[GitHub] qpid-dispatch pull request #343: DISPATCH-1067 - updates to policy doc (upda...

2018-07-16 Thread fgiorgetti
Github user fgiorgetti commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/343#discussion_r202810977 --- Diff: docs/books/user-guide/configuration-security.adoc --- @@ -442,290 +442,367 @@ For more information about these attributes, see

[GitHub] qpid-dispatch pull request #343: DISPATCH-1067 - updates to policy doc (upda...

2018-07-16 Thread fgiorgetti
Github user fgiorgetti commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/343#discussion_r202826844 --- Diff: docs/books/user-guide/configuration-security.adoc --- @@ -734,57 +811,57 @@ vhost { <3> Any user can connect to this

[GitHub] qpid-dispatch pull request #343: DISPATCH-1067 - updates to policy doc (upda...

2018-07-16 Thread fgiorgetti
Github user fgiorgetti commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/343#discussion_r202826788 --- Diff: docs/books/user-guide/configuration-security.adoc --- @@ -734,57 +811,57 @@ vhost { <3> Any user can connect to this

[GitHub] qpid-dispatch issue #327: DISPATCH-1041 - Add tests to validate each global ...

2018-06-25 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/327 It covers everything now! --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail

[GitHub] qpid-dispatch issue #327: DISPATCH-1041 - Add tests to validate each global ...

2018-06-22 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/327 @ganeshmurthy it looks great to me. One thing I noticed is that the only new metric that is not present in this test is: "acceptedDeliveries". But I see it bei

[GitHub] qpid-dispatch pull request #324: DISPATCH-976 - Fixed issue with policy vali...

2018-06-13 Thread fgiorgetti
Github user fgiorgetti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/324 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #324: DISPATCH-976 - Fixed issue with policy validation ...

2018-06-13 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/324 Done. Seems to be working fine. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands

[GitHub] qpid-dispatch issue #324: DISPATCH-976 - Fixed issue with policy validation ...

2018-06-12 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/324 @ganeshmurthy and @ChugR after debugging it a little bit more, I noticed that the first if statement that checks for an absent user key in the iterating allowed address, was also checking

[GitHub] qpid-dispatch pull request #324: DISPATCH-976 - Fixed issue with policy vali...

2018-06-12 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/324 DISPATCH-976 - Fixed issue with policy validation of allowed addresses You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti

[GitHub] qpid-dispatch pull request #323: DISPATCH-976 - Commenting last assert which...

2018-06-12 Thread fgiorgetti
Github user fgiorgetti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/323 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #323: DISPATCH-976 - Commenting last assert which is cau...

2018-06-12 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/323 I believe I found the reason for the failure. I will provide a new PR and ask Chuck to review it. --- - To unsubscribe

[GitHub] qpid-dispatch pull request #323: DISPATCH-976 - Commenting last assert which...

2018-06-12 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/323 DISPATCH-976 - Commenting last assert which is causing router to crash You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti

[GitHub] qpid-dispatch pull request #320: DISPATCH-976 - System test to validate vhos...

2018-06-08 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/320 DISPATCH-976 - System test to validate vhost policies on source and t… …arget addresses NOTE: If this gets merged before PR#319 and before DISPATCH-1026 is fixed (no PR

[GitHub] qpid-dispatch pull request #319: DISPATCH-1025 - Fixes user token replacemen...

2018-06-07 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/319 DISPATCH-1025 - Fixes user token replacement used in prefix or suffix You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti/qpid

[GitHub] qpid-dispatch pull request #317: DISPATCH-1024 - Fix for system_tests_policy...

2018-06-05 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/317 DISPATCH-1024 - Fix for system_tests_policy urls using user and password You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti

[GitHub] qpid-dispatch pull request #315: DISPATCH-1013 - Enable vhost policies to be...

2018-06-05 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/315 DISPATCH-1013 - Enable vhost policies to be defined on router config You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti/qpid

[GitHub] qpid-dispatch pull request #309: DISPATCH-1013 - Enable vhost policies to be...

2018-06-05 Thread fgiorgetti
Github user fgiorgetti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/309 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #309: DISPATCH-1013 - Enable vhost policies to be...

2018-05-25 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/309 DISPATCH-1013 - Enable vhost policies to be defined on router config You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti/qpid

[GitHub] qpid-dispatch pull request #308: DISPATCH-1005 - Fixed system_tests_ssl.py t...

2018-05-22 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/308 DISPATCH-1005 - Fixed system_tests_ssl.py to work on rhel6 and other … …distros You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] qpid-dispatch pull request #307: DISPATCH-1005 - New system test to validate...

2018-05-22 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/307 DISPATCH-1005 - New system test to validate restriction of TLS protocols You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti

[GitHub] qpid-dispatch pull request #306: DISPATCH-1005 - New system test to validate...

2018-05-22 Thread fgiorgetti
Github user fgiorgetti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/306 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #306: DISPATCH-1005 - New system test to validate...

2018-05-18 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/306 DISPATCH-1005 - New system test to validate restriction of TLS protocols You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti

[GitHub] qpid-dispatch issue #293: DISPATCH-977: Add transaction coordinator step to ...

2018-05-09 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/293 Looks good to me. I have created a simple scenario to validate the coordinator, as described in the doc, and it worked just fine. The final doc looks good as well

[GitHub] qpid-dispatch pull request #302: DISPATCH-992: Fix for system_tests_delivery...

2018-05-08 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/302 DISPATCH-992: Fix for system_tests_delivery_abort.py You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti/qpid-dispatch

[GitHub] qpid-dispatch pull request #301: DISPATCH-927 - System test for fix. Makes s...

2018-05-07 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/301 DISPATCH-927 - System test for fix. Makes sure both detaches are echo… …ed back You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] qpid-dispatch pull request #300: DISPATCH-927 - System test for fix. Makes s...

2018-05-07 Thread fgiorgetti
Github user fgiorgetti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/300 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #300: DISPATCH-927 - System test for fix. Makes s...

2018-05-07 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/300 DISPATCH-927 - System test for fix. Makes sure both detaches are echo… …ed back You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] qpid-dispatch pull request #298: DISPATCH-963 - Added decorator class that c...

2018-05-03 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/298 DISPATCH-963 - Added decorator class that can be used to skip test methods, as unittest2 does not support skipping feature on python 2.6. You can merge this pull request into a Git

[GitHub] qpid-dispatch issue #294: DISPATCH-960 - Resolving service port when using h...

2018-04-27 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/294 Removed as suggested. It seems to be working just fine for me. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] qpid-dispatch pull request #294: DISPATCH-960 - Resolving service port when ...

2018-04-27 Thread fgiorgetti
Github user fgiorgetti commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/294#discussion_r184743211 --- Diff: src/amqp.c --- @@ -73,11 +76,30 @@ const char * const QD_AMQP_COND_FRAME_SIZE_TOO_SMALL = "amqp:frame-size-too-smal const

[GitHub] qpid-dispatch pull request #294: DISPATCH-960 - Resolving service port when ...

2018-04-25 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/294 DISPATCH-960 - Resolving service port when using http listener As suggested by @ted-ross, I am re-submitting this PR again now using getservbyname_r which is multi-thread safe

[GitHub] qpid-dispatch pull request #284: DISPATCH-960 - Resolving service port when ...

2018-04-25 Thread fgiorgetti
Github user fgiorgetti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/284 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #286: DISPATCH-154 - Added new tests to validate ...

2018-04-11 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/286 DISPATCH-154 - Added new tests to validate unresolvable hostname This is the new PR after taking the suggestion of not using sleep and using a Timer instead. You can merge this pull

[GitHub] qpid-dispatch pull request #268: DISPATCH-154 - Added new test case to ensur...

2018-04-11 Thread fgiorgetti
Github user fgiorgetti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/268 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #268: DISPATCH-154 - Added new test case to ensure route...

2018-04-11 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/268 Submitting a new PR for this new test following recommendations. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] qpid-dispatch pull request #285: DISPATCH-154 - Added new tests to validate ...

2018-04-11 Thread fgiorgetti
Github user fgiorgetti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/285 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #285: DISPATCH-154 - Added new tests to validate unresol...

2018-04-11 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/285 Yes I see that as well, but it happens before the connection is established. Right after that I am seeing the error below: 2018-04-11 08:47:15.086037 -0300 CONN_MGR (info

[GitHub] qpid-dispatch pull request #285: DISPATCH-154 - Added new tests to validate ...

2018-04-10 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/285 DISPATCH-154 - Added new tests to validate unresolvable hostname You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti/qpid

[GitHub] qpid-dispatch pull request #284: DISPATCH-960 - Resolving service port when ...

2018-04-10 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/284 DISPATCH-960 - Resolving service port when using http listener You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti/qpid

[GitHub] qpid-dispatch pull request #283: DISPATCH-960 - Resolving service port when ...

2018-04-10 Thread fgiorgetti
Github user fgiorgetti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/283 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #283: DISPATCH-960 - Resolving service port when ...

2018-04-10 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/283 DISPATCH-960 - Resolving service port when using http listener You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti/qpid

[GitHub] qpid-dispatch pull request #282: DISPATCH-911 - Added explicit validation fo...

2018-04-10 Thread fgiorgetti
Github user fgiorgetti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/282 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #282: DISPATCH-911 - Added explicit validation fo...

2018-04-10 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/282 DISPATCH-911 - Added explicit validation for new metric presettledDeliveries All new metrics are being validated by the system tests except for this one. So I have modified one of the

[GitHub] qpid-dispatch pull request #277: DISPATCH-954 - Fixed issue suggested by cov...

2018-04-02 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/277 DISPATCH-954 - Fixed issue suggested by coverity scan tool You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti/qpid-dispatch

[GitHub] qpid-dispatch pull request #276: DISPATCH-954 - Fixed issue suggested by cov...

2018-04-02 Thread fgiorgetti
Github user fgiorgetti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/276 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #276: DISPATCH-954 - Fixed issue suggested by cov...

2018-04-02 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/276 DISPATCH-954 - Fixed issue suggested by coverity scan tool You can merge this pull request into a Git repository by running: $ git pull https://github.com/fgiorgetti/qpid-dispatch

[GitHub] qpid-dispatch issue #269: DISPATCH-938: Remove config ref and add links to q...

2018-03-28 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/269 Can you mark us as reviewers here? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional

[GitHub] qpid-dispatch issue #269: DISPATCH-938: Remove config ref and add links to q...

2018-03-21 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/269 Thanks @bhardesty. We will start with this one. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For

[GitHub] qpid-dispatch pull request #268: DISPATCH-154 - Added new test case to ensur...

2018-03-09 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/268 DISPATCH-154 - Added new test case to ensure router recovers from unresolvable hosts Created a new system test class to run validations on a router that has a connector with an

[GitHub] qpid-dispatch pull request #267: DISPATCH-154 - Added unit test

2018-03-09 Thread fgiorgetti
Github user fgiorgetti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/267 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #267: DISPATCH-154 - Added unit test

2018-03-09 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/267 I will recreate this pull request. This one mistakenly included changes from other PR. --- - To unsubscribe, e-mail

[GitHub] qpid-dispatch pull request #267: Dispatch 154 test

2018-03-09 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/267 Dispatch 154 test Added a unit test to validate the issue, previously reported through DISPATCH-154. It ensures the router is able to react to the problem and remains up and running

[GitHub] qpid-dispatch issue #266: DISPATCH-940 - Allow configuration file to be used...

2018-03-08 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/266 Unit test has been created. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e

[GitHub] qpid-dispatch issue #266: DISPATCH-940 - Allow configuration file to be used...

2018-03-08 Thread fgiorgetti
Github user fgiorgetti commented on the issue: https://github.com/apache/qpid-dispatch/pull/266 I will create a unit test for it. Thanks for the advise on the branch in use. --- - To unsubscribe, e-mail: dev

[GitHub] qpid-dispatch pull request #266: DISPATCH-940 - Allow configuration file to ...

2018-03-08 Thread fgiorgetti
GitHub user fgiorgetti opened a pull request: https://github.com/apache/qpid-dispatch/pull/266 DISPATCH-940 - Allow configuration file to be used from relative path… DISPATCH-940 - Allow configuration file to be used from relative path when running as a daemon. You can merge