[GitHub] [qpid-dispatch] gemmellr commented on a change in pull request #633: Eallen dispatch 1385

2019-11-27 Thread GitBox
gemmellr commented on a change in pull request #633: Eallen dispatch 1385 URL: https://github.com/apache/qpid-dispatch/pull/633#discussion_r351400910 ## File path: console/react/LICENSE ## @@ -0,0 +1,201 @@ + Apache License Review comment:

[GitHub] [qpid-dispatch] gemmellr commented on a change in pull request #633: Eallen dispatch 1385

2019-11-27 Thread GitBox
gemmellr commented on a change in pull request #633: Eallen dispatch 1385 URL: https://github.com/apache/qpid-dispatch/pull/633#discussion_r351368897 ## File path: .gitignore ## @@ -19,7 +19,11 @@ tests/system_tests_handle_failover.py .tox .vscode console/stand-alone/nod

[GitHub] [qpid-dispatch] gemmellr commented on a change in pull request #633: Eallen dispatch 1385

2019-11-27 Thread GitBox
gemmellr commented on a change in pull request #633: Eallen dispatch 1385 URL: https://github.com/apache/qpid-dispatch/pull/633#discussion_r351350093 ## File path: bin/export.sh ## @@ -1,105 +0,0 @@ -#!/bin/bash Review comment: Its not clear this or most of the other

[GitHub] [qpid-dispatch] gemmellr commented on a change in pull request #633: Eallen dispatch 1385

2019-11-27 Thread GitBox
gemmellr commented on a change in pull request #633: Eallen dispatch 1385 URL: https://github.com/apache/qpid-dispatch/pull/633#discussion_r351386165 ## File path: console/react/public/manifest.json ## @@ -0,0 +1,15 @@ +{ + "short_name": "React App", + "name": "Create Rea