[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1515: Dispatch 1487: message annotations re-write (full patch)

2022-02-16 Thread GitBox
jiridanek commented on a change in pull request #1515: URL: https://github.com/apache/qpid-dispatch/pull/1515#discussion_r807646524 ## File path: include/qpid/dispatch/amqp.h ## @@ -19,6 +19,8 @@ * under the License. Review comment: Router seems to be exiting cleanly,

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1515: Dispatch 1487: message annotations re-write (full patch)

2022-02-12 Thread GitBox
jiridanek commented on a change in pull request #1515: URL: https://github.com/apache/qpid-dispatch/pull/1515#discussion_r805144335 ## File path: include/qpid/dispatch/amqp.h ## @@ -19,6 +19,8 @@ * under the License. Review comment: This does not seem to be Jira'd yet

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1515: Dispatch 1487: message annotations re-write (full patch)

2022-02-12 Thread GitBox
jiridanek commented on a change in pull request #1515: URL: https://github.com/apache/qpid-dispatch/pull/1515#discussion_r805144183 ## File path: include/qpid/dispatch/amqp.h ## @@ -19,6 +19,8 @@ * under the License. Review comment: This Arm64 fail. I am not sure if t

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1515: Dispatch 1487: message annotations re-write (full patch)

2022-02-12 Thread GitBox
jiridanek commented on a change in pull request #1515: URL: https://github.com/apache/qpid-dispatch/pull/1515#discussion_r805143945 ## File path: include/qpid/dispatch/amqp.h ## @@ -19,6 +19,8 @@ * under the License. Review comment: https://app.travis-ci.com/github/ap