jiridanek commented on pull request #1476: URL: https://github.com/apache/qpid-dispatch/pull/1476#issuecomment-1011964860
@ganeshmurthy, @kgiusti I think this is overall desirable, but there are some caveats that I'll have to fix. First, the flake8 and pylint things should each have separate PR. Then, some of the flake8 warnings only appear if you have extra flake8 modules installed in your python environment, so I'm actually surprising things that flake8 in tox will not report (because I was running flake8 installed by yum. Meaning the docstring warnings do not actually appear. There the question is, do we want them? Flake8 lines e.g. one-line docstrings if they can be put on one line. That is imo good check, makes docstrings more compact. Enforcing quotes instead of apostrophes in docstrings is also helpful, imo. The other checks, not so much useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
