[GitHub] [qpid-dispatch] jiridanek commented on pull request #744: For review - Server code clean up

2021-02-01 Thread GitBox
jiridanek commented on pull request #744: URL: https://github.com/apache/qpid-dispatch/pull/744#issuecomment-770876947 > Re: pointer declarations: > > Please do this the way Chuck suggests: > > ``` > qd_timer_t *timer; > int count; > ``` > > This is

[GitHub] [qpid-dispatch] jiridanek commented on pull request #744: For review - Server code clean up

2020-10-09 Thread GitBox
jiridanek commented on pull request #744: URL: https://github.com/apache/qpid-dispatch/pull/744#issuecomment-706278074 Thinking back to this, my take regarding reasons why this was not merged was 1} disagreement with the code formatting change (llvm formatter does not support well the

[GitHub] [qpid-dispatch] jiridanek commented on pull request #744: For review - Server code clean up

2020-05-26 Thread GitBox
jiridanek commented on pull request #744: URL: https://github.com/apache/qpid-dispatch/pull/744#issuecomment-63430 Travis job on macOS here is similarly unhappy. This is an automated message from the Apache Git Service.