[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink

2021-05-19 Thread GitBox
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-843984058 That Python test I added last time (the one using asyncio websocket lib) can actually be added upstream now, since Python 3.6 supports async. I looked a bit into simplifyi

[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink

2021-05-09 Thread GitBox
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-835778691 I tried writing a test for shutdown crash with connected websocket in both Python unittest and C++ doctest. The Python unittest runs cca 600 ms start to finish, the C++ do

[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink

2021-05-07 Thread GitBox
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-834840551 ![flamegraph](https://user-images.githubusercontent.com/442720/117516147-8b2ffd80-af98-11eb-9c01-fbea990bb789.png) -- This is an automated message from the Apache Gi

[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink

2021-04-15 Thread GitBox
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-820773051 See the 7 other warnings above this one, they come from doctest itself ;( https://travis-ci.com/github/apache/qpid-dispatch/jobs/498901258#L9490 ``` 74: WAR

[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink

2021-02-27 Thread GitBox
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-787142618 Note to self: probably something I introduced here. I never saw this on master https://github.com/apache/qpid-dispatch/runs/1995248602?check_suite_focus=true#step:9

[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink

2021-02-27 Thread GitBox
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-787125127 Here's a microbenchmark for TCP Echo server latency with and without Dispatch ``` Debug build: -

[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink

2020-12-14 Thread GitBox
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-744490741 and with that, c_unittests has passed on this branch, without failures and leaks This is an automated mes

[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink

2020-12-14 Thread GitBox
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-744303424 It looks like it's necessary to use `qdr_connection_opened` to create a new `qdr_connection_t`, `qdr_create_link_CT` to get a `qdr_link_t`, and so on. These functions set

[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink

2020-10-26 Thread GitBox
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-716464637 @nicob87 Idea is probably good, but the implementation may not be ideal, yet. Setup for this kind of a test takes about 80 ms, because it starts most of the router,

[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink

2020-10-22 Thread GitBox
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-714744094 Faster router startup using BetterRouterStartupLatch to wait for the core thread. It is a bit convoluted, because C function pointers do not work with C++ capturing lambda

[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink

2020-10-20 Thread GitBox
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-713054654 Its working, its working... more or less. The test to add autoLink through management message really adds an autoLink, and can do it without any network communication! And

[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink

2020-10-19 Thread GitBox
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-711811150 ``` 69: Error performing CREATE of org.apache.qpid.dispatch.router.config.autoLink: addr and direction fields are mandatory 69: Error configuring linkRoute: addr and

[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink

2020-10-15 Thread GitBox
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-709332660 And @nicob87, what do you thing? This is an automated message from the Apache Git Service. To respond to t