jiridanek opened a new pull request #1101: URL: https://github.com/apache/qpid-dispatch/pull/1101
1. UBSAN is not killing the process the moment undefined behavior is detected. This is easily fixed by doing `set(RUNTIME_UBSAN_ENV_OPTIONS "halt_on_error=1 abort_on_error=1")`, but then the tests timeout all the time. Not useful. 2. UBSAN is not printing diagnostics. That is fixed by doing `set(RUNTIME_UBSAN_ENV_OPTIONS "print_stacktrace=1 print_summary=1")` 3. ASAN has extra checks that can be enabled. Enabling them does not find any new issues, so far. But it sounds like a sensible thing to turn on, for the future. `set(RUNTIME_ASAN_ENV_OPTIONS "strict_string_checks=1 detect_stack_use_after_return=1 check_initialization_order=1 strict_init_order=1")` 4. System tests don't print `.out` files produced by running routers, even if there are messages from sanitizers in them. Let's fix that. This means that tests become _quite_ chatty. Maybe not something that should be turned on forever, but now it's good to see the UBSAN messages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
