[GitHub] [qpid-dispatch] ted-ross commented on pull request #731: DISPATCH-781 - Work in Progress - Do not merge.

2020-05-06 Thread GitBox
ted-ross commented on pull request #731: URL: https://github.com/apache/qpid-dispatch/pull/731#issuecomment-624661094 > One suggestion: The logic that adds/removes the link_ref to the qdr_address_t (QDR_LINK_CLASS_ADDRESS) by checking the initial_credit_received value is repeated across a

[GitHub] [qpid-dispatch] ted-ross commented on pull request #731: DISPATCH-781 - Work in Progress - Do not merge.

2020-05-05 Thread GitBox
ted-ross commented on pull request #731: URL: https://github.com/apache/qpid-dispatch/pull/731#issuecomment-624285529 Note that there is a new test for end-to-end flow control that fails with this patch. The test won't pass until the whole solution is completed. -