DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r619688242
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,139 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r619691844
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,139 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r619688242
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,139 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r618232507
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,139 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r618229224
##
File path: cpp/src/sender.cpp
##
@@ -64,10 +64,18 @@ namespace {
uint64_t tag_counter = 0;
Review comment:
Okay. Done!
--
This is
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r617722938
##
File path: cpp/src/sender.cpp
##
@@ -66,8 +66,15 @@ uint64_t tag_counter = 0;
tracker sender::send(const message ) {
uint64_t id =
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r617699833
##
File path: cpp/include/proton/sender.hpp
##
@@ -55,7 +55,7 @@ PN_CPP_CLASS_EXTERN sender : public link {
PN_CPP_EXTERN void open(const
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616446834
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,139 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616144888
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,139 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616091512
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,139 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615825219
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,139 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615813070
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,132 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615806807
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,132 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615805220
##
File path: cpp/src/sender.cpp
##
@@ -64,10 +64,18 @@ namespace {
uint64_t tag_counter = 0;
Review comment:
Thanks, I will take a look.
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615804137
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,115 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615803509
##
File path: cpp/src/delivery.cpp
##
@@ -40,6 +42,7 @@ namespace proton {
delivery::delivery(pn_delivery_t* d): transfer(make_wrapper(d)) {}
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615458277
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,115 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615455343
##
File path: cpp/src/sender.cpp
##
@@ -64,10 +64,18 @@ namespace {
uint64_t tag_counter = 0;
Review comment:
Should I file the bug for
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615455111
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,115 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
DreamPearl commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615454611
##
File path: cpp/src/delivery_test.cpp
##
@@ -0,0 +1,115 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
20 matches
Mail list logo
