[GitHub] [qpid-proton] astitcher commented on a change in pull request #278: PROTON-2307 Allow access to connection properties in cpp binding

2021-01-26 Thread GitBox
astitcher commented on a change in pull request #278: URL: https://github.com/apache/qpid-proton/pull/278#discussion_r564574586 ## File path: cpp/src/connection.cpp ## @@ -192,6 +193,15 @@ std::vector connection::desired_capabilities() const { return get_multiple

[GitHub] [qpid-proton] astitcher commented on a change in pull request #278: PROTON-2307 Allow access to connection properties in cpp binding

2021-01-25 Thread GitBox
astitcher commented on a change in pull request #278: URL: https://github.com/apache/qpid-proton/pull/278#discussion_r563847919 ## File path: cpp/src/container_test.cpp ## @@ -179,6 +181,22 @@ int test_container_capabilities() {

[GitHub] [qpid-proton] astitcher commented on a change in pull request #278: PROTON-2307 Allow access to connection properties in cpp binding

2021-01-25 Thread GitBox
astitcher commented on a change in pull request #278: URL: https://github.com/apache/qpid-proton/pull/278#discussion_r563851777 ## File path: cpp/src/connection.cpp ## @@ -192,6 +193,13 @@ std::vector connection::desired_capabilities() const { return get_multiple

[GitHub] [qpid-proton] astitcher commented on a change in pull request #278: PROTON-2307 Allow access to connection properties in cpp binding

2021-01-25 Thread GitBox
astitcher commented on a change in pull request #278: URL: https://github.com/apache/qpid-proton/pull/278#discussion_r563847919 ## File path: cpp/src/container_test.cpp ## @@ -179,6 +181,22 @@ int test_container_capabilities() {

[GitHub] [qpid-proton] astitcher commented on a change in pull request #278: PROTON-2307 Allow access to connection properties in cpp binding

2021-01-22 Thread GitBox
astitcher commented on a change in pull request #278: URL: https://github.com/apache/qpid-proton/pull/278#discussion_r562648794 ## File path: cpp/src/container_test.cpp ## @@ -179,6 +181,22 @@ int test_container_capabilities() {

[GitHub] [qpid-proton] astitcher commented on a change in pull request #278: PROTON-2307 Allow access to connection properties in cpp binding

2021-01-21 Thread GitBox
astitcher commented on a change in pull request #278: URL: https://github.com/apache/qpid-proton/pull/278#discussion_r562302674 ## File path: cpp/src/container_test.cpp ## @@ -179,6 +181,22 @@ int test_container_capabilities() {

[GitHub] [qpid-proton] astitcher commented on a change in pull request #278: PROTON-2307 Allow access to connection properties in cpp binding

2021-01-21 Thread GitBox
astitcher commented on a change in pull request #278: URL: https://github.com/apache/qpid-proton/pull/278#discussion_r562302674 ## File path: cpp/src/container_test.cpp ## @@ -179,6 +181,22 @@ int test_container_capabilities() {