[GitHub] [qpid-proton] astitcher commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-21 Thread GitBox
astitcher commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r617735700 ## File path: cpp/src/sender.cpp ## @@ -64,10 +64,18 @@ namespace { uint64_t tag_counter = 0; } -tracker sender::send(const message ) { -

[GitHub] [qpid-proton] astitcher commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-20 Thread GitBox
astitcher commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616843329 ## File path: cpp/src/sender.cpp ## @@ -64,10 +64,18 @@ namespace { uint64_t tag_counter = 0; Review comment: tag_counter is effectively a