[GitHub] [qpid-proton] astitcher commented on a diff in pull request #379: PROTON-2438: [cpp] Cancellable tasks

2022-10-27 Thread GitBox
astitcher commented on code in PR #379: URL: https://github.com/apache/qpid-proton/pull/379#discussion_r1006800975 ## cpp/src/container_test.cpp: ## @@ -40,6 +40,7 @@ #include #include #include +#include Review Comment: I'm confused - This still seems to be in the PR

[GitHub] [qpid-proton] astitcher commented on a diff in pull request #379: PROTON-2438: [cpp] Cancellable tasks

2022-10-20 Thread GitBox
astitcher commented on code in PR #379: URL: https://github.com/apache/qpid-proton/pull/379#discussion_r1000577861 ## cpp/src/container_test.cpp: ## @@ -574,6 +575,119 @@ void test_container_mt_close_race() { } } +class schedule_cancel : public proton::messaging_handler

[GitHub] [qpid-proton] astitcher commented on a diff in pull request #379: PROTON-2438: [cpp] Cancellable tasks

2022-10-06 Thread GitBox
astitcher commented on code in PR #379: URL: https://github.com/apache/qpid-proton/pull/379#discussion_r988994668 ## cpp/src/container_test.cpp: ## @@ -574,6 +574,45 @@ void test_container_mt_close_race() { } } +class schedule_cancel : public proton::messaging_handler {