[GitHub] [qpid-proton] jiridanek commented on a diff in pull request #397: PROTON-2714: add annotations for printf-like format strings and fix linux compiler warnings

2023-04-20 Thread via GitHub
jiridanek commented on code in PR #397: URL: https://github.com/apache/qpid-proton/pull/397#discussion_r1172631582 ## c/include/proton/annotations.h: ## @@ -0,0 +1,93 @@ +#ifndef PROTON_ANNOTATIONS_H +#define PROTON_ANNOTATIONS_H 1 + +/* + * Copyright (c) Meta Platforms, Inc. an

[GitHub] [qpid-proton] jiridanek commented on a diff in pull request #397: PROTON-2714: add annotations for printf-like format strings and fix linux compiler warnings

2023-04-20 Thread via GitHub
jiridanek commented on code in PR #397: URL: https://github.com/apache/qpid-proton/pull/397#discussion_r1172626808 ## c/include/proton/annotations.h: ## @@ -0,0 +1,93 @@ +#ifndef PROTON_ANNOTATIONS_H +#define PROTON_ANNOTATIONS_H 1 + +/* + * Copyright (c) Meta Platforms, Inc. an

[GitHub] [qpid-proton] jiridanek commented on a diff in pull request #397: PROTON-2714: add annotations for printf-like format strings and fix linux compiler warnings

2023-04-20 Thread via GitHub
jiridanek commented on code in PR #397: URL: https://github.com/apache/qpid-proton/pull/397#discussion_r1172624502 ## c/include/proton/annotations.h: ## @@ -0,0 +1,93 @@ +#ifndef PROTON_ANNOTATIONS_H +#define PROTON_ANNOTATIONS_H 1 + +/* + * Copyright (c) Meta Platforms, Inc. an