[GitHub] qpid-jms issue #22: QPIDJMS-417 Reduce GC pressure while using BytesMessage

2018-10-10 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/qpid-jms/pull/22 @gemmellr > Can you elaborate on the benefits you measured here? I'd like to understand the extent to consider against the downside of exposing dep impl types throughout the code base.

[GitHub] qpid-jms issue #22: QPIDJMS-417 Reduce GC pressure while using BytesMessage

2018-10-10 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/qpid-jms/pull/22 Can you elaborate on the benefits you measured here? I'd like to understand the extent to consider against the downside of exposing dep impl types throughout the code base. The existing bi

[GitHub] qpid-jms issue #22: QPIDJMS-417 Reduce GC pressure while using BytesMessage

2018-10-10 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/qpid-jms/pull/22 @gemmellr @tabish121 I'm not very proud to have exposed directly the ByteBuf streams, but I have tried to use the right type on the facade and it makes the code really unreadable (and confuse the