[GitHub] qpid-proton-j issue #2: Delivery link leak

2017-02-13 Thread jkamke
Github user jkamke commented on the issue: https://github.com/apache/qpid-proton-j/pull/2 @gemmellr Your Patch also solves the issue, all my test verify this. Please go ahead, Thanks. Also, the case where the bi-directional links do not agree is an invalid state for this model. Any

[GitHub] qpid-proton-j issue #2: Delivery link leak

2017-02-13 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/qpid-proton-j/pull/2 I've raised #3 with some alternative changes, which are essentially just a subset of yours with a different test. One of the changes here would corrupt the linkPrev/next entries chain, which

[GitHub] qpid-proton-j issue #2: Delivery link leak

2017-02-09 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/qpid-proton-j/pull/2 I've had a closer look at this now, sorry it took so long. I'm not sure about some of the changes, I'm going to give it a furhter look tomorrow to either establish I'm wrong, or suggest some