[
https://issues.apache.org/jira/browse/DISPATCH-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123577#comment-16123577
]
ASF subversion and git services commented on DISPATCH-805:
----------------------------------------------------------
Commit d1838e6b6dde4fd5aa7dd715b5cc60a70c2e033e in qpid-dispatch's branch
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=d1838e6 ]
DISPATCH-805 - Fixed the assert on system_tests_sasl_plain.py in order to not
hard code TLS version
> System test system_tests_sasl_plain fails in systems with TLSv1.2
> -----------------------------------------------------------------
>
> Key: DISPATCH-805
> URL: https://issues.apache.org/jira/browse/DISPATCH-805
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Routing Engine, Tests
> Affects Versions: 0.8.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Fix For: 1.0.0
>
>
> A couple of tests in system_tests_sasl_plain.py tests for hard coded string
> *TLSv1/SSLv3* as the TLS version. The version of TLS can vary. It could be
> *TLSv1.2*
> Instead of asserting
> {noformat}
> self.assertEqual(u'TLSv1/SSLv3', results[0][10])
> {noformat}
> we should do
> {noformat}
> self.assertTrue(u'TLSv1' in results[0][10])
> {noformat}
> Following is the trace from the failing test
> {noformat}
> 24: ======================================================================
> 24: FAIL: test_inter_router_plain_over_ssl_exists
> (system_tests_sasl_plain.RouterTestVerifyHostNameNo)
> 24: ----------------------------------------------------------------------
> 24: Traceback (most recent call last):
> 24: File "/foo/qpid-dispatch/tests/system_tests_sasl_plain.py", line 525,
> in test_inter_router_plain_over_ssl_exists
> 24: self.common_asserts(results)
> 24: File "/foo/qpid-dispatch/tests/system_tests_sasl_plain.py", line 503,
> in common_asserts
> 24: self.assertEqual(u'TLSv1/SSLv3', results[N][10])
> 24: AssertionError: u'TLSv1/SSLv3' != u'TLSv1.2'
> 24: - TLSv1/SSLv3
> 24: + TLSv1.2
> 24:
> 24:
> 24: ======================================================================
> 24: FAIL: test_zzz_delete_create_ssl_profile
> (system_tests_sasl_plain.RouterTestVerifyHostNameNo)
> 24: ----------------------------------------------------------------------
> 24: Traceback (most recent call last):
> 24: File "/foo/qpid-dispatch/tests/system_tests_sasl_plain.py", line 564,
> in test_zzz_delete_create_ssl_profile
> 24: self.common_asserts(results)
> 24: File "/foo/qpid-dispatch/tests/system_tests_sasl_plain.py", line 503,
> in common_asserts
> 24: self.assertEqual(u'TLSv1/SSLv3', results[N][10])
> 24: AssertionError: u'TLSv1/SSLv3' != u'TLSv1.2'
> 24: - TLSv1/SSLv3
> 24: + TLSv1.2
> 24:
> 24:
> 24: ----------------------------------------------------------------------
> 24: Ran 8 tests in 15.760s
> 24:
> 24: FAILED (failures=3)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
