[ https://issues.apache.org/jira/browse/PROTON-2554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550581#comment-17550581 ]
ASF subversion and git services commented on PROTON-2554: --------------------------------------------------------- Commit c0927ce8e2212d6f4b49cdbcc7d31d46c15f8c80 in qpid-proton-j's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-proton-j.git;h=c0927ce8 ] PROTON-2554 Fix composite buffer read string APIs position updates The API indicates the read string methods should advance the position to the limit but the composite is not doing that. > [proton-j] CompositeReadableBuffer read string API not advancing position > index > ------------------------------------------------------------------------------- > > Key: PROTON-2554 > URL: https://issues.apache.org/jira/browse/PROTON-2554 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j > Affects Versions: proton-j-0.33.10 > Reporter: Timothy A. Bish > Assignee: Timothy A. Bish > Priority: Major > Fix For: proton-j-0.34.0 > > > The ReadableBuffer API provides methods for reading a string from the > remaining readable bytes in the buffer and documents these methods should > advance the read index to the limit on return. The composite readable buffer > isn't advancing the position as it passes the bytes off to a CharsetDecoder > as a raw array and doesn't complete the operation with a position(limit) > call. This is masked in proton-j currently as all string decodes are done > from slices of a buffer or in some cases a duplicate and the buffer slice is > cast off afterwards without care for any remaining bytes. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org