[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362269#comment-15362269
]
Keith Wall commented on QPID-6954:
--
Changes look reasonable to me.
> [Java Broker] Add th
[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362252#comment-15362252
]
ASF subversion and git services commented on QPID-6954:
---
Commit 17514
[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351193#comment-15351193
]
ASF subversion and git services commented on QPID-6954:
---
Commit 17503
[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351002#comment-15351002
]
ASF subversion and git services commented on QPID-6954:
---
Commit 17503
[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350943#comment-15350943
]
ASF subversion and git services commented on QPID-6954:
---
Commit 17503
[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350927#comment-15350927
]
Rob Godfrey commented on QPID-6954:
---
[~k-wall] On your first point, the function is a con
[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350908#comment-15350908
]
Keith Wall commented on QPID-6954:
--
Rob, the changes look good:
Two comments:
* In
{{or
[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350885#comment-15350885
]
ASF subversion and git services commented on QPID-6954:
---
Commit 17503
[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349012#comment-15349012
]
ASF subversion and git services commented on QPID-6954:
---
Commit 17501
[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346682#comment-15346682
]
Keith Wall commented on QPID-6954:
--
My comments on the implementation:
* {{AbstractVirtual
[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060141#comment-15060141
]
ASF subversion and git services commented on QPID-6954:
---
Commit 17203
[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058806#comment-15058806
]
ASF subversion and git services commented on QPID-6954:
---
Commit 17202
[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058768#comment-15058768
]
ASF subversion and git services commented on QPID-6954:
---
Commit 17202
[
https://issues.apache.org/jira/browse/QPID-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058766#comment-15058766
]
ASF subversion and git services commented on QPID-6954:
---
Commit 17202
14 matches
Mail list logo