Chris Richardson created QPID-8186:
--------------------------------------
Summary: Incorrect exception handling fails to build on GCC 8
Key: QPID-8186
URL: https://issues.apache.org/jira/browse/QPID-8186
Project: Qpid
Issue Type: Bug
Affects Versions: qpid-cpp-1.38.0
Environment: Gentoo x64
Reporter: Chris Richardson
Fix For: qpid-cpp-1.39.0
[ 22%] Building CXX object
src/CMakeFiles/qpidcommon.dir/qpid/sys/ssl/check.cpp.o
/home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:
In member function ‘bool qpid::sys::SocketAddress::isComparable(const
qpid::sys::SocketAddress&) const’:
/home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:208:18:
error: catching polymorphic type ‘class qpid::Exception’ by value
[-Werror=catch-value=]
} catch (Exception) {
^~~~~~~~~
/home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:212:14:
error: catching polymorphic type ‘class qpid::Exception’ by value
[-Werror=catch-value=]
} catch (Exception) {
^~~~~~~~~
these "catch (Exception)" statements would better be const ref, which would
also fix the build failure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
