Re: Pre commit hook for Apache License Header ?

2011-02-16 Thread Rajith Attapattu
The automated RAT report is a good alternative IMO. However I still think a license check is not a bad idea as it will only come into play when somebody adds a file. It seems other have atleast tried this. http://osdir.com/ml/windows.dotnet.castleproject.devel/2005-07/msg00266.html Rajith On Tue

Re: Pre commit hook for Apache License Header ?

2011-02-15 Thread Andrew Kennedy
On 15 Feb 2011, at 19:49, Robbie Gemmell wrote: There is scope for inaccurate results on licence matching, and exceptions could also be a pain if conducted pre-commit, so I'm not sure it should be a commit hook. We should really just have RAT running automated checks for us on the ASF CI boxes (a

Re: Pre commit hook for Apache License Header ?

2011-02-15 Thread Robbie Gemmell
There is scope for inaccurate results on licence matching, and exceptions could also be a pain if conducted pre-commit, so I'm not sure it should be a commit hook. We should really just have RAT running automated checks for us on the ASF CI boxes (along with several other types of testing...) on a

Re: Pre commit hook for Apache License Header ?

2011-02-15 Thread Rajith Attapattu
On Tue, Feb 15, 2011 at 12:43 PM, Emmanuel Bourg wrote: > Le 15/02/2011 17:21, Rajith Attapattu a écrit : > > Hi All, >> >> It seems there is good support for adding a pre-commit hook for checking >> JIRA reference. >> While we are at it, I'd like to draw your attention to another problem >> tha

Re: Pre commit hook for Apache License Header ?

2011-02-15 Thread Emmanuel Bourg
Le 15/02/2011 17:21, Rajith Attapattu a écrit : Hi All, It seems there is good support for adding a pre-commit hook for checking JIRA reference. While we are at it, I'd like to draw your attention to another problem that makes a release managers job unnecessarily tedious. We all have been guilt

Pre commit hook for Apache License Header ?

2011-02-15 Thread Rajith Attapattu
Hi All, It seems there is good support for adding a pre-commit hook for checking JIRA reference. While we are at it, I'd like to draw your attention to another problem that makes a release managers job unnecessarily tedious. We all have been guilty of adding files to the svn repo without the mand