Re: Remove printStackTrace from client and common

2009-11-10 Thread Rafael Schloming
Aidan Skinner wrote: QPID-2192 is a bug a user raised about the random printStackTrace calls that are littered about the place. This patch deletes all of the ones in java/client and java/common I found that they might run into. I'll commit this on Wednesday if nobody objects. The tests all pass a

Re: Remove printStackTrace from client and common

2009-11-10 Thread Robert Godfrey
2009/11/10 Martin Ritchie > 2009/11/10 Robert Godfrey : > > Hi Aidan, > > > > Why did you remove the setting of the linked exception here: > > > > --- > > > a/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java > > +++ > > > b/qpid/java/client/src/main/java/org/ap

Re: Remove printStackTrace from client and common

2009-11-10 Thread Martin Ritchie
2009/11/10 Robert Godfrey : > Hi Aidan, > > Why did you remove the setting of the linked exception here: > > --- > a/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java > +++ > b/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java >

Re: Remove printStackTrace from client and common

2009-11-10 Thread Rajith Attapattu
Looks fine to me. Rajith On Tue, Nov 10, 2009 at 8:13 AM, Aidan Skinner wrote: > On Tue, Nov 10, 2009 at 3:40 AM, Robert Godfrey > wrote: > >> Hi Aidan, >> >> Why did you remove the setting of the linked exception here: > > Slippy fingers and tired eyes while looking at the diff. I'll put it b

Re: Remove printStackTrace from client and common

2009-11-10 Thread Aidan Skinner
On Tue, Nov 10, 2009 at 3:40 AM, Robert Godfrey wrote: > Hi Aidan, > > Why did you remove the setting of the linked exception here: Slippy fingers and tired eyes while looking at the diff. I'll put it back. :) > Also, we probably want to communicate the stack trace somehow in > > --- > a/qpid/j

Re: Remove printStackTrace from client and common

2009-11-09 Thread Robert Godfrey
Hi Aidan, Why did you remove the setting of the linked exception here: --- a/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java +++ b/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java @@ -180,8 +180,6 @@ public class BasicMessag

Remove printStackTrace from client and common

2009-11-09 Thread Aidan Skinner
QPID-2192 is a bug a user raised about the random printStackTrace calls that are littered about the place. This patch deletes all of the ones in java/client and java/common I found that they might run into. I'll commit this on Wednesday if nobody objects. The tests all pass and they're fairly clear