Re: Review Request: Add management hooks into ACL lookup engine for C++ broker

2012-04-04 Thread Ted Ross
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4525/#review6693 --- Ship it! This looks great. Clean up the whitespace in the Python cod

Re: Review Request: Add management hooks into ACL lookup engine for C++ broker

2012-04-04 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4525/#review6690 --- Ship it! Except for the whitespace, this looks good. trunk/qpid/cpp

Re: Review Request: Add management hooks into ACL lookup engine for C++ broker

2012-04-04 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4525/#review6691 --- Ship it! - Alan On 2012-04-04 15:42:02, Chug Rolke wrote: > >

Re: Review Request: Add management hooks into ACL lookup engine for C++ broker

2012-04-04 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4525/#review6619 --- - Alan On 2012-04-04 15:42:02, Chug Rolke wrote: > > --

Re: Review Request: Add management hooks into ACL lookup engine for C++ broker

2012-04-04 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4525/ --- (Updated 2012-04-04 15:42:02.279036) Review request for qpid, Alan Conway, Gordo

Re: Review Request: Add management hooks into ACL lookup engine for C++ broker

2012-03-30 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4525/ --- (Updated 2012-03-30 15:54:07.491139) Review request for qpid, Alan Conway, Gordo

Re: Review Request: Add management hooks into ACL lookup engine for C++ broker

2012-03-27 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4525/#review6454 --- trunk/qpid/cpp/src/qpid/acl/Acl.cpp

Re: Review Request: Add management hooks into ACL lookup engine for C++ broker

2012-03-27 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4525/#review6449 --- trunk/qpid/cpp/src/qpid/Modules.cpp

Review Request: Add management hooks into ACL lookup engine for C++ broker

2012-03-27 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4525/ --- Review request for qpid, Alan Conway, Gordon Sim, and rajith attapattu. Summary