Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/#review15837 --- Is abort() the right call to make? What about close()? It looks to

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Alan Conway
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Alan Conway
On Jan. 29, 2013, 9:59 p.m., Andrew Stitcher wrote: /trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp, line 99 https://reviews.apache.org/r/9137/diff/2/?file=253082#file253082line99 I don't think this should be protected by !readError as the read and write sides are independent.

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Gordon Sim
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Andrew Stitcher
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Alan Conway
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/#review15855 --- Ship it! I'm happy to have this code change in trunk, even if

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Gordon Sim
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Andrew Stitcher
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Gordon Sim
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Andrew Stitcher
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Gordon Sim
On Jan. 30, 2013, 12:28 p.m., Gordon Sim wrote: Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/ --- (Updated Jan. 30, 2013, 6:39 p.m.) Review request for qpid and Andrew Stitcher.

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/ --- (Updated Jan. 30, 2013, 6:40 p.m.) Review request for qpid and Andrew Stitcher.

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-30 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/ --- (Updated Jan. 30, 2013, 6:40 p.m.) Review request for qpid and Andrew Stitcher.

Review Request: HA Fix race condition in rejecting connections.

2013-01-29 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/ --- Review request for qpid and Andrew-Duplicate-Accct-Inactiv Konwinski.

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-29 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/ --- (Updated Jan. 29, 2013, 9:49 p.m.) Review request for qpid and

Re: Review Request: HA Fix race condition in rejecting connections.

2013-01-29 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/#review15809 --- /trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp